From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2747EC433F5 for ; Sat, 23 Oct 2021 09:53:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F124160EB8 for ; Sat, 23 Oct 2021 09:53:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230121AbhJWJ4B (ORCPT ); Sat, 23 Oct 2021 05:56:01 -0400 Received: from mail-ed1-f45.google.com ([209.85.208.45]:42521 "EHLO mail-ed1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230104AbhJWJ4B (ORCPT ); Sat, 23 Oct 2021 05:56:01 -0400 Received: by mail-ed1-f45.google.com with SMTP id w15so522629edc.9; Sat, 23 Oct 2021 02:53:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O9Rb9NtokiMkDgVECkBf3jx/VCvIk8TeI7+YpJW1Fwo=; b=FSKSo5jQIe3nTYkJMxHapKiJMl31rsVIHYH4SAiL7vAM+PHEq7vlCRTfrEoS4bJ1Fr Zcjj1IcLTYaWwJXf//nxVRsiQ1ulNOhdW61GmQRYQy64tds0MEkI3BKlToJa4gGAhKqW yQEXHkzHHPCwfQtj2aZG6JIDnbBMaaLKm1RhTEG+yjieVY98o2iLX7xCkziBs/PP8FaN BDj8/YMlfpHugk5ThV7xGXVaYE2ToiQ+ewpVm5otcBZUZCbKa5cMP+RS2V8Xzkgdjudf AiRSk8z8i0vJxXWxisGVXsh2bnF1EGr46WePextHmMz+/gCJ7qK0QrFaCbf8QAMb8QZI rBcA== X-Gm-Message-State: AOAM533S7U8J8ZVGz0UaxFn2CwLirjVQ+h0dqrP7cvwRqP+y52b9sJo9 BJn3b/ZDn909/GbK80eezQk= X-Google-Smtp-Source: ABdhPJwVIXLBQ0vc4x07Rr+ZeyW3N4/87ZMumw1JvUUOJuIoVhZhvZe7EUOpXbLHg5Y5aXiOhsy4bg== X-Received: by 2002:a05:6402:3585:: with SMTP id y5mr7616596edc.323.1634982821528; Sat, 23 Oct 2021 02:53:41 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id f9sm283635edt.7.2021.10.23.02.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 02:53:40 -0700 (PDT) Date: Sat, 23 Oct 2021 11:53:39 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Richard Zhu Cc: Bjorn Helgaas , "l.stach@pengutronix.de" , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" , "linux-pci@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up Message-ID: References: <20211015184943.GA2139079@bhelgaas> <20211015185141.GA2139462@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, [...] > > > > > - default: > > > > > - break; > > > > > > While you're at it, this "default: break;" thing is pointless. > > > Normally it's better to just *move* something without changing it at > > > all, but this is such a simple thing I think you could drop this at > > > the same time as the move. > > > > > [Richard Zhu] Okay, got that. Would remove the "default:break" later. Thanks. > [Richard Zhu] I figure out that the default:break is required by IMX6Q/IMX6QP. > So I just don't drop them in v3 patch-set. I hope you don't mind me asking, but how is an empty default case in the switch statement helping IMX6Q and IMX6QP? What does it achieve for these two controllers specifically? Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20074C433EF for ; Sat, 23 Oct 2021 09:54:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1CDF60EB8 for ; Sat, 23 Oct 2021 09:54:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E1CDF60EB8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nd+XkXWyV3AtCHGc8njtnJHMKmOtp+uwrcGY456CCcU=; b=t4jd+WE4L01VHj oDgv9yXA/1o1apUD0eNVUuIFT81l6XwX0kCgVmrTRJmN7n8DPhGwXItGZ6YhTAquBKM1qM3EYXYoH QxI9hEW+xnT68KPBmG4mubg9wben1V9glGMK8RUnbugGaqchhLuLG7xXbSl7+FTVM0Bi5RGKVi9A0 EtsS0oLnqpE+jnv/a9dYJ1hWudfvRCsmHNPlsO/22Qa0oZtvM+ZdZVSd/R78PBzEAKFOlOGfcAAY+ CwzHFFrhlVsTNrPtiq/RS2mJdzKuXmWZa4WW29u1aQ/irtiqL071IgLw60x+SJaonbOsdrQTi4/Af C0YmTJqrtAqF5RAGKeyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1meDin-00CUx8-AW; Sat, 23 Oct 2021 09:53:49 +0000 Received: from mail-ed1-f51.google.com ([209.85.208.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1meDij-00CUw6-Nn for linux-arm-kernel@lists.infradead.org; Sat, 23 Oct 2021 09:53:46 +0000 Received: by mail-ed1-f51.google.com with SMTP id z20so1952730edc.13 for ; Sat, 23 Oct 2021 02:53:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=O9Rb9NtokiMkDgVECkBf3jx/VCvIk8TeI7+YpJW1Fwo=; b=Z4OX+WSmDm7AKqCvqQ1TaWWCEFO4p7oG3bjgn36dZWdOK7Ws2fFZVDOYaP1I09+5+3 nmRAErUKWUjbNhs+qmHlWpPeUmQhujziNIei9HkWTygtKOpjhAEjB1HmpgZxyLkUC9IE v5PzDSDL6pu14htjnG21cCqyd/XjJYmXJSRCJtAnKP6FXxjfeJUJKnM+gdZU1rSBnWa/ YekHudiXuGKTb2bkpmx7pP+7LEQ3i36cLc023dPUMfPO0yGn+4g4PDPRfG2kseD7ww9Y R6Wtrtbbv6sqJfY1ZPPl1it8wSGDqcvELcBBBiUxmB3tjOrbSCxDtdESg0IforNf5l9/ MH1A== X-Gm-Message-State: AOAM531Skbh38fGm5sCKBt9fLyJYaRcK2SoYEogNgiFr8LkATakn+eSj gBEMIVv+HKD9NMlfe3djCQk= X-Google-Smtp-Source: ABdhPJwVIXLBQ0vc4x07Rr+ZeyW3N4/87ZMumw1JvUUOJuIoVhZhvZe7EUOpXbLHg5Y5aXiOhsy4bg== X-Received: by 2002:a05:6402:3585:: with SMTP id y5mr7616596edc.323.1634982821528; Sat, 23 Oct 2021 02:53:41 -0700 (PDT) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id f9sm283635edt.7.2021.10.23.02.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 02:53:40 -0700 (PDT) Date: Sat, 23 Oct 2021 11:53:39 +0200 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Richard Zhu Cc: Bjorn Helgaas , "l.stach@pengutronix.de" , "bhelgaas@google.com" , "lorenzo.pieralisi@arm.com" , "linux-pci@vger.kernel.org" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling unbalance when link never came up Message-ID: References: <20211015184943.GA2139079@bhelgaas> <20211015185141.GA2139462@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211023_025345_796255_9D0C7E34 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, [...] > > > > > - default: > > > > > - break; > > > > > > While you're at it, this "default: break;" thing is pointless. > > > Normally it's better to just *move* something without changing it at > > > all, but this is such a simple thing I think you could drop this at > > > the same time as the move. > > > > > [Richard Zhu] Okay, got that. Would remove the "default:break" later. Thanks. > [Richard Zhu] I figure out that the default:break is required by IMX6Q/IMX6QP. > So I just don't drop them in v3 patch-set. I hope you don't mind me asking, but how is an empty default case in the switch statement helping IMX6Q and IMX6QP? What does it achieve for these two controllers specifically? Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel