From: Vinod Koul <vkoul@kernel.org>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Zou Wei <zou_wei@huawei.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: rcar-dmac: refactor the error handling code of rcar_dmac_probe
Date: Mon, 25 Oct 2021 09:54:02 +0530 [thread overview]
Message-ID: <YXYxYsqpJbl4eS+j@matsya> (raw)
In-Reply-To: <20211020143546.3436205-1-mudongliangabcd@gmail.com>
On 20-10-21, 22:35, Dongliang Mu wrote:
> In rcar_dmac_probe, if pm_runtime_resume_and_get fails, it forgets to
> disable runtime PM. And of_dma_controller_free should only be invoked
> after the success of of_dma_controller_register.
>
> Fix this by refactoring the error handling code.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-10-25 4:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 14:35 [PATCH] dmaengine: rcar-dmac: refactor the error handling code of rcar_dmac_probe Dongliang Mu
2021-10-21 8:57 ` Geert Uytterhoeven
2021-10-22 6:35 ` Laurent Pinchart
2021-10-25 4:24 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXYxYsqpJbl4eS+j@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.