All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pavel Hofman <pavel.hofman@ivitera.com>
Cc: linux-usb@vger.kernel.org,
	Ruslan Bilovol <ruslan.bilovol@gmail.com>,
	Felipe Balbi <balbi@kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Jack Pham <jackp@codeaurora.org>
Subject: Re: [PATCH] usb:gadget: f_uac1: fixed sync playback
Date: Mon, 25 Oct 2021 09:19:09 +0200	[thread overview]
Message-ID: <YXZabbR5pEsc/mE3@kroah.com> (raw)
In-Reply-To: <20211022140339.248669-1-pavel.hofman@ivitera.com>

On Fri, Oct 22, 2021 at 04:03:39PM +0200, Pavel Hofman wrote:
> The u_audio param fb_max was not set to its default value in f_uac1.c.
> As a result the maximum value of Playback Pitch ctl was kept at 1000000,
> not allowing to set faster playback pitch for UAC1.
> 
> The setting required moving the default constant UAC2_DEF_FB_MAX from
> u_uac2.h to FBACK_FAST_MAX in u_audio.h as that header is common for
> f_uac1.c and f_uac2.c.
> 
> Fixes: 6fec018 ("usb: gadget: u_audio.c: Adding Playback Pitch ctl for
>                  sync playback")

Nit, in the future the format for this is:

Fixes: 6fec018a7e70 ("usb: gadget: u_audio.c: Adding Playback Pitch ctl for sync playback")

The kernel documentation about submitting patches should describe this.

I'll go hand-edit it, no worries this time.

thanks,

greg k-h

      reply	other threads:[~2021-10-25  7:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22 14:03 [PATCH] usb:gadget: f_uac1: fixed sync playback Pavel Hofman
2021-10-25  7:19 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXZabbR5pEsc/mE3@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@kernel.org \
    --cc=jackp@codeaurora.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pavel.hofman@ivitera.com \
    --cc=ruslan.bilovol@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.