From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5bdb:0:0:0:0:0 with SMTP id u27csp88448lfn; Mon, 25 Oct 2021 04:26:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZWZkaREqrzAhfYQsBc34ObkNTAUsOf7pFN8cxpZXJObku0/KqEpAXPBzeB1Q5PLd0RSGG X-Received: by 2002:a4a:b544:: with SMTP id s4mr6630774ooo.94.1635161185832; Mon, 25 Oct 2021 04:26:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635161185; cv=none; d=google.com; s=arc-20160816; b=sRRc2CoJJn71qS0839lJCEzH5cFoDQfljavWY43kGeVZK1IZYWXf2Yy3ey2Cif/oe6 PdvjcmoziecWK76n5nx9QZEm7PXXoxnDYFKtEYZDmvSPPP6hKbG4il0Q8MSU1ozy/qZL ms40ugg2Cn/8fj2L3rGY5Zz7bnR73fNDfRlCWuC1drXQIfcF+ziSGrToEm4kIGk25ArL 13IOBqrk07i+YDltNHmwFN6Y9sRC1SixP/m+zamdRqKB+PmFx6Gybpe/AokKbq+Woxjk Nreos2CFt8kDHQmGvJcdTRRT+x6hsDxhtpxg/FH6DOsndRU9THAR77t+Qhr0BC5T0/1n fktA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=f/BAa9sp94NqKP5B4c9amJsD3bi6NZ608OY5VYA4uqE=; b=uRufIOWlCeAWTGE0onDwXjVFwmbtfR7Fjmmfd/7HFdeS/hncbWo/kEGKqXkabwrGUN +BsXtcvaC63NjQN4Cl9gp5IgmuomBZRRbXTOxLQrzsfUtLl0zS6DrWwD4nLV5U3iQ9+p s3TiQu7v1XTkltntkytH/NHrFlJ+OgNdTpogYxJejKKfjHMspmEpEn4ktlMhscDE42qX YemRJsypJr8AF8m/YbYwtLxp2hxtX4ePHkxcimF25forfvVy+bk0vHcDuZTrs/jhAMwb U4/DQ938pqPWwPePLRhLehEM0wmkKdrga3qloXfGT4E3AnFVbxe8FSTiViTk2zF/OiyW CBiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=o1OGSyCJ; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id r206si18878568oib.52.2021.10.25.04.26.25 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Oct 2021 04:26:25 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=o1OGSyCJ; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:58276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mey7V-0002l1-2i for alex.bennee@linaro.org; Mon, 25 Oct 2021 07:26:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mey5M-0001lv-JR for qemu-devel@nongnu.org; Mon, 25 Oct 2021 07:24:12 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:43822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mey5K-0005Y1-NX for qemu-devel@nongnu.org; Mon, 25 Oct 2021 07:24:12 -0400 Received: by mail-wr1-x42b.google.com with SMTP id p14so6223163wrd.10 for ; Mon, 25 Oct 2021 04:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=f/BAa9sp94NqKP5B4c9amJsD3bi6NZ608OY5VYA4uqE=; b=o1OGSyCJNkg1a7pxKx9kbTn9TVAJuVA8ju/EIaC8BXlVnigqhnzGL7/MJhQWH+EhQN 2UEPkPVZL4XOdJD3q5HjQSJsJfKcq1qgW9iSqu54Zgvwmx351SEDaXkKUZ+n+7cMfNmu 45MkKGOtZdciD9pQqcB4d9uPJ3jmXXhhp4+RbpWr8BE5EcjhpCOd95pvvTPxifrxj4Sc QaSvNW4e4RvWU08QVo7aP2lRA0VYm4CgQfSx6N4HhSvvEm/NetOMqr3wworBwJ+QEwF2 ugIrP4VzKTVZyGKgMVBc7xpgJGXhhHmbZVzBBzc/fYHfiIoIccwQnBm+QezxANEFwW9n ZftA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f/BAa9sp94NqKP5B4c9amJsD3bi6NZ608OY5VYA4uqE=; b=XwZxgD1TUFAUa5y0azJumDPv68TrDwR8XbEUQ4gWxU6HqWaQYT3SB6hSTgltMNtAZ2 79JWY1de9VrKbxGW44B2VP9obdG7Dv3ZZVWje0FXjXmEjHb6fDL0b3qrwVQNydRWqoH2 zTgSFJztdqH7VYmpSHRMuCKIDu+0LWoSCssMLqR7X7GSBCUoM/Ix8SFx0g2pKXJX1kS5 ZK2cc3ChjUKWARvBggQpDb/lm3k1IEkRmTp+DSIcjj1Cg6X+FD+ExEg2y8ifE03n2ywk e6rZo/ltVLNorOTXpZnoGGNNgPO31B4iPI5M00ic6rQXGanX7wu3c22xe/yh1C4VuHFS XBlw== X-Gm-Message-State: AOAM531S1+56nPZAIUQTVdQwlic+c2cpE6R0ViVsmH1n4THBJgD24ISY nKLyWJqj1pZqBKolfc7JWc0kFw== X-Received: by 2002:adf:ec03:: with SMTP id x3mr16034800wrn.281.1635161048942; Mon, 25 Oct 2021 04:24:08 -0700 (PDT) Received: from myrica (cpc92880-cmbg19-2-0-cust679.5-4.cable.virginm.net. [82.27.106.168]) by smtp.gmail.com with ESMTPSA id n25sm3555479wms.10.2021.10.25.04.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 04:24:08 -0700 (PDT) Date: Mon, 25 Oct 2021 12:23:46 +0100 From: Jean-Philippe Brucker To: Igor Mammedov Subject: Re: [PATCH v5 04/12] hw/i386/pc: Allow instantiating a virtio-iommu device Message-ID: References: <20211020172745.620101-1-jean-philippe@linaro.org> <20211020172745.620101-5-jean-philippe@linaro.org> <20211021154709.14da294a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211021154709.14da294a@redhat.com> Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=jean-philippe@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ehabkost@redhat.com, mst@redhat.com, jasowang@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, peterx@redhat.com, shannon.zhaosl@gmail.com, qemu-arm@nongnu.org, ani@anisinha.ca, pbonzini@redhat.com, eric.auger@redhat.com Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: vob6WGTnE1i2 On Thu, Oct 21, 2021 at 03:47:09PM +0200, Igor Mammedov wrote: > On Wed, 20 Oct 2021 18:27:38 +0100 > Jean-Philippe Brucker wrote: > > > Allow instantiating a virtio-iommu device by adding an ACPI Virtual I/O > > Translation table (VIOT), which describes the relation between the > > virtio-iommu and the endpoints it manages. > > > > Add a hotplug handler for virtio-iommu on x86 and set the necessary > > reserved region property. On x86, the [0xfee00000, 0xfeefffff] DMA > > region is reserved for MSIs. DMA transactions to this range either > > trigger IRQ remapping in the IOMMU or bypasses IOMMU translation. > > shouldn't above be "IO remapping"? No it is IRQ remapping: DMA writes to this address range are interrupt requests and the IOMMU may either perform interrupt remapping or pass it to the APIC directly > > > Although virtio-iommu does not support IRQ remapping it must be informed > > of the reserved region so that it can forward DMA transactions targeting > > this region. > > > > Reviewed-by: Eric Auger > > Tested-by: Eric Auger > > Signed-off-by: Jean-Philippe Brucker > > Reviewed-by: Igor Mammedov Thanks! Jean