From: Greg KH <gregkh@linuxfoundation.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: bp@suse.de, akpm@linux-foundation.org, josh@joshtriplett.org,
rishabhb@codeaurora.org, kubakici@wp.pl, maco@android.com,
david.brown@linaro.org, bjorn.andersson@linaro.org,
linux-wireless@vger.kernel.org, keescook@chromium.org,
shuah@kernel.org, mfuzzey@parkeon.com, zohar@linux.vnet.ibm.com,
dhowells@redhat.com, pali.rohar@gmail.com, tiwai@suse.de,
arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com,
broonie@kernel.org, dmitry.torokhov@gmail.com,
dwmw2@infradead.org, torvalds@linux-foundation.org,
Abhay_Salunke@dell.com, jewalt@lgsinnovations.com,
cantabile.desu@gmail.com, ast@fb.com, andresx7@gmail.com,
brendanhiggins@google.com, yzaikin@google.com,
sfr@canb.auug.org.au, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] firmware_loader: rename EXTRA_FIRMWARE and EXTRA_FIRMWARE_DIR
Date: Mon, 25 Oct 2021 20:24:28 +0200 [thread overview]
Message-ID: <YXb2XLiXSNvflVI1@kroah.com> (raw)
In-Reply-To: <YXbSXSGO3uK7W3IO@bombadil.infradead.org>
On Mon, Oct 25, 2021 at 08:50:53AM -0700, Luis Chamberlain wrote:
> On Sat, Oct 23, 2021 at 08:43:37AM +0200, Greg KH wrote:
> > On Fri, Oct 22, 2021 at 10:40:38AM -0700, Luis Chamberlain wrote:
> > > Now that we've tied loose ends on the built-in firmware API,
> > > rename the kconfig symbols for it to reflect more that they are
> > > associated to the firmware_loader and to make it easier to
> > > understand what they are for.
> > >
> > > Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> >
> > This patch has the same bug I pointed out the last time I reviewed it :(
>
> Sorry I missed it, but I checked and I can't see where, can you point
> that out in the patch?
https://lore.kernel.org/r/YXKsNNONY/TlsK8a@kroah.com
next prev parent reply other threads:[~2021-10-25 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 17:40 [PATCH v3 0/4] firmware_loader: built-in API and make x86 use it Luis Chamberlain
2021-10-22 17:40 ` [PATCH v3 1/4] firmware_loader: rename EXTRA_FIRMWARE and EXTRA_FIRMWARE_DIR Luis Chamberlain
2021-10-23 6:43 ` Greg KH
2021-10-25 15:50 ` Luis Chamberlain
2021-10-25 18:24 ` Greg KH [this message]
2021-10-22 17:40 ` [PATCH v3 2/4] firmware_loader: move builtin build helper to shared library Luis Chamberlain
2021-10-22 17:40 ` [PATCH v3 3/4] test_firmware: move a few test knobs out to its library Luis Chamberlain
2021-10-22 17:40 ` [PATCH v3 4/4] test_firmware: add support for testing built-in firmware Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXb2XLiXSNvflVI1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Abhay_Salunke@dell.com \
--cc=akpm@linux-foundation.org \
--cc=andresx7@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=ast@fb.com \
--cc=bjorn.andersson@linaro.org \
--cc=bp@suse.de \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=cantabile.desu@gmail.com \
--cc=david.brown@linaro.org \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jewalt@lgsinnovations.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=kubakici@wp.pl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maco@android.com \
--cc=mcgrof@kernel.org \
--cc=mfuzzey@parkeon.com \
--cc=nbroeking@me.com \
--cc=pali.rohar@gmail.com \
--cc=rdunlap@infradead.org \
--cc=rishabhb@codeaurora.org \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=yzaikin@google.com \
--cc=zajec5@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.