From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-usb@vger.kernel.org, John Keeping <john@metanate.com>
Subject: Re: [PATCH] usb: remove res2 argument from gadget code completions
Date: Mon, 25 Oct 2021 17:25:49 +0200 [thread overview]
Message-ID: <YXbMfVpXdMwfsSU3@kroah.com> (raw)
In-Reply-To: <f026d10f-d659-b180-92fb-c5c087bcefd9@kernel.dk>
On Mon, Oct 25, 2021 at 09:23:58AM -0600, Jens Axboe wrote:
> The USB gadget code is the only code that every tried to utilize the
> 2nd argument of the aio completions, but there are strong suspicions
> that it was never actually used by anything on the userspace side.
>
> Out of the 3 cases that touch it, two of them just pass in the same
> as res, and the last one passes in error/transfer in res like any
> other normal use case.
>
> Remove the 2nd argument, pass 0 like the rest of the in-kernel users
> of kiocb based IO.
>
> Link: https://lore.kernel.org/linux-block/20211021174021.273c82b1.john@metanate.com/
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> ---
>
> Greg/John - if you guys are fine with this patch, let me know. I've got
> the ->ki_complete() argument removal sitting on top of this.
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2021-10-25 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 15:23 [PATCH] usb: remove res2 argument from gadget code completions Jens Axboe
2021-10-25 15:25 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXbMfVpXdMwfsSU3@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=john@metanate.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.