From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 689DFC433F5 for ; Mon, 25 Oct 2021 15:50:54 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 475A360EBD for ; Mon, 25 Oct 2021 15:50:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 475A360EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7220A16CF; Mon, 25 Oct 2021 17:50:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7220A16CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1635177051; bh=T2GFghtcHNLOa+MHlF+E5+QAYjJCxcjLCfKLLCipAH4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pCeY0L2vZNSYxC6j+UTJUxvlqJwSOU8Z5TAuIaLY8N5mEQPdNui61ifxmkZnso/aU KeQxz+z2MuNbqPS1DlDxZPQIMeyCTV3Cucl6TirTzPVetESBWk0ETczgUCLaek9XFg zQQ9rlLTvMgfvvyvIs9m96u9BSTM7eH+ltKAcho8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 02678F80166; Mon, 25 Oct 2021 17:50:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E96FDF8025A; Mon, 25 Oct 2021 17:49:59 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CA56DF80153 for ; Mon, 25 Oct 2021 17:49:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CA56DF80153 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mFuQs7jL" Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A0C660720; Mon, 25 Oct 2021 15:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635176992; bh=T2GFghtcHNLOa+MHlF+E5+QAYjJCxcjLCfKLLCipAH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mFuQs7jLqq/WU6egj7Y2jXE6PJKp2mLT6hEHQiLsOUunNc6GH0IpXADIMVhMIhXEA PORFkUAzEWvvQ+6AHX1ZJoHcXD7CBuwtmTgBxtv7/BMJsfmCTODQepJ1fIoQPTLxWD f62rtPJbG636u2DCT0pYorjBjoLw3ZATtShC6fxXp8Nm45hD+QiGAX5vhcbGD23XaA 6tVnRdao1SJJdnLmg4fGXZtaCuOA1sUUEunD8K/2peIa7MJ3OqSNnfvQRwk5c8pkZR xvoIrGT3pRJe+tOEuYpi1g+FWx/KsUNjq9LyhdbT1FEOLepe+2GizdMYCUDz6p7krB 8fvw39vCtjE2w== Date: Mon, 25 Oct 2021 16:49:50 +0100 From: Mark Brown To: Srinivas Kandagatla Subject: Re: [PATCH v9 12/17] ASoC: qdsp6: audioreach: add Kconfig and Makefile Message-ID: References: <20211006113950.10782-1-srinivas.kandagatla@linaro.org> <20211006113950.10782-13-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="murvvOThzU63xl3q" Content-Disposition: inline In-Reply-To: <20211006113950.10782-13-srinivas.kandagatla@linaro.org> X-Cookie: Eschew obfuscation. Cc: robh@kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, devicetree@vger.kernel.org, tiwai@suse.de, lgirdwood@gmail.com, plai@codeaurora.org, pierre-louis.bossart@linux.intel.com, bjorn.andersson@linaro.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --murvvOThzU63xl3q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 06, 2021 at 12:39:45PM +0100, Srinivas Kandagatla wrote: > Now that all the code for audioreach and q6apm are in at this point to be > able to compile, start adding Kconfig and Makefile changes. This doesn't compile with current code for arm64 defconfig: /mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c: In function 'q6apm_audio_remove': /mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c:703:2: error: too few arguments to function 'snd_soc_tplg_component_remove' 703 | snd_soc_tplg_component_remove(component); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /mnt/kernel/include/sound/soc-dapm.h:15, from /mnt/kernel/include/sound/soc.h:386, from /mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c:15: /mnt/kernel/include/sound/soc-topology.h:191:19: note: declared here 191 | static inline int snd_soc_tplg_component_remove(struct snd_soc_component *comp, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This will be with the stub for !SND_SOC_TOPOLOGY, the index argument has been removed for the actual implementation but not for the stub, the fix is in the header. --murvvOThzU63xl3q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmF20h0ACgkQJNaLcl1U h9D++wf+JwyFgodfzmfQ+BPTjdLIw7DMvXZX2Je/xIfWADZ8tSg9r1D+LIflPdDP zYuCt2kQ28Zq2H7SIfG+W2crSSpAlG3cOjfkkevaclL8u0hDDFc2c2nJRYDBjtrz aph7S2rLmIt9H0LOPM3VghyS+eOxZRNecdVImbyjM0yOELoFVsGyfrXvLCaziSyz +7L2ouU7TNStXvT9AFmsG8Q3YJJTiEAqf/ZRtQUz2ksRwZKzGgIr8bBaolFdH0d7 figc2AXRChTMyj760seY86rHfUQjZ7SpmXwk3w6QvFpOMMh8FUHUYCLDbHTmegAM WANHyQqNwcoTsExew6Yl4NA8A7KQcw== =amHX -----END PGP SIGNATURE----- --murvvOThzU63xl3q-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21AF7C433EF for ; Mon, 25 Oct 2021 15:49:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C4CE60F02 for ; Mon, 25 Oct 2021 15:49:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233131AbhJYPwP (ORCPT ); Mon, 25 Oct 2021 11:52:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:60884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbhJYPwP (ORCPT ); Mon, 25 Oct 2021 11:52:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4A0C660720; Mon, 25 Oct 2021 15:49:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635176992; bh=T2GFghtcHNLOa+MHlF+E5+QAYjJCxcjLCfKLLCipAH4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mFuQs7jLqq/WU6egj7Y2jXE6PJKp2mLT6hEHQiLsOUunNc6GH0IpXADIMVhMIhXEA PORFkUAzEWvvQ+6AHX1ZJoHcXD7CBuwtmTgBxtv7/BMJsfmCTODQepJ1fIoQPTLxWD f62rtPJbG636u2DCT0pYorjBjoLw3ZATtShC6fxXp8Nm45hD+QiGAX5vhcbGD23XaA 6tVnRdao1SJJdnLmg4fGXZtaCuOA1sUUEunD8K/2peIa7MJ3OqSNnfvQRwk5c8pkZR xvoIrGT3pRJe+tOEuYpi1g+FWx/KsUNjq9LyhdbT1FEOLepe+2GizdMYCUDz6p7krB 8fvw39vCtjE2w== Date: Mon, 25 Oct 2021 16:49:50 +0100 From: Mark Brown To: Srinivas Kandagatla Cc: bjorn.andersson@linaro.org, robh@kernel.org, plai@codeaurora.org, pierre-louis.bossart@linux.intel.com, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, lgirdwood@gmail.com, bgoswami@codeaurora.org Subject: Re: [PATCH v9 12/17] ASoC: qdsp6: audioreach: add Kconfig and Makefile Message-ID: References: <20211006113950.10782-1-srinivas.kandagatla@linaro.org> <20211006113950.10782-13-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="murvvOThzU63xl3q" Content-Disposition: inline In-Reply-To: <20211006113950.10782-13-srinivas.kandagatla@linaro.org> X-Cookie: Eschew obfuscation. Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --murvvOThzU63xl3q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 06, 2021 at 12:39:45PM +0100, Srinivas Kandagatla wrote: > Now that all the code for audioreach and q6apm are in at this point to be > able to compile, start adding Kconfig and Makefile changes. This doesn't compile with current code for arm64 defconfig: /mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c: In function 'q6apm_audio_remove': /mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c:703:2: error: too few arguments to function 'snd_soc_tplg_component_remove' 703 | snd_soc_tplg_component_remove(component); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /mnt/kernel/include/sound/soc-dapm.h:15, from /mnt/kernel/include/sound/soc.h:386, from /mnt/kernel/sound/soc/qcom/qdsp6/q6apm.c:15: /mnt/kernel/include/sound/soc-topology.h:191:19: note: declared here 191 | static inline int snd_soc_tplg_component_remove(struct snd_soc_component *comp, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This will be with the stub for !SND_SOC_TOPOLOGY, the index argument has been removed for the actual implementation but not for the stub, the fix is in the header. --murvvOThzU63xl3q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmF20h0ACgkQJNaLcl1U h9D++wf+JwyFgodfzmfQ+BPTjdLIw7DMvXZX2Je/xIfWADZ8tSg9r1D+LIflPdDP zYuCt2kQ28Zq2H7SIfG+W2crSSpAlG3cOjfkkevaclL8u0hDDFc2c2nJRYDBjtrz aph7S2rLmIt9H0LOPM3VghyS+eOxZRNecdVImbyjM0yOELoFVsGyfrXvLCaziSyz +7L2ouU7TNStXvT9AFmsG8Q3YJJTiEAqf/ZRtQUz2ksRwZKzGgIr8bBaolFdH0d7 figc2AXRChTMyj760seY86rHfUQjZ7SpmXwk3w6QvFpOMMh8FUHUYCLDbHTmegAM WANHyQqNwcoTsExew6Yl4NA8A7KQcw== =amHX -----END PGP SIGNATURE----- --murvvOThzU63xl3q--