From: Mark Brown <broonie@kernel.org>
To: Ricard Wanderlof <ricardw@axis.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: codec: tlv320adc3xxx: New codec driver
Date: Mon, 25 Oct 2021 17:11:39 +0100 [thread overview]
Message-ID: <YXbXO1d1XDFwUXqA@sirena.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.21.2110251755410.26101@lnxricardw1.se.axis.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
On Mon, Oct 25, 2021 at 06:01:04PM +0200, Ricard Wanderlof wrote:
> I'll add it to the DT configuration, but I can't really see why the having
> an additional runtime control would be a lot of extra work.
> In a completely embedded system where the microphone is part of the
> internal design it makes sense not to have it controllable of course, but
> in a system where the microphone is an external component (i.e. plugged
> into a microphone connector), the system design might need for it to be
> user configurable.
In any design we really ought to have some explicit confirmation before
we allow users to go randomly changing voltages, it may cause damage if
someone gets it wrong. This means that the feature really ought to be
an opt in one if it's going to be there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-25 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 9:19 [PATCH 2/2] ASoC: codec: tlv320adc3xxx: New codec driver Ricard Wanderlof
2021-10-04 13:40 ` Mark Brown
2021-10-04 16:21 ` Ricard Wanderlof
2021-10-04 16:42 ` Mark Brown
2021-10-06 12:03 ` Ricard Wanderlof
2021-10-25 16:01 ` Ricard Wanderlof
2021-10-25 16:11 ` Mark Brown [this message]
2021-10-26 6:54 ` Ricard Wanderlof
2021-10-26 10:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXbXO1d1XDFwUXqA@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=ricardw@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.