From: Minchan Kim <minchan@kernel.org>
To: Ming Lei <ming.lei@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 0/4] zram: fix two races and one zram leak
Date: Mon, 25 Oct 2021 09:30:07 -0700 [thread overview]
Message-ID: <YXbbj7KhgAkgByp1@google.com> (raw)
In-Reply-To: <20211025025426.2815424-1-ming.lei@redhat.com>
On Mon, Oct 25, 2021 at 10:54:22AM +0800, Ming Lei wrote:
> Hello,
>
> Fixes three issues reported by Luis Chamberlain with one simpler approach:
>
> - race between between zram_reset_device() and disksize_store() (1/4)
>
> - zram leak during unloading module, which is one race between resetting
> and removing device (2/4)
>
> - race between zram_remove and disksize_store (3/4)
>
> Also replace replace fsync_bdev with sync_blockdev since no one opens
> it.(4/4)
>
> V3:
> - no code change
> - update commit log or comment as Luis suggested
> - add reviewed-by tag
>
> V2:
> - take another approach to avoid failing of zram_remove()
> - add patch to address race between zram_reset_device() and
> disksize_store()
>
>
> Ming Lei (4):
> zram: fix race between zram_reset_device() and disksize_store()
> zram: don't fail to remove zram during unloading module
> zram: avoid race between zram_remove and disksize_store
> zram: replace fsync_bdev with sync_blockdev
Andrew Morton usually takes zram patches so Ccing him.
Acked-by: Minchan Kim <minchan@kernel.org>
for all patches in this thread.
next prev parent reply other threads:[~2021-10-25 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 2:54 [PATCH V3 0/4] zram: fix two races and one zram leak Ming Lei
2021-10-25 2:54 ` [PATCH V3 1/4] zram: fix race between zram_reset_device() and disksize_store() Ming Lei
2021-10-25 2:54 ` [PATCH V3 2/4] zram: don't fail to remove zram during unloading module Ming Lei
2021-10-25 2:54 ` [PATCH V3 3/4] zram: avoid race between zram_remove and disksize_store Ming Lei
2021-10-25 2:54 ` [PATCH V3 4/4] zram: replace fsync_bdev with sync_blockdev Ming Lei
2021-10-25 16:30 ` Minchan Kim [this message]
2021-11-01 0:28 ` [PATCH V3 0/4] zram: fix two races and one zram leak Ming Lei
2021-11-02 20:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXbbj7KhgAkgByp1@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.