Re: [PATCH 6/6] usb: typec: qcom: Add pm8150b TCPM driver

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Mon, Oct 25, 2021 at 04:09:06PM +0100, Bryan O'Donoghue wrote:
> The PM8150b contains both a type-c controller and a power-delivery PHY.
> This driver binds both of those blocks together via a virtual TCPM driver.
> 
> qcom-pmic-tcpm.c is responsible for registering with tcpm and wrappers
>                  calls into the type-c and pdphy drivers from tcpm.
>                  Its up to qcom-pmic-tcpm.c to wait for both
>                  qcom-pmic-pdphy.c and qcom-pmic-typec.c to probe before
>                  registering a type-c port
> 
> qcom-pmic-pdphy.c implements a set functions that qcom-pmic-tcpm.c is
>                   responsible for interfacing with the pdphy hardware and
>                   processing power-delivery related calls from tcpm.
> 
> qcom-pmic-typec.c implements a similar interface for the typec hardware
>                   interface and is responsible for notifying and processing
>                   type-c related calls from tcpm.
> 
> In conjunction with appropriate entries in the platform dts we can
> establish a source or sink contract with a PD peer and indeed negotiate SBU
> alternative modes.
> 
> This code provides all of the same functionality as the existing
> qcom typec driver plus power-delivery as well.
> 
> As a result commit 6c8cf3695176 ("usb: typec: Add QCOM PMIC typec detection
> driver") can be deleted entirely.
> 
> References code from Jonathan Marek, Jack Pham, Wesley Cheng, Hemant Kumar,
> Guru Das Srinagesh and Ashay Jaiswal.
> 
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
>  MAINTAINERS                                   |   8 +
>  drivers/usb/typec/Makefile                    |   1 -
>  drivers/usb/typec/qcom-pmic-typec.c           | 262 --------

You removed the file and the Makefile entry, but you left the Kconfig
entry? Please remove that too.

>  drivers/usb/typec/tcpm/Kconfig                |  11 +
>  drivers/usb/typec/tcpm/Makefile               |   1 +
>  .../usb/typec/tcpm/qcom/qcom_pmic_tcpm_core.c | 345 ++++++++++
>  .../typec/tcpm/qcom/qcom_pmic_tcpm_pdphy.c    | 577 +++++++++++++++++
>  .../typec/tcpm/qcom/qcom_pmic_tcpm_pdphy.h    |  85 +++
>  .../typec/tcpm/qcom/qcom_pmic_tcpm_typec.c    | 593 ++++++++++++++++++
>  .../typec/tcpm/qcom/qcom_pmic_tcpm_typec.h    | 163 +++++
>  10 files changed, 1783 insertions(+), 263 deletions(-)
>  delete mode 100644 drivers/usb/typec/qcom-pmic-typec.c
>  create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_core.c
>  create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_pdphy.c
>  create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_pdphy.h
>  create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_typec.c
>  create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_tcpm_typec.h

You don't have a Makefile in that new directory typec/tcpm/qcom?
How do you compile these new drivers?

thanks,

-- 
heikki