From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0E6FC4332F for ; Tue, 26 Oct 2021 18:26:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B50A9610C7 for ; Tue, 26 Oct 2021 18:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233344AbhJZS2Y (ORCPT ); Tue, 26 Oct 2021 14:28:24 -0400 Received: from mail-oo1-f50.google.com ([209.85.161.50]:44030 "EHLO mail-oo1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbhJZS2W (ORCPT ); Tue, 26 Oct 2021 14:28:22 -0400 Received: by mail-oo1-f50.google.com with SMTP id w9-20020a4adec9000000b002b696945457so25912oou.10; Tue, 26 Oct 2021 11:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WSZr1Cmv5ob/1Jiww/LXg4dCpeepOagUPfg8Il8gYuM=; b=EePtaPGOB3J6o8dj0UURnEuTcInpq2bXJ87761mwopUBKcFb0t2zqwohMmih/Ybr2q YtgZkletKUWQqTH6q6ZPm/rUuVpDUmvtZVEMXkFXeQvJn1uE4pijYxWwPyBgvw8CXIPz 6HPZg63JaJVBP5Si2b7JSNGfgijRA1skphW1Fl0dbq/ctO1G18izmKYMI+WSRAAaFVbq qOaN3kkqgl61zqzJcOT+y6AuubIPYj/SwkK9uhifJdT8TnOdu930/DZojGWgBIgD15iS YzTxzI5bF04dZf8bqCP05cGKn9U0op+ep4wQwur+3ztD51pGhmpadX0AQPnNUCJ59smW QwLQ== X-Gm-Message-State: AOAM5327H2C0YkZySlkZ0sCeurc98DdkKtF0xpZacKZ0/a0mHNEigGoM Yz7WOHxXm2+HVLKpCoA4ODnv1PbUow== X-Google-Smtp-Source: ABdhPJyNyn/Hk6PjVvlo5IisYehjIBhdvSvZfsFty86k1Vn1vTJ5hS3CpO+0wtZQ56jT9ipU94EjHQ== X-Received: by 2002:a4a:d1c8:: with SMTP id a8mr2579386oos.12.1635272758233; Tue, 26 Oct 2021 11:25:58 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id x12sm4045585oot.6.2021.10.26.11.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 11:25:57 -0700 (PDT) Received: (nullmailer pid 2976480 invoked by uid 1000); Tue, 26 Oct 2021 18:25:56 -0000 Date: Tue, 26 Oct 2021 13:25:56 -0500 From: Rob Herring To: Hector Martin Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , Krzysztof Kozlowski , Greg Kroah-Hartman , Mark Kettenis , Philipp Zabel , "Rafael J. Wysocki" , Johan Hovold , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, Mark Kettenis Subject: Re: [PATCH v2 2/8] dt-bindings: arm: apple: Add apple,pmgr binding Message-ID: References: <20211025144718.157794-1-marcan@marcan.st> <20211025144718.157794-3-marcan@marcan.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211025144718.157794-3-marcan@marcan.st> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Oct 25, 2021 at 11:47:12PM +0900, Hector Martin wrote: > The PMGR block in Apple Silicon SoCs is responsible for SoC power > management. There are two PMGRs in T8103, with different register > layouts but compatible registers. In order to support this as well > as future SoC generations with backwards-compatible registers, we > declare these blocks as syscons and bind to individual registers > in child nodes. Each register controls one SoC device. > > The respective apple compatibles are defined in case device-specific > quirks are necessary in the future, but currently these nodes are > expected to be bound by the generic syscon driver. > > Reviewed-by: Mark Kettenis > Signed-off-by: Hector Martin > --- > .../bindings/arm/apple/apple,pmgr.yaml | 149 ++++++++++++++++++ > 1 file changed, 149 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml > > diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml > new file mode 100644 > index 000000000000..e8b7776163fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml > @@ -0,0 +1,149 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/apple/apple,pmgr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple SoC Power Manager (PMGR) > + > +maintainers: > + - Hector Martin > + > +description: | > + Apple SoCs include a PMGR block responsible for power management, > + which can control various clocks, resets, power states, and > + performance features. This node represents the PMGR as a syscon, > + with sub-nodes representing individual features. > + > + Apple SoCs may have a secondary "mini-PMGR"; it is represented > + separately in the device tree, but works the same way. > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - apple,t8103-pmgr > + - apple,t8103-minipmgr > + - apple,pmgr You shouldn't need this. The default select will filter out syscon and simple-mfd. > + > + required: > + - compatible > + > +properties: > + $nodename: > + pattern: "^power-management@[0-9a-f]+$" > + > + compatible: > + items: > + - enum: > + - apple,t8103-pmgr > + - apple,t8103-minipmgr > + - const: apple,pmgr > + - const: syscon > + - const: simple-mfd 'simple-mfd' means 'there's nothing in this node that any of the child nodes depend on'. You should be somewhat certain as dropping it later creates compatibility issues. > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +patternProperties: > + "power-controller@[0-9a-f]+$": > + description: | Don't need '|' if no formatting to preserve. > + The individual power management domains within this controller > + type: object > + $ref: /power/apple,pmgr-pwrstate.yaml# > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + power-management@23b700000 { > + compatible = "apple,t8103-pmgr", "apple,pmgr", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x2 0x3b700000 0x0 0x14000>; > + > + ps_sio: power-controller@1c0 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x1c0 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "sio"; > + apple,always-on; > + }; > + > + ps_uart_p: power-controller@220 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x220 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "uart_p"; > + power-domains = <&ps_sio>; > + }; > + > + ps_uart0: power-controller@270 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x270 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "uart0"; > + power-domains = <&ps_uart_p>; > + }; > + }; > + > + power-management@23d280000 { > + compatible = "apple,t8103-minipmgr", "apple,pmgr", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x2 0x3d280000 0x0 0xc000>; > + > + ps_aop_filter: power-controller@4000 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x4000 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "aop_filter"; > + }; > + > + ps_aop_base: power-controller@4010 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x4010 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "aop_base"; > + power-domains = <&ps_aop_filter>; > + }; > + > + ps_aop_shim: power-controller@4038 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x4038 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "aop_shim"; > + power-domains = <&ps_aop_base>; > + }; > + > + ps_aop_uart0: power-controller@4048 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x4048 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "aop_uart0"; > + power-domains = <&ps_aop_shim>; > + }; > + }; > + }; > -- > 2.33.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41BABC433EF for ; Tue, 26 Oct 2021 18:27:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DD6360296 for ; Tue, 26 Oct 2021 18:27:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0DD6360296 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2VtUb9kspyWWw2c4jDYuQOvJ9nxHvW8LWf38MGbAq2Y=; b=JCkYgOUw5uZ8hG NbaE9w8dpeDF8O3au8PH0Sxww7YsRUAiWtvRt3Q7PDAFFvV6pwVoOOcV9P4JZ+0kt1BCM3JUvIsKC svhVtEEqciyO3TKjH6TF/fUuyYHWs7o3DCg8sMD8M42uhkncZArUQPGeweqsL2cDFXaN+lKVDzLWI nUfx1Z1u9L4j4bfYUaJRurO3EQIAxAsBxad/LWzTiBn6Nwp/jVGlLCmL9dUTCDxXnTNGcB+bf/3r7 7Eis4BzpPZKIiRDTI3cp4lsLTXUC4/enLlhELTyJQNpn1bc+IjYyo/aHxkhyliWItbzqGN7YZZQ6F wAjMs12KR6jXGcsKbcDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfR9A-002kjo-3Y; Tue, 26 Oct 2021 18:26:04 +0000 Received: from mail-oo1-f49.google.com ([209.85.161.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfR95-002kj0-O9 for linux-arm-kernel@lists.infradead.org; Tue, 26 Oct 2021 18:26:01 +0000 Received: by mail-oo1-f49.google.com with SMTP id d144-20020a4a5296000000b002b6cf3f9aceso18876oob.13 for ; Tue, 26 Oct 2021 11:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WSZr1Cmv5ob/1Jiww/LXg4dCpeepOagUPfg8Il8gYuM=; b=5FvtvCkmcylD0BDBBy8CnIssjP2J92ip2mKJ5SCrr6mYWijkoBSOZnUFxpkX+bRIFU 4iDKguN/a7fHRRkEnmiiN8akQrCyA5wUwbhRVsUM5RxLf4dbWm2UkHL4FJp0BP/keEpG lJf8APdoQ0d1VTrVjWuZTO+S76QhQB0zJ9SiMWBCtxF9xWyaG3JtQ0e+yz0fmOQUkz96 XqpUKPQERtq/wD2yiRYeB6CCcRzJi2CVpogMUK4mcKdOl9WDWPbKq7gjNPjvNFrL53dT mimY0916M+zaLOcga/6sWC3nngT+X/pySgaQ9d3m9HpXikkHWS9Fo9gWZ4fwYq5dmTif 4aXw== X-Gm-Message-State: AOAM532ulzETwTs4iuSWIGLL3Wub3vKFTc6yQPmbTpzswXnMWEFeL4F4 1X57yB0L5CX1H/hAGo03ZA== X-Google-Smtp-Source: ABdhPJyNyn/Hk6PjVvlo5IisYehjIBhdvSvZfsFty86k1Vn1vTJ5hS3CpO+0wtZQ56jT9ipU94EjHQ== X-Received: by 2002:a4a:d1c8:: with SMTP id a8mr2579386oos.12.1635272758233; Tue, 26 Oct 2021 11:25:58 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id x12sm4045585oot.6.2021.10.26.11.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 11:25:57 -0700 (PDT) Received: (nullmailer pid 2976480 invoked by uid 1000); Tue, 26 Oct 2021 18:25:56 -0000 Date: Tue, 26 Oct 2021 13:25:56 -0500 From: Rob Herring To: Hector Martin Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , Krzysztof Kozlowski , Greg Kroah-Hartman , Mark Kettenis , Philipp Zabel , "Rafael J. Wysocki" , Johan Hovold , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, Mark Kettenis Subject: Re: [PATCH v2 2/8] dt-bindings: arm: apple: Add apple,pmgr binding Message-ID: References: <20211025144718.157794-1-marcan@marcan.st> <20211025144718.157794-3-marcan@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211025144718.157794-3-marcan@marcan.st> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211026_112559_825200_CB1A53B4 X-CRM114-Status: GOOD ( 25.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 25, 2021 at 11:47:12PM +0900, Hector Martin wrote: > The PMGR block in Apple Silicon SoCs is responsible for SoC power > management. There are two PMGRs in T8103, with different register > layouts but compatible registers. In order to support this as well > as future SoC generations with backwards-compatible registers, we > declare these blocks as syscons and bind to individual registers > in child nodes. Each register controls one SoC device. > > The respective apple compatibles are defined in case device-specific > quirks are necessary in the future, but currently these nodes are > expected to be bound by the generic syscon driver. > > Reviewed-by: Mark Kettenis > Signed-off-by: Hector Martin > --- > .../bindings/arm/apple/apple,pmgr.yaml | 149 ++++++++++++++++++ > 1 file changed, 149 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml > > diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml > new file mode 100644 > index 000000000000..e8b7776163fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml > @@ -0,0 +1,149 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/apple/apple,pmgr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple SoC Power Manager (PMGR) > + > +maintainers: > + - Hector Martin > + > +description: | > + Apple SoCs include a PMGR block responsible for power management, > + which can control various clocks, resets, power states, and > + performance features. This node represents the PMGR as a syscon, > + with sub-nodes representing individual features. > + > + Apple SoCs may have a secondary "mini-PMGR"; it is represented > + separately in the device tree, but works the same way. > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - apple,t8103-pmgr > + - apple,t8103-minipmgr > + - apple,pmgr You shouldn't need this. The default select will filter out syscon and simple-mfd. > + > + required: > + - compatible > + > +properties: > + $nodename: > + pattern: "^power-management@[0-9a-f]+$" > + > + compatible: > + items: > + - enum: > + - apple,t8103-pmgr > + - apple,t8103-minipmgr > + - const: apple,pmgr > + - const: syscon > + - const: simple-mfd 'simple-mfd' means 'there's nothing in this node that any of the child nodes depend on'. You should be somewhat certain as dropping it later creates compatibility issues. > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +patternProperties: > + "power-controller@[0-9a-f]+$": > + description: | Don't need '|' if no formatting to preserve. > + The individual power management domains within this controller > + type: object > + $ref: /power/apple,pmgr-pwrstate.yaml# > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + power-management@23b700000 { > + compatible = "apple,t8103-pmgr", "apple,pmgr", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x2 0x3b700000 0x0 0x14000>; > + > + ps_sio: power-controller@1c0 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x1c0 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "sio"; > + apple,always-on; > + }; > + > + ps_uart_p: power-controller@220 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x220 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "uart_p"; > + power-domains = <&ps_sio>; > + }; > + > + ps_uart0: power-controller@270 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x270 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "uart0"; > + power-domains = <&ps_uart_p>; > + }; > + }; > + > + power-management@23d280000 { > + compatible = "apple,t8103-minipmgr", "apple,pmgr", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x2 0x3d280000 0x0 0xc000>; > + > + ps_aop_filter: power-controller@4000 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x4000 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "aop_filter"; > + }; > + > + ps_aop_base: power-controller@4010 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x4010 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "aop_base"; > + power-domains = <&ps_aop_filter>; > + }; > + > + ps_aop_shim: power-controller@4038 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x4038 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "aop_shim"; > + power-domains = <&ps_aop_base>; > + }; > + > + ps_aop_uart0: power-controller@4048 { > + compatible = "apple,t8103-pmgr-pwrstate", "apple,pmgr-pwrstate"; > + reg = <0x4048 8>; > + #power-domain-cells = <0>; > + #reset-cells = <0>; > + label = "aop_uart0"; > + power-domains = <&ps_aop_shim>; > + }; > + }; > + }; > -- > 2.33.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel