Re: [PATCH v2] drm: panel-orientation-quirks: Add quirk for GPD Win3

[Sam Ravnborg <sam@ravnborg.org>]

Hi Mario,

On Tue, Oct 26, 2021 at 01:27:37PM +0200, Mario wrote:
> Fixes screen orientation for GPD Win 3 handheld gaming console.
> 
> Signed-off-by: Mario Risoldi <awxkrnl@gmail.com>

Thanks for the resend.
A couple of points for your, hopefully soonish, next contribution:

1) Use the same name/email in the Signed-off-by and a sender mail.
As an alternative add an From: Mario Risoldi <awxkrnl@gmail.com> in the
top of the changelog. Otherwise there is a warning about the mismatch.

2) When you make a v2 it is always a good service to the readers to tell
what was changed.
In this case you could have added the following:
"
v2:
  - Added changelog and s-o-b (Sam)
"

It is perfectly fine in the DRM subsystem to have this part of the
changelog. Other subsystmes do not want to see it in the changelog so
there it must go below the end-of-changelog marker - the "---"

Patch is applied to drm-misc-next and will hopefully find its way to
upstream within 1-2 weeks.
So for this patch you do not need to do more.

	Sam

> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index f6bdec7fa925..f6177c1d9872 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -185,6 +185,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
>  		},
>  		.driver_data = (void *)&gpd_win2,
> +	}, {	/* GPD Win 3 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "GPD"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G1618-03")
> +		},
> +		.driver_data = (void *)&lcd720x1280_rightside_up,
>  	}, {	/* I.T.Works TW891 */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
> -- 
> 2.33.1