From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1 0/2] ACPI: scan: Honor certain device identification rules
Date: Tue, 26 Oct 2021 22:33:17 +0300 [thread overview]
Message-ID: <YXhX/cTjH/H9UOnQ@smile.fi.intel.com> (raw)
In-Reply-To: <11860508.O9o76ZdvQC@kreacher>
On Tue, Oct 26, 2021 at 08:51:49PM +0200, Rafael J. Wysocki wrote:
> Hi All,
>
> There are some rules in the ACPI spec regarding which device identification
> objects can be used together etc., but they are not followed by the kernel
> code.
>
> This series modifies the code to follow the spec more closely (see patch
> changelogs for details).
I understand the motivation, but afraid about consequences on the OEM cheap
devices that are not always follow letter of the specification.
As per Intel platforms I would look into Baytrail / Cherrytrail devices for
the past (I think Hans may help here a lot) and into Elkhart Lake in the
present (for the letter I mostly refer to CSRT + DSDT cooperation to get
GP DMA devices enumerated, so I _hope_ DSDT shouldn't have _ADR and _HID
together).
Hence, from the code perspective
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
From the practice I would wait for some tests. I will try to find any new
information about latest firmware tables on Elkhart Lake machines.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-10-26 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 18:51 [PATCH v1 0/2] ACPI: scan: Honor certain device identification rules Rafael J. Wysocki
2021-10-26 18:57 ` [PATCH v1 1/2] ACPI: scan: Do not add device IDs from _CID if _HID is not valid Rafael J. Wysocki
2021-10-26 19:00 ` [PATCH v1 2/2] ACPI: scan: Do not set type.bus_address if _HID is valid Rafael J. Wysocki
2021-10-26 19:33 ` Andy Shevchenko [this message]
2021-10-27 17:34 ` [PATCH v1 0/2] ACPI: scan: Honor certain device identification rules Andy Shevchenko
2021-10-27 17:50 ` Andy Shevchenko
2021-10-27 18:18 ` Rafael J. Wysocki
2021-10-27 18:12 ` Rafael J. Wysocki
2021-10-27 19:28 ` Andy Shevchenko
2021-10-27 14:27 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXhX/cTjH/H9UOnQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.