All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: stable@vger.kernel.org, axboe@kernel.dk, asml.silence@gmail.com,
	io-uring@vger.kernel.org,
	syzbot+59d8a1f4e60c20c066cf@syzkaller.appspotmail.com
Subject: Re: [PATCH 5.10 1/1] io_uring: fix double free in the deferred/cancelled path
Date: Wed, 27 Oct 2021 14:46:35 +0200	[thread overview]
Message-ID: <YXlKKxRETze45IPv@kroah.com> (raw)
In-Reply-To: <YXkVxVFg8e5Z33zV@google.com>

On Wed, Oct 27, 2021 at 10:03:01AM +0100, Lee Jones wrote:
> On Wed, 27 Oct 2021, Greg KH wrote:
> 
> > On Wed, Oct 27, 2021 at 09:37:59AM +0100, Lee Jones wrote:
> > > On Wed, 27 Oct 2021, Greg KH wrote:
> > > 
> > > > On Wed, Oct 27, 2021 at 09:01:28AM +0100, Lee Jones wrote:
> > > > > 792bb6eb86233 ("io_uring: don't take uring_lock during iowq cancel")
> > > > > inadvertently fixed this issue in v5.12.  This patch cherry-picks the
> > > > > hunk of commit which does so.
> > > > 
> > > > Why can't we take all of that commit?  Why only part of it?
> > > 
> > > I don't know.
> > > 
> > > Why didn't the Stable team take it further than v5.11.y?
> > 
> > Look in the archives?  Did it not apply cleanly?
> > 
> > /me goes off and looks...
> > 
> > Looks like I asked for a backport, but no one did it, I only received a
> > 5.11 version:
> > 	https://lore.kernel.org/r/1839646480a26a2461eccc38a75e98998d2d6e11.1615375332.git.asml.silence@gmail.com
> > 
> > so a 5.10 version would be nice, as I said it failed as-is:
> > 	https://lore.kernel.org/all/161460075611654@kroah.com/
> 
> Precisely.  This is the answer to your question:
> 
>   > > > Why can't we take all of that commit?  Why only part of it?
> 
> Same reason the Stable team didn't back-port it - it doesn't apply.
> 
> The second hunk is only relevant to v5.11+.

Great, then use the "normal" stable style, but down in the s-o-b area
say "dropped second chunk as it is not relevant to 5.10.y".

thanks,

greg k-h

  reply	other threads:[~2021-10-27 12:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27  8:01 [PATCH 5.10 1/1] io_uring: fix double free in the deferred/cancelled path Lee Jones
2021-10-27  8:18 ` Greg KH
2021-10-27  8:37   ` Lee Jones
2021-10-27  8:53     ` Greg KH
2021-10-27  9:03       ` Lee Jones
2021-10-27 12:46         ` Greg KH [this message]
2021-10-27 14:00           ` Lee Jones
2021-10-27 14:38             ` Greg KH
2021-10-27 14:42               ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXlKKxRETze45IPv@kroah.com \
    --to=greg@kroah.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+59d8a1f4e60c20c066cf@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.