diff for duplicates of <YXlrEWmBohaDXmqL@google.com> diff --git a/a/1.txt b/N1/1.txt index 1a444fb..4f5b7fc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Mon, Oct 25, 2021, Paolo Bonzini wrote: > On 09/10/21 04:12, Sean Christopherson wrote: > > + */ -> > + if (vcpu->mode == IN_GUEST_MODE) { +> > + if (vcpu->mode = IN_GUEST_MODE) { > > int cpu = READ_ONCE(vcpu->cpu); > > /* > > @@ -687,8 +692,13 @@ int svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec) @@ -18,7 +18,7 @@ On Mon, Oct 25, 2021, Paolo Bonzini wrote: > > + } > > Does this still need to check the "running" flag? That should be a strict -> superset of vcpu->mode == IN_GUEST_MODE. +> superset of vcpu->mode = IN_GUEST_MODE. No. Signalling the doorbell when "running" is set but the vCPU is not in the guest is just an expensive nop. So even if KVM were to rework its handling of diff --git a/a/content_digest b/N1/content_digest index a1ba502..40e24d8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,15 +2,47 @@ "ref\020211009021236.4122790-36-seanjc@google.com\0" "ref\00333be2a-76d8-657a-6c82-3bb5c9ff2e3b@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" + "Subject\0Re: [PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" "Date\0Wed, 27 Oct 2021 15:06:57 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Marc Zyngier <maz@kernel.org>" + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + James Morse <james.morse@arm.com> + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + David Matlack <dmatlack@google.com> + Oliver Upton <oupton@google.com> + " Jing Zhang <jingzhangos@google.com>\0" "\00:1\0" "b\0" "On Mon, Oct 25, 2021, Paolo Bonzini wrote:\n" "> On 09/10/21 04:12, Sean Christopherson wrote:\n" "> > +\t */\n" - "> > +\tif (vcpu->mode == IN_GUEST_MODE) {\n" + "> > +\tif (vcpu->mode = IN_GUEST_MODE) {\n" "> > \t\tint cpu = READ_ONCE(vcpu->cpu);\n" "> > \t\t/*\n" "> > @@ -687,8 +692,13 @@ int svm_deliver_avic_intr(struct kvm_vcpu *vcpu, int vec)\n" @@ -27,7 +59,7 @@ "> > +\t}\n" "> \n" "> Does this still need to check the \"running\" flag? That should be a strict\n" - "> superset of vcpu->mode == IN_GUEST_MODE.\n" + "> superset of vcpu->mode = IN_GUEST_MODE.\n" "\n" "No. Signalling the doorbell when \"running\" is set but the vCPU is not in the\n" "guest is just an expensive nop. So even if KVM were to rework its handling of\n" @@ -45,4 +77,4 @@ "from hardware's delivery of interrupts. I.e. use the same core rules as\n" kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC. -4195a7489baa65e4707d711cea070ecd374e4c84f1a715c1565085bcfa286d30 +1de22ab100cc509c98f16df1a8dd25cef4b489b8b895e85e7bf8caeabbb673a9
diff --git a/a/1.txt b/N2/1.txt index 1a444fb..354a915 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -35,3 +35,7 @@ to essentially revert this commit since vcpu->mode would then be redundant. And IMO, it makes sense to intentionally separate KVM's delivery of interrupts from hardware's delivery of interrupts. I.e. use the same core rules as kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC. +_______________________________________________ +kvmarm mailing list +kvmarm@lists.cs.columbia.edu +https://lists.cs.columbia.edu/mailman/listinfo/kvmarm diff --git a/a/content_digest b/N2/content_digest index a1ba502..1ef5239 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,9 +2,36 @@ "ref\020211009021236.4122790-36-seanjc@google.com\0" "ref\00333be2a-76d8-657a-6c82-3bb5c9ff2e3b@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" + "Subject\0Re: [PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" "Date\0Wed, 27 Oct 2021 15:06:57 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Cornelia Huck <cohuck@redhat.com>" + Wanpeng Li <wanpengli@tencent.com> + kvm@vger.kernel.org + David Hildenbrand <david@redhat.com> + linux-kernel@vger.kernel.org + Paul Mackerras <paulus@ozlabs.org> + Atish Patra <atish.patra@wdc.com> + linux-riscv@lists.infradead.org + Claudio Imbrenda <imbrenda@linux.ibm.com> + kvmarm@lists.cs.columbia.edu + Janosch Frank <frankja@linux.ibm.com> + Marc Zyngier <maz@kernel.org> + Joerg Roedel <joro@8bytes.org> + Huacai Chen <chenhuacai@kernel.org> + Christian Borntraeger <borntraeger@de.ibm.com> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Albert Ou <aou@eecs.berkeley.edu> + kvm-ppc@vger.kernel.org + Paul Walmsley <paul.walmsley@sifive.com> + David Matlack <dmatlack@google.com> + linux-arm-kernel@lists.infradead.org + Jim Mattson <jmattson@google.com> + Anup Patel <anup.patel@wdc.com> + linux-mips@vger.kernel.org + Palmer Dabbelt <palmer@dabbelt.com> + kvm-riscv@lists.infradead.org + " Vitaly Kuznetsov <vkuznets@redhat.com>\0" "\00:1\0" "b\0" "On Mon, Oct 25, 2021, Paolo Bonzini wrote:\n" @@ -43,6 +70,10 @@ "\n" "And IMO, it makes sense to intentionally separate KVM's delivery of interrupts\n" "from hardware's delivery of interrupts. I.e. use the same core rules as\n" - kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC. + "kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC.\n" + "_______________________________________________\n" + "kvmarm mailing list\n" + "kvmarm@lists.cs.columbia.edu\n" + https://lists.cs.columbia.edu/mailman/listinfo/kvmarm -4195a7489baa65e4707d711cea070ecd374e4c84f1a715c1565085bcfa286d30 +7e6c80f08b4e82b98ea02c2ab7a84f60080673f680f7e8cd676694e305aa264e
diff --git a/a/content_digest b/N3/content_digest index a1ba502..68c52ff 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,9 +2,41 @@ "ref\020211009021236.4122790-36-seanjc@google.com\0" "ref\00333be2a-76d8-657a-6c82-3bb5c9ff2e3b@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" + "Subject\0Re: [PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" "Date\0Wed, 27 Oct 2021 15:06:57 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Marc Zyngier <maz@kernel.org>" + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + James Morse <james.morse@arm.com> + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + David Matlack <dmatlack@google.com> + Oliver Upton <oupton@google.com> + " Jing Zhang <jingzhangos@google.com>\0" "\00:1\0" "b\0" "On Mon, Oct 25, 2021, Paolo Bonzini wrote:\n" @@ -45,4 +77,4 @@ "from hardware's delivery of interrupts. I.e. use the same core rules as\n" kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC. -4195a7489baa65e4707d711cea070ecd374e4c84f1a715c1565085bcfa286d30 +42528aae7bc64b4d5c621de4568ea117b3b0f11610591e739844ee17efc45fb4
diff --git a/a/1.txt b/N4/1.txt index 1a444fb..b4a0b2b 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -35,3 +35,8 @@ to essentially revert this commit since vcpu->mode would then be redundant. And IMO, it makes sense to intentionally separate KVM's delivery of interrupts from hardware's delivery of interrupts. I.e. use the same core rules as kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC. + +_______________________________________________ +linux-riscv mailing list +linux-riscv@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-riscv diff --git a/a/content_digest b/N4/content_digest index a1ba502..fc89f7b 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -2,9 +2,41 @@ "ref\020211009021236.4122790-36-seanjc@google.com\0" "ref\00333be2a-76d8-657a-6c82-3bb5c9ff2e3b@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" + "Subject\0Re: [PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" "Date\0Wed, 27 Oct 2021 15:06:57 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Marc Zyngier <maz@kernel.org>" + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + James Morse <james.morse@arm.com> + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + David Matlack <dmatlack@google.com> + Oliver Upton <oupton@google.com> + " Jing Zhang <jingzhangos@google.com>\0" "\00:1\0" "b\0" "On Mon, Oct 25, 2021, Paolo Bonzini wrote:\n" @@ -43,6 +75,11 @@ "\n" "And IMO, it makes sense to intentionally separate KVM's delivery of interrupts\n" "from hardware's delivery of interrupts. I.e. use the same core rules as\n" - kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC. + "kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC.\n" + "\n" + "_______________________________________________\n" + "linux-riscv mailing list\n" + "linux-riscv@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-riscv -4195a7489baa65e4707d711cea070ecd374e4c84f1a715c1565085bcfa286d30 +d644a92942d0a1a3e8f4bb29eaad5f3ba1d85ff52e1258fbb000bd19246fb4b8
diff --git a/a/1.txt b/N5/1.txt index 1a444fb..32666af 100644 --- a/a/1.txt +++ b/N5/1.txt @@ -35,3 +35,8 @@ to essentially revert this commit since vcpu->mode would then be redundant. And IMO, it makes sense to intentionally separate KVM's delivery of interrupts from hardware's delivery of interrupts. I.e. use the same core rules as kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC. + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N5/content_digest index a1ba502..6989d87 100644 --- a/a/content_digest +++ b/N5/content_digest @@ -2,9 +2,41 @@ "ref\020211009021236.4122790-36-seanjc@google.com\0" "ref\00333be2a-76d8-657a-6c82-3bb5c9ff2e3b@redhat.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" + "Subject\0Re: [PATCH v2 35/43] KVM: SVM: Signal AVIC doorbell iff vCPU is in guest mode\0" "Date\0Wed, 27 Oct 2021 15:06:57 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Paolo Bonzini <pbonzini@redhat.com>\0" + "Cc\0Marc Zyngier <maz@kernel.org>" + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + James Morse <james.morse@arm.com> + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + David Matlack <dmatlack@google.com> + Oliver Upton <oupton@google.com> + " Jing Zhang <jingzhangos@google.com>\0" "\00:1\0" "b\0" "On Mon, Oct 25, 2021, Paolo Bonzini wrote:\n" @@ -43,6 +75,11 @@ "\n" "And IMO, it makes sense to intentionally separate KVM's delivery of interrupts\n" "from hardware's delivery of interrupts. I.e. use the same core rules as\n" - kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC. + "kvm_vcpu_kick() for when to send interrupts and when to wake for the AVIC.\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -4195a7489baa65e4707d711cea070ecd374e4c84f1a715c1565085bcfa286d30 +6e5dd1f303f59c0449461a09f7d6d774a084d29990ce2ba8994f860d784140ba
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.