From: Patrick Williams <patrick@stwcx.xyz>
To: Adriana Kobylak <anoo@linux.ibm.com>
Cc: edtanous@google.com, 郁雷 <yulei.sh@bytedance.com>,
"OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
"William Kennington" <wak@google.com>
Subject: Re: [External] Changing the os-release BUILD_ID back to its default value of DATETIME
Date: Wed, 27 Oct 2021 16:50:40 -0500 [thread overview]
Message-ID: <YXnJsAbwy6AseLct@heinlein> (raw)
In-Reply-To: <80FD1EF5-EA89-4FE1-8075-B07E9122FF8E@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1558 bytes --]
On Mon, Oct 25, 2021 at 03:17:06PM -0500, Adriana Kobylak wrote:
> Thanks everybody. Changes up for review:
>
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/48204 <https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/48204>
> https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/48205 <https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/48205>
>
>
> > On Oct 12, 2021, at 4:45 AM, William Kennington <wak@google.com> wrote:
> >
> > Personally I would rather have deterministic builds and don't like
> > arbitrary build timestamp injection into images. But we can announce
> > the plan to change this behavior and adjust build processes
> > accordingly.
>
> Sounds like a plan. To keep the current behavior, I tested that adding a os-release.bbappend with BUILD_ID set to the current git command would build the image with the value as it is today.
I don't actually have very strong opinions on this and didn't realize right away
that this meant we _weren't_ making a change. I avoided weighing in before to
just be another "+1".
Shouldn't we attempt to match what upstream Yocto does? Doesn't doing (mostly)
nothing cause us to not fix the usability issue that keeps getting raised about
the code-update flow not accepting a simple rebuild?
I don't believe that you can currently make a 100% reproducible build as it is,
so I don't see this as a hard requirement to deviate from Yocto and if someone
does want to avoid a changing BUILD_ID we already give them the tools for it.
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-10-27 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 21:59 Changing the os-release BUILD_ID back to its default value of DATETIME Adriana Kobylak
2021-10-11 23:54 ` Ed Tanous
2021-10-12 5:33 ` [External] " Lei Yu
2021-10-12 9:45 ` William Kennington
2021-10-25 20:17 ` Adriana Kobylak
2021-10-27 21:50 ` Patrick Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXnJsAbwy6AseLct@heinlein \
--to=patrick@stwcx.xyz \
--cc=anoo@linux.ibm.com \
--cc=edtanous@google.com \
--cc=openbmc@lists.ozlabs.org \
--cc=wak@google.com \
--cc=yulei.sh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.