From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"irogers@google.com" <irogers@google.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kjain@linux.ibm.com" <kjain@linux.ibm.com>,
"james.clark@arm.com" <james.clark@arm.com>
Subject: Re: [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS
Date: Thu, 28 Oct 2021 08:17:38 -0300 [thread overview]
Message-ID: <YXqG0jb4qg4+x5DE@kernel.org> (raw)
In-Reply-To: <32d98804-7e56-e73b-4c66-8776dbf58ddf@huawei.com>
Em Thu, Oct 28, 2021 at 09:23:58AM +0100, John Garry escreveu:
> On 25/10/2021 17:20, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Oct 25, 2021 at 01:40:44PM +0200, Jiri Olsa escreveu:
> > > On Fri, Oct 22, 2021 at 10:42:11AM +0100, John Garry wrote:
> > > > On 21/10/2021 13:48, Jiri Olsa wrote:
> > > > ok, so IIRC, then the rule for building .o from .c in
> > > > tools/build/Makefile.build will pick up HOSTCFLAGS through this variable, so
> > > > we then don't need to explicitly mention it in the per-target rule, so can
> > > > have this as before in pmu-events/Build
> > > > HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include
> > > > right?
> > > > (Indeed I guess that we can get rid of -I$(srctree)/tools/include as well)
> > > hm, the -I.. should stay no? I don't see that
> > > it's being added soem other way
> > Probably this change from KBUILD_HOSTCFLAGS back to HOSTCFLAGS should
> > come with this;
> > Cc: Laura Abbott <labbott@redhat.com>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Fixes: 96f14fe738b69dd9 ("kbuild: Rename HOSTCFLAGS to KBUILD_HOSTCFLAGS")
> > Right?
> Maybe, but then renaming back from KBUILD_HOSTCFLAGS -> HOSTCFLAGS seems odd
> as a fix
> Anyway, now that this original series is in perf/core,
Nope, just this one landed:
commit 342cb7ebf5e29fff4dc09ab2c8f37d710f8f5206
Author: John Garry <john.garry@huawei.com>
Date: Thu Oct 21 17:16:44 2021 +0800
perf jevents: Fix some would-be warnings
---
The one you asked to wait for further discussion wasn't merged.
- Arnaldo
> I'll send patches on top with this change, cc'ing Laura and Masahiro
next prev parent reply other threads:[~2021-10-28 11:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 9:16 [PATCH v2 0/2] perf jevents: Enable build warnings John Garry
2021-10-21 9:16 ` [PATCH v2 1/2] perf jevents: Fix some would-be warnings John Garry
2021-10-21 9:16 ` [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS John Garry
2021-10-21 12:48 ` Jiri Olsa
2021-10-21 15:50 ` John Garry
2021-10-21 15:58 ` Jiri Olsa
2021-10-22 9:42 ` John Garry
2021-10-25 11:40 ` Jiri Olsa
2021-10-25 16:20 ` Arnaldo Carvalho de Melo
2021-10-28 8:23 ` John Garry
2021-10-28 11:17 ` Arnaldo Carvalho de Melo [this message]
2021-10-28 11:40 ` John Garry
2021-10-21 12:55 ` [PATCH v2 0/2] perf jevents: Enable build warnings Arnaldo Carvalho de Melo
2021-10-21 13:02 ` John Garry
2021-10-21 14:36 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXqG0jb4qg4+x5DE@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.