From: Greg KH <gregkh@linuxfoundation.org>
To: Senthu Sivarajah <ssivaraj@stud.fra-uas.de>
Cc: vaibhav.sr@gmail.com, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: greybus: audio_codec: changed a void function to return 0
Date: Thu, 28 Oct 2021 18:42:31 +0200 [thread overview]
Message-ID: <YXrS9xwJf5AcBoFJ@kroah.com> (raw)
In-Reply-To: <20211028153808.9509-1-ssivaraj@stud.fra-uas.de>
On Thu, Oct 28, 2021 at 05:38:08PM +0200, Senthu Sivarajah wrote:
> From: Senthuran Sivarajah <ssivaraj@stud.fra-uas.de>
>
> Fixed a coding style issue.
What coding style exactly?
>
> Signed-off-by: Senthuran Sivarajah <ssivaraj@stud.fra-uas.de>
>
> ---
> drivers/staging/greybus/audio_codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index b589cf6b1d03..9f99862791dc 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -1028,7 +1028,7 @@ static int gbcodec_probe(struct snd_soc_component *comp)
> static void gbcodec_remove(struct snd_soc_component *comp)
> {
> /* Empty function for now */
> - return;
> + return 0;
Did you build this change?
Exactly what tool reported a problem with this code and what was the
exact error?
thanks,
greg k-h
next prev parent reply other threads:[~2021-10-28 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 15:38 [PATCH] Staging: greybus: audio_codec: changed a void function to return 0 Senthu Sivarajah
2021-10-28 16:35 ` Bryan Brattlof
2021-10-28 16:42 ` Greg KH [this message]
2021-10-28 17:19 ` Senthuran Sivarajah
2021-10-29 2:09 ` kernel test robot
2021-10-29 2:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXrS9xwJf5AcBoFJ@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ssivaraj@stud.fra-uas.de \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.