From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B2D9C433F5 for ; Fri, 29 Oct 2021 00:31:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA543610E5 for ; Fri, 29 Oct 2021 00:31:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA543610E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1388C16DF; Fri, 29 Oct 2021 02:30:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1388C16DF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1635467497; bh=RmGXNHIxFeDc/Fix7juI94Pwkmt3/qz8YBMA9g+p1lw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EELSvYKf3V0YQ3X42K9+0oSrV7Pzvn3lHpJEUO3Z+fNlCXDV+EFlIeF3Nn2Bl+oZc kIzV/nDb2BAKCJ8t1/Ib+jerJfKPrOCwOK2WlFvNigwNUdBbNOiGd0zIOMKXmlg6D4 fFiUNVN5E9oJs9kLzgMI42FzkYme03zw0canvmBM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 87B46F80269; Fri, 29 Oct 2021 02:30:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5BBCBF802C8; Fri, 29 Oct 2021 02:30:44 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 01EDEF8010A for ; Fri, 29 Oct 2021 02:30:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 01EDEF8010A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="Al4nhVAN"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jhbYMLvd" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C32B53201DBC; Thu, 28 Oct 2021 20:30:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Oct 2021 20:30:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=TKHZZAOF7t59TffLKpgYy+AFEiy J0SsifX+r1p8Jh0U=; b=Al4nhVANlDD0qlKmWqSWMECdLCgjVfMfYRL/FDM+ACD o+JIOLfMunrHgS9XOmWkdbiEnsNWETuymigZ7wuMIUdc0Utg1f2f4byc8CfuDrvO kKAq38GbXXVnhKNVHcIpWsvmMFPvg6CffCCRXbKuxfme5+FmzJFIyZRwofhaG5SF fTQUR2gUaWIjZapUl3Cc1K27bXNK/bgVE7gZYMjBH/ru97/W8KGnBjmB8Kb9WNum vV3hM9tEpbCMS/aqcT84qFfDA6AKqnyjojftGqQIfMxpqebTUJWI7QBZw8kdKfwZ us0VhoHK/Mtq0zOvDg0qLueJjNyS3uMgS+gFR9sZF8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=TKHZZA OF7t59TffLKpgYy+AFEiyJ0SsifX+r1p8Jh0U=; b=jhbYMLvd4x1zDz5iSUphlY Im+6G+Ruhqj//cjvLDaapbJXYVbpuSAMBy7hknBFyHGDRxelBNmtLLnR92Z1EXHH QoWo8wXR8o6yJogxOFxVlFkS/UQh4dVD/pusxFK5upqQFPls546HWjFCsSGnsUpz yRYKefx0z9V2pSvE3aLRAkq3VilnQWDHJ8Fp9YMm3diHQSF40Rki3il1UlADvzyb yKgaY/qV46OO+RX4MVMPzzgaJ+QOiqsa/ZQgF13ZNtFd7+DcKRBOZlaw6fCvGfUc vuMmM/7e7mRkt9l5Tt/00azzskhXAkVJiCgxNMmQ13PShGdsUnpH0y6U5nQT1MOg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdeggedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefvrghkrghs hhhiucfurghkrghmohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjh hpqeenucggtffrrghtthgvrhhnpeelfeelieekieeivedtffefieehfefhudefieeifffh tefffeehfedvveduudfgtdenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhh ihesshgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Oct 2021 20:30:26 -0400 (EDT) Date: Fri, 29 Oct 2021 09:30:22 +0900 From: Takashi Sakamoto To: Takashi Iwai Subject: Re: [PATCH] ALSA: oxfw: fix functional regression for Mackie Onyx 1640i in v5.14 or later Message-ID: Mail-Followup-To: Takashi Iwai , clemens@ladisch.de, alsa-devel@alsa-project.org References: <20211028130325.45772-1-o-takashi@sakamocchi.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, clemens@ladisch.de X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Oct 28, 2021 at 05:44:37PM +0200, Takashi Iwai wrote: > On Thu, 28 Oct 2021 15:03:25 +0200, > Takashi Sakamoto wrote: > > > > A user reports functional regression for Mackie Onyx 1640i that the device > > generates slow sound with ALSA oxfw driver which supports media clock > > recovery. Although the device is based on OXFW971 ASIC, it does not > > transfer isochronous packet with own event frequency as expected. The > > device seems to adjust event frequency according to events in received > > isochronous packets in the beginning of packet streaming. This is > > unknown quirk. > > > > This commit fixes the regression to turn the recovery off in driver > > side. As a result, nominal frequency is used in duplex packet streaming > > between device and driver. For stability of sampling rate in events of > > transferred isochronous packet, 4,000 isochronous packets are skipped > > in the beginning of packet streaming. > > > > Reference: https://github.com/takaswie/snd-firewire-improve/issues/38 > > Fixes: 029ffc429440 ("ALSA: oxfw: perform sequence replay for media clock recovery") > > Signed-off-by: Takashi Sakamoto > > Thanks, applied. > > > Takashi Oops. I forget to add tag to stable. It's preferable to apply the patch to current stable (5.14.15) and mainline RC (5.15-rc7) as well... Would I request you to post the patch for the purpose alternatively? (It is perhaps too late for mainline, I guess...) Regards Takashi Sakamoto