From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01EBC433EF for ; Thu, 11 Nov 2021 17:46:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEA6B61077 for ; Thu, 11 Nov 2021 17:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232777AbhKKRtG (ORCPT ); Thu, 11 Nov 2021 12:49:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:51984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233705AbhKKRtF (ORCPT ); Thu, 11 Nov 2021 12:49:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 19DF361268; Thu, 11 Nov 2021 17:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636652776; bh=t4v6QOc8d9eGSyxQQvFgi8E+t/3B1gGlPGRtk+Vx7oY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lUUYvyrdTrYhN6QE+b8PSFlD4+yIrsonGhp8QuubwS/ADwuoOc6Vl+eXUNPmb/FpD vA9ab5TQD3Kk+tp2rIAU25qeMj0OrzVnGajTZV2RIFJtsTtaebpfsqXqHDmDh8jjyN idhQFydwkOaxdrHuqut8J/SVrmlYNg6zXscEU4h+jj/zHYOjyCQyi8hxvmF/QE53MX XnpuQNjxim6UEaNEUv/ocyyVVeH7aLNY1abgddaUzbezBSIjHLMeQyh2EofS+AmO2i 7eTMbhSRv2iprdlK1X+NlxDIN5J8N/t/RqOYoLUFwqnqepa9f7r8Bhek9mKvzIToVf s/4U3aZLaHifA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0FD8E410A1; Thu, 11 Nov 2021 14:46:13 -0300 (-03) Date: Thu, 11 Nov 2021 14:46:12 -0300 From: Arnaldo Carvalho de Melo To: Yonghong Song Cc: Andrii Nakryiko , Arnaldo Carvalho de Melo , dwarves@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , bpf , Daniel Borkmann , Kernel Team Subject: Re: [PATCH dwarves v2 0/2] btf: support typedef DW_TAG_LLVM_annotation Message-ID: References: <20211102233500.1024582-1-yhs@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Em Tue, Nov 09, 2021 at 09:23:30PM -0800, Yonghong Song escreveu: > > > On 11/2/21 5:11 PM, Andrii Nakryiko wrote: > > On Tue, Nov 2, 2021 at 4:35 PM Yonghong Song wrote: > > > > > > Latest llvm is able to generate DW_TAG_LLVM_annotation for typedef > > > declarations. Latest bpf-next supports BTF_KIND_DECL_TAG for > > > typedef declarations. This patch implemented dwarf DW_TAG_LLVM_annotation > > > to btf BTF_KIND_DECL_TAG conversion. Patch 1 is for dwarf_loader > > > to process DW_TAG_LLVM_annotation tags. Patch 2 is for the > > > dwarf->btf conversion. > > > > > > Changelog: > > > v1 -> v2: > > > - change some "if" statements to "switch" statement. > > > > > > > LGTM. > > > > Acked-by: Andrii Nakryiko > > Arnaldo, did you get chance to look at this patch set? Yeah, I've merged and put it in the tmp.master branch so that libbpf's CI can have a go on it. I'm also updating my clang/llvm build to test it. Thanks, - Arnaldo > > > > > Yonghong Song (2): > > > dwarf_loader: support typedef DW_TAG_LLVM_annotation > > > btf_encoder: generate BTF_KIND_DECL_TAGs for typedef btf_decl_tag > > > attributes > > > > > > btf_encoder.c | 17 ++++++++++++++--- > > > dwarf_loader.c | 7 ++----- > > > 2 files changed, 16 insertions(+), 8 deletions(-) > > > > > > -- > > > 2.30.2 > > > -- - Arnaldo