From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5544:0:0:0:0:0 with SMTP id l4csp574289lfk; Thu, 11 Nov 2021 10:21:51 -0800 (PST) X-Received: by 2002:a1c:730b:: with SMTP id d11mr10458603wmb.17.1636654911367; Thu, 11 Nov 2021 10:21:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636654911; cv=none; d=google.com; s=arc-20160816; b=bNisHc5X79hbI+//A5u+KHARxu1iKl7ErmhdR2Fql94kWAwUGay5u9UOe9l91lLwSP 5Q1EDEqg9sqDlbwxWTN1UJR3F4jBUK3p9eGtEyyBAGvysPr1gIKIj5ggpNf5Dt7JKhUA zKOjaQBaXXEfcvMAi5DabxsN3Sz53XHa13If5B5Xl3kVtbAhC/2Nm7b+o5MlObreKtZq hJyEXhC5ZvwDmk5eWs128bZtOdW2/53BjvoEbwpQwFvOOMwZ6KEdVYQIJW/3ODqnpQL9 IdbBxUs7b6OX+gtVm3dzSgw/RKTw+HndkUhvf2PTvO33Ev8hrkdJ+JGSdvM4SCNdB3F6 ZIig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=1nDfgExPLVmPjrHAgq5VjwgrVgGQAem5IuVIe5/76Gk=; b=JN18o5fkNZc7h932wLmPldF06teuM3wh/vrbRtdXcYN4enHQiTMduJLXCkruPf2hqL 2fzgu2kvLt9rShHy+pGLnZU9EjTOBRhF8Ij5ojt4l9FxlmrwOts2dinQOdL0WG7272Rv 6G0S5diUtwUlYjojWoCBnGaDmynMCmD3HGt8N19S/X4tXem4pzGnCxSFq/uQMrXVptUe lfRHzr3DY33kcKFuD0R6WNWMYAPln7sXtfag6C4BVylkonHE9/Dk4sVubJrQqK/H9IjF sAtTlXMxkFzwcGD6+VvdutG/fBTKs0DYsHKvPD9c8huJZVJvXCEtOydhfrg5dphqmyMz HWXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=UGhHc4TF; spf=pass (google.com: domain of leif@nuviainc.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=leif@nuviainc.com Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id z8sor2635952wrm.15.2021.11.11.10.21.51 for (Google Transport Security); Thu, 11 Nov 2021 10:21:51 -0800 (PST) Received-SPF: pass (google.com: domain of leif@nuviainc.com designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=UGhHc4TF; spf=pass (google.com: domain of leif@nuviainc.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=leif@nuviainc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1nDfgExPLVmPjrHAgq5VjwgrVgGQAem5IuVIe5/76Gk=; b=UGhHc4TFB2k+7wS5DHjiEITIVyZrXuCcKONzlu8VgFClKneznjC3TAqo/mWe7sI3xa rv1CQQg7A/FOxG4XVD1vC+X50rAc+HJb2c+Lek3joHgtuES86dWD1f6U/AukNHzFHN5n huaf9DmwRFF/kOV3rUAndqdPQIM6NcK+JDqzhBFWGfZUh0OVamZZC6oS8vxt1e/xzsb4 rvsOL+0/7E1y6VLc5mQmdfHrwqB+sgFHT6JaL4D36k8lOvF/4YcjFTqA4Y33ZRWX6N5i ZCl73Iiy1dHfd5XugPNaOEpv2bkAzHGLvg+yAwUktse0VgJpgzCfrOdorG9ETkhFcPec GHTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1nDfgExPLVmPjrHAgq5VjwgrVgGQAem5IuVIe5/76Gk=; b=JztGM4C3lDMeA4lTWfB6MD+lQWGx+Y9ouA3CSkMJfrrVkACZ+qSxHW8EUktU5PAeJ/ S9qSLVssvMRCC2HROEfwNX4trCSA2uG6yqJPZwwsRlLIbZ4A5KUh8LD7X8GTeiqAU+H0 F6JRLJZ4JSS563AwsIroLYl5QW8qcIA5qLIw8A7ZQThqLu3DWwbHA7McQJw/QGJYgOkD KSs1pfl2US0/1UQ3RG5/g71A9k9L1a9UEAjNs5Ksto26oL38zrRzqN5CMoP37l/QrnuP Xd1HsYFar3j3flzBZFdLWciTZC9TptYGuJZDHjufwwlUt/c7IncsmxXiWEanuAssTcPC gabQ== X-Gm-Message-State: AOAM532xYsfH8VV8mGIYbbmp8EfgvxdJZogj+04vJwTSdt7YhpZKHjIW VWpExPrX0h+2+VeMuSk1QTV1QQ== X-Google-Smtp-Source: ABdhPJzfqpatzU8RaPRMu6+pUprPNM3lLb7nzJ4fswLhkBrpO8jx0tR9hTF1vJWfrLd8Nc4XpQvD0A== X-Received: by 2002:a05:6000:15c8:: with SMTP id y8mr11340278wry.101.1636654911055; Thu, 11 Nov 2021 10:21:51 -0800 (PST) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id n32sm3374467wms.42.2021.11.11.10.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 10:21:50 -0800 (PST) Date: Thu, 11 Nov 2021 18:21:48 +0000 From: Leif Lindholm To: Peter Maydell Cc: Shashi Mallela , Radoslaw Biernacki , "Michael S. Tsirkin" , Igor Mammedov , qemu-arm , QEMU Developers , Eric Auger , narmstrong@baylibre.com, Alex =?iso-8859-1?Q?Benn=E9e?= , Marcin Juszkiewicz Subject: Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC Message-ID: References: <20210812165341.40784-8-shashi.mallela@linaro.org> <20210902124258.mqjhx7lqqvkczf6a@leviathan> <20211015122351.vc55mwzjbevl6wjy@leviathan> <20211109204249.usvfatm3frar3u7a@leviathan> <20211109225251.gfr2mvm3jynvdsnk@leviathan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TUID: kQ+sP6bWsZfq On Thu, Nov 11, 2021 at 16:55:09 +0000, Peter Maydell wrote: > On Tue, 9 Nov 2021 at 22:52, Leif Lindholm wrote: > > > > On Tue, Nov 09, 2021 at 21:21:46 +0000, Peter Maydell wrote: > > > The other thing we should nail down is how the user is going to > > > select which flavour of machine they want to provide. Three > > > options: > > > (1) no control, QEMU just emulates whatever the newest flavour is. > > > User needs to go find a firmware image new enough to cope. > > > (2) different flavours exposed as different machine types > > > (analogous to how we have musca-a and musca-b1, or raspi3ap and > > > raspi3b, for instance). Old user command lines keep working > > > because -M sbsa-ref doesn't change; the new stuff would be > > > available via -M sbsa-ref-2 or whatever. > > > (3) different flavours exposed via a property > > > (so you would have -M sbsa-ref,machine-revision=2 or something). > > > If the revision defaults to 1 then old user setups still work > > > but everybody starts to have to cart around an extra command > > > line argument. If it defaults to "newest we know about" you > > > get the opposite set of tradeoffs. > > > > I'm leaning towards (1), at least while working towards a "complete" > > platform (when we may still add/change features, but not how those > > features are communicated to the firmware). > > That's certainly the easiest on the QEMU side; you know the > userbase so would know whether that kind of compat break is > going to be OK with them. > > Q1: who is going to write the code for this? Me, my team, and perhaps a little bit of help from Shashi where it intersects his code. > Q2: do we want to try to land "ITS in sbsa-ref" in 6.2? Given > we're in freeze we're quite short of time even if we handwave > the fact it's a new feature, not a bugfix, so I would lean > towards 'no'... Shashi - what is your feeling? If we could make ITS support depend on the platform version being communicated through TF-A, we could simplify the transition a lot. But that would definitely mean missing 6.2. Peter - could we sneak in an "add version node to DT" into 6.2? / Leif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99E8C433EF for ; Thu, 11 Nov 2021 18:24:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ED1B61268 for ; Thu, 11 Nov 2021 18:24:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7ED1B61268 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nuviainc.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34800 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlEk5-0006EQ-HQ for qemu-devel@archiver.kernel.org; Thu, 11 Nov 2021 13:24:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlEhv-0005Gl-At for qemu-devel@nongnu.org; Thu, 11 Nov 2021 13:21:55 -0500 Received: from [2a00:1450:4864:20::434] (port=44772 helo=mail-wr1-x434.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlEht-0006Z7-2i for qemu-devel@nongnu.org; Thu, 11 Nov 2021 13:21:54 -0500 Received: by mail-wr1-x434.google.com with SMTP id n29so11245266wra.11 for ; Thu, 11 Nov 2021 10:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1nDfgExPLVmPjrHAgq5VjwgrVgGQAem5IuVIe5/76Gk=; b=UGhHc4TFB2k+7wS5DHjiEITIVyZrXuCcKONzlu8VgFClKneznjC3TAqo/mWe7sI3xa rv1CQQg7A/FOxG4XVD1vC+X50rAc+HJb2c+Lek3joHgtuES86dWD1f6U/AukNHzFHN5n huaf9DmwRFF/kOV3rUAndqdPQIM6NcK+JDqzhBFWGfZUh0OVamZZC6oS8vxt1e/xzsb4 rvsOL+0/7E1y6VLc5mQmdfHrwqB+sgFHT6JaL4D36k8lOvF/4YcjFTqA4Y33ZRWX6N5i ZCl73Iiy1dHfd5XugPNaOEpv2bkAzHGLvg+yAwUktse0VgJpgzCfrOdorG9ETkhFcPec GHTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1nDfgExPLVmPjrHAgq5VjwgrVgGQAem5IuVIe5/76Gk=; b=z5T4poLsddXLkzaEvMcQb79HSRCrRvnQnwc4ka+Qq364FsDIyWNjMhNbGmd4vCN4At 7FxCKJ3MAfzDGFYTurR6X8b/gw39/ahiMZiuxYB2GZsqmwuK92HWesPBiHSqyfVtM1Cp x+SCiHeJTznUMxZSyR+oVpCLdZmiwHsqe1nGEoDkxd/lsNaq3yCgNr/vJkylAeiKiXoD lwLUn98DLq/HKmFAhGge1E7cQ484SXN+bSnoBBR0xvuNX1iCnaOnjEIf/bDhDz95O6t1 sJ2Uhp6HoOwwUlNW5Zq8o7Kn4ZMZgCym7JwWCCK6dm5mNqXMdRFcd39LxrfI6jq6tFf+ 4N9Q== X-Gm-Message-State: AOAM533tiseEHTUIjUrO65K7iVDZo9BctwUPAwU/3kJuM1LPnKHvsHkG EsVogjfGfjojwvYgdULphrrWRA== X-Google-Smtp-Source: ABdhPJzfqpatzU8RaPRMu6+pUprPNM3lLb7nzJ4fswLhkBrpO8jx0tR9hTF1vJWfrLd8Nc4XpQvD0A== X-Received: by 2002:a05:6000:15c8:: with SMTP id y8mr11340278wry.101.1636654911055; Thu, 11 Nov 2021 10:21:51 -0800 (PST) Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id n32sm3374467wms.42.2021.11.11.10.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 10:21:50 -0800 (PST) Date: Thu, 11 Nov 2021 18:21:48 +0000 From: Leif Lindholm To: Peter Maydell Subject: Re: [PATCH v8 07/10] hw/arm/sbsa-ref: add ITS support in SBSA GIC Message-ID: References: <20210812165341.40784-8-shashi.mallela@linaro.org> <20210902124258.mqjhx7lqqvkczf6a@leviathan> <20211015122351.vc55mwzjbevl6wjy@leviathan> <20211109204249.usvfatm3frar3u7a@leviathan> <20211109225251.gfr2mvm3jynvdsnk@leviathan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::434 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=leif@nuviainc.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcin Juszkiewicz , "Michael S. Tsirkin" , Shashi Mallela , Radoslaw Biernacki , QEMU Developers , narmstrong@baylibre.com, Eric Auger , qemu-arm , Igor Mammedov , Alex =?iso-8859-1?Q?Benn=E9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Nov 11, 2021 at 16:55:09 +0000, Peter Maydell wrote: > On Tue, 9 Nov 2021 at 22:52, Leif Lindholm wrote: > > > > On Tue, Nov 09, 2021 at 21:21:46 +0000, Peter Maydell wrote: > > > The other thing we should nail down is how the user is going to > > > select which flavour of machine they want to provide. Three > > > options: > > > (1) no control, QEMU just emulates whatever the newest flavour is. > > > User needs to go find a firmware image new enough to cope. > > > (2) different flavours exposed as different machine types > > > (analogous to how we have musca-a and musca-b1, or raspi3ap and > > > raspi3b, for instance). Old user command lines keep working > > > because -M sbsa-ref doesn't change; the new stuff would be > > > available via -M sbsa-ref-2 or whatever. > > > (3) different flavours exposed via a property > > > (so you would have -M sbsa-ref,machine-revision=2 or something). > > > If the revision defaults to 1 then old user setups still work > > > but everybody starts to have to cart around an extra command > > > line argument. If it defaults to "newest we know about" you > > > get the opposite set of tradeoffs. > > > > I'm leaning towards (1), at least while working towards a "complete" > > platform (when we may still add/change features, but not how those > > features are communicated to the firmware). > > That's certainly the easiest on the QEMU side; you know the > userbase so would know whether that kind of compat break is > going to be OK with them. > > Q1: who is going to write the code for this? Me, my team, and perhaps a little bit of help from Shashi where it intersects his code. > Q2: do we want to try to land "ITS in sbsa-ref" in 6.2? Given > we're in freeze we're quite short of time even if we handwave > the fact it's a new feature, not a bugfix, so I would lean > towards 'no'... Shashi - what is your feeling? If we could make ITS support depend on the platform version being communicated through TF-A, we could simplify the transition a lot. But that would definitely mean missing 6.2. Peter - could we sneak in an "add version node to DT" into 6.2? / Leif