diff for duplicates of <YY26dxv2kM3m2H7Z@google.com> diff --git a/a/1.txt b/N1/1.txt index dccdae1..8548f48 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,7 +14,7 @@ On Fri, Nov 12, 2021, Maciej S. Szmigiero wrote: > > + hash_del(&old->id_node[idx]); > > + interval_tree_remove(&old->hva_node[idx], &slots->hva_tree); > > - if (!new) -> > + if ((long)old == atomic_long_read(&slots->last_used_slot)) +> > + if ((long)old = atomic_long_read(&slots->last_used_slot)) > > + atomic_long_set(&slots->last_used_slot, (long)new); > > Open-coding cmpxchg() is way less readable than a direct call. diff --git a/a/content_digest b/N1/content_digest index 249f6ff..608c59b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,9 +2,40 @@ "ref\020211104002531.1176691-27-seanjc@google.com\0" "ref\05f5c80ce-9189-def3-9c50-d5a504925253@oracle.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" + "Subject\0Re: [PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" "Date\0Fri, 12 Nov 2021 00:51:03 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Maciej S. Szmigiero <maciej.szmigiero@oracle.com>\0" + "Cc\0James Morse <james.morse@arm.com>" + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + Ben Gardon <bgardon@google.com> + Marc Zyngier <maz@kernel.org> + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + " Paolo Bonzini <pbonzini@redhat.com>\0" "\00:1\0" "b\0" "On Fri, Nov 12, 2021, Maciej S. Szmigiero wrote:\n" @@ -23,7 +54,7 @@ "> > +\t\thash_del(&old->id_node[idx]);\n" "> > +\t\tinterval_tree_remove(&old->hva_node[idx], &slots->hva_tree);\n" "> > -\t\tif (!new)\n" - "> > +\t\tif ((long)old == atomic_long_read(&slots->last_used_slot))\n" + "> > +\t\tif ((long)old = atomic_long_read(&slots->last_used_slot))\n" "> > +\t\t\tatomic_long_set(&slots->last_used_slot, (long)new);\n" "> \n" "> Open-coding cmpxchg() is way less readable than a direct call.\n" @@ -79,4 +110,4 @@ "Eww. I would much prefer to \"fix\" the existing code in a prep patch. It shouldn't\n" matter, but arch code really should not get passed an INVALID slot. -c49b4f64b42f7bfaf7d9dc1834c797dccd55fbf2e2447e9266339f69ef6218f4 +2a4ec026505cac373fad68f412ce8139f1f0badd87d1b35f081119a235e36369
diff --git a/a/1.txt b/N2/1.txt index dccdae1..5fe9b25 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -69,3 +69,7 @@ I don't have a strong preference, I just got briefly confused by the atomicity p Eww. I would much prefer to "fix" the existing code in a prep patch. It shouldn't matter, but arch code really should not get passed an INVALID slot. +_______________________________________________ +kvmarm mailing list +kvmarm@lists.cs.columbia.edu +https://lists.cs.columbia.edu/mailman/listinfo/kvmarm diff --git a/a/content_digest b/N2/content_digest index 249f6ff..e24bc52 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,9 +2,37 @@ "ref\020211104002531.1176691-27-seanjc@google.com\0" "ref\05f5c80ce-9189-def3-9c50-d5a504925253@oracle.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" + "Subject\0Re: [PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" "Date\0Fri, 12 Nov 2021 00:51:03 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Maciej S. Szmigiero <maciej.szmigiero@oracle.com>\0" + "Cc\0Anup Patel <anup.patel@wdc.com>" + Wanpeng Li <wanpengli@tencent.com> + kvm@vger.kernel.org + David Hildenbrand <david@redhat.com> + linux-kernel@vger.kernel.org + Paul Mackerras <paulus@ozlabs.org> + Atish Patra <atish.patra@wdc.com> + Ben Gardon <bgardon@google.com> + linux-riscv@lists.infradead.org + Claudio Imbrenda <imbrenda@linux.ibm.com> + kvmarm@lists.cs.columbia.edu + Janosch Frank <frankja@linux.ibm.com> + Marc Zyngier <maz@kernel.org> + Joerg Roedel <joro@8bytes.org> + Huacai Chen <chenhuacai@kernel.org> + Christian Borntraeger <borntraeger@de.ibm.com> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + kvm-ppc@vger.kernel.org + Paul Walmsley <paul.walmsley@sifive.com> + linux-arm-kernel@lists.infradead.org + Jim Mattson <jmattson@google.com> + Cornelia Huck <cohuck@redhat.com> + linux-mips@vger.kernel.org + kvm-riscv@lists.infradead.org + Paolo Bonzini <pbonzini@redhat.com> + " Vitaly Kuznetsov <vkuznets@redhat.com>\0" "\00:1\0" "b\0" "On Fri, Nov 12, 2021, Maciej S. Szmigiero wrote:\n" @@ -77,6 +105,10 @@ "> That's also what the previous version of this patch set did.\n" "\n" "Eww. I would much prefer to \"fix\" the existing code in a prep patch. It shouldn't\n" - matter, but arch code really should not get passed an INVALID slot. + "matter, but arch code really should not get passed an INVALID slot.\n" + "_______________________________________________\n" + "kvmarm mailing list\n" + "kvmarm@lists.cs.columbia.edu\n" + https://lists.cs.columbia.edu/mailman/listinfo/kvmarm -c49b4f64b42f7bfaf7d9dc1834c797dccd55fbf2e2447e9266339f69ef6218f4 +d27382993877178ee694c4418a5818745a5775f2629dbdc4ccf9d39cbf049d0e
diff --git a/a/content_digest b/N3/content_digest index 249f6ff..fc5d3ae 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,9 +2,40 @@ "ref\020211104002531.1176691-27-seanjc@google.com\0" "ref\05f5c80ce-9189-def3-9c50-d5a504925253@oracle.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" + "Subject\0Re: [PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" "Date\0Fri, 12 Nov 2021 00:51:03 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Maciej S. Szmigiero <maciej.szmigiero@oracle.com>\0" + "Cc\0James Morse <james.morse@arm.com>" + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + Ben Gardon <bgardon@google.com> + Marc Zyngier <maz@kernel.org> + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + " Paolo Bonzini <pbonzini@redhat.com>\0" "\00:1\0" "b\0" "On Fri, Nov 12, 2021, Maciej S. Szmigiero wrote:\n" @@ -79,4 +110,4 @@ "Eww. I would much prefer to \"fix\" the existing code in a prep patch. It shouldn't\n" matter, but arch code really should not get passed an INVALID slot. -c49b4f64b42f7bfaf7d9dc1834c797dccd55fbf2e2447e9266339f69ef6218f4 +6cd90dacd6062d33a6f4acef8d3096ac6f09be4dce03d3ca50d85fcd18a7d73a
diff --git a/a/1.txt b/N4/1.txt index dccdae1..2632df7 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -69,3 +69,8 @@ I don't have a strong preference, I just got briefly confused by the atomicity p Eww. I would much prefer to "fix" the existing code in a prep patch. It shouldn't matter, but arch code really should not get passed an INVALID slot. + +_______________________________________________ +linux-riscv mailing list +linux-riscv@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-riscv diff --git a/a/content_digest b/N4/content_digest index 249f6ff..51f24fc 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -2,9 +2,40 @@ "ref\020211104002531.1176691-27-seanjc@google.com\0" "ref\05f5c80ce-9189-def3-9c50-d5a504925253@oracle.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" + "Subject\0Re: [PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" "Date\0Fri, 12 Nov 2021 00:51:03 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Maciej S. Szmigiero <maciej.szmigiero@oracle.com>\0" + "Cc\0James Morse <james.morse@arm.com>" + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + Ben Gardon <bgardon@google.com> + Marc Zyngier <maz@kernel.org> + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + " Paolo Bonzini <pbonzini@redhat.com>\0" "\00:1\0" "b\0" "On Fri, Nov 12, 2021, Maciej S. Szmigiero wrote:\n" @@ -77,6 +108,11 @@ "> That's also what the previous version of this patch set did.\n" "\n" "Eww. I would much prefer to \"fix\" the existing code in a prep patch. It shouldn't\n" - matter, but arch code really should not get passed an INVALID slot. + "matter, but arch code really should not get passed an INVALID slot.\n" + "\n" + "_______________________________________________\n" + "linux-riscv mailing list\n" + "linux-riscv@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-riscv -c49b4f64b42f7bfaf7d9dc1834c797dccd55fbf2e2447e9266339f69ef6218f4 +5891c892b2f1e107ddd7ae3c4361b593ad52bce08f4b8eecde3d170da2e5d612
diff --git a/a/1.txt b/N5/1.txt index dccdae1..679d8a0 100644 --- a/a/1.txt +++ b/N5/1.txt @@ -69,3 +69,8 @@ I don't have a strong preference, I just got briefly confused by the atomicity p Eww. I would much prefer to "fix" the existing code in a prep patch. It shouldn't matter, but arch code really should not get passed an INVALID slot. + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N5/content_digest index 249f6ff..8642e15 100644 --- a/a/content_digest +++ b/N5/content_digest @@ -2,9 +2,40 @@ "ref\020211104002531.1176691-27-seanjc@google.com\0" "ref\05f5c80ce-9189-def3-9c50-d5a504925253@oracle.com\0" "From\0Sean Christopherson <seanjc@google.com>\0" - "Subject\0[PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" + "Subject\0Re: [PATCH v5.5 26/30] KVM: Keep memslots in tree-based structures instead of array-based ones\0" "Date\0Fri, 12 Nov 2021 00:51:03 +0000\0" - "To\0kvm-riscv@lists.infradead.org\0" + "To\0Maciej S. Szmigiero <maciej.szmigiero@oracle.com>\0" + "Cc\0James Morse <james.morse@arm.com>" + Alexandru Elisei <alexandru.elisei@arm.com> + Suzuki K Poulose <suzuki.poulose@arm.com> + Atish Patra <atish.patra@wdc.com> + David Hildenbrand <david@redhat.com> + Cornelia Huck <cohuck@redhat.com> + Claudio Imbrenda <imbrenda@linux.ibm.com> + Vitaly Kuznetsov <vkuznets@redhat.com> + Wanpeng Li <wanpengli@tencent.com> + Jim Mattson <jmattson@google.com> + Joerg Roedel <joro@8bytes.org> + linux-arm-kernel@lists.infradead.org + kvmarm@lists.cs.columbia.edu + linux-mips@vger.kernel.org + kvm@vger.kernel.org + kvm-ppc@vger.kernel.org + kvm-riscv@lists.infradead.org + linux-riscv@lists.infradead.org + linux-kernel@vger.kernel.org + Ben Gardon <bgardon@google.com> + Marc Zyngier <maz@kernel.org> + Huacai Chen <chenhuacai@kernel.org> + Aleksandar Markovic <aleksandar.qemu.devel@gmail.com> + Paul Mackerras <paulus@ozlabs.org> + Anup Patel <anup.patel@wdc.com> + Paul Walmsley <paul.walmsley@sifive.com> + Palmer Dabbelt <palmer@dabbelt.com> + Albert Ou <aou@eecs.berkeley.edu> + Christian Borntraeger <borntraeger@de.ibm.com> + Janosch Frank <frankja@linux.ibm.com> + " Paolo Bonzini <pbonzini@redhat.com>\0" "\00:1\0" "b\0" "On Fri, Nov 12, 2021, Maciej S. Szmigiero wrote:\n" @@ -77,6 +108,11 @@ "> That's also what the previous version of this patch set did.\n" "\n" "Eww. I would much prefer to \"fix\" the existing code in a prep patch. It shouldn't\n" - matter, but arch code really should not get passed an INVALID slot. + "matter, but arch code really should not get passed an INVALID slot.\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -c49b4f64b42f7bfaf7d9dc1834c797dccd55fbf2e2447e9266339f69ef6218f4 +e33eaf5dcd0cb5a4e65aba334241d038b4a53a57f99956657023754971e9768a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.