From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2501C433F5 for ; Fri, 12 Nov 2021 16:18:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D941460EE2 for ; Fri, 12 Nov 2021 16:18:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D941460EE2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stwcx.xyz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HrNzh24wRz302G for ; Sat, 13 Nov 2021 03:18:08 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=GXMeN0rc; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=ktCc78V4; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=stwcx.xyz (client-ip=66.111.4.27; helo=out3-smtp.messagingengine.com; envelope-from=patrick@stwcx.xyz; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=GXMeN0rc; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=ktCc78V4; dkim-atps=neutral Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HrNys2ryQz2ymt for ; Sat, 13 Nov 2021 03:17:24 +1100 (AEDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A9EBC5C19AB for ; Fri, 12 Nov 2021 11:17:19 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 12 Nov 2021 11:17:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:subject:message-id:mime-version:content-type; s= fm3; bh=epVX3inosyXGqqJdH05TXg28JQ1k1m3dgx9+HhPqegA=; b=GXMeN0rc pryXPXa0QEnfvnZpJlNBlhOnFe3cIL1P26noWiUf7Dg7yTvJDzpKZ2883VZE9FXG eHo+Y1/kK7iFKyV8B+2FA+vByCEUCu03P0yMs7yUpXtpGQHdEOmWWxymsUe7EyNC rBaQMVmbdRz1Q3GIqXgTj5XI3XHqaDt6FPzko07dWE9QMV4LcrQZzjabZMF9tiZF bdN8QQnChYc5ysrMEXnujz7QZCxxaArltvQcjOReIwP9soP4AMbCuqWMKYOOSOwt VTVkFVcTnB5KhocQsF/guMLxe5NLKjGcXN2KVLxOcXdBJQGaQrzg2BoANbs6iiIN eeEtmZKEIhX23Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=epVX3inosyXGqqJdH05TXg28JQ1k1 m3dgx9+HhPqegA=; b=ktCc78V49dc5Lg7fOvLvxokpIMDjD/o+R8p38pSeEiphq 3NSE2bk/p+9qy20mMEtL7dQb8B6nM8aTOU/+tWpSVneXXvJvGld0X6ZwIStXtrHy AjGdSlJOEmrZvhIkqGh+z6vxezd9mpNICFCp8NI1o1Eb77+rOuc2BGCRvVDwnjAo ZamoF1v/W6BqJciQz/FiNxWbbPZ+kWHHGiFRrhrDjaY1qPDPlokgTbvrcg1Og7Gu lfJSAlZqzDBcyL2b8/uwSGzHu7MxbtrFWXJiesy+94OQ1j9sxoVq/d7ZT9L6b6b+ fAEY13cEyUBrlzODDw2+z6/zlC38RSPa/urK6v+0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrvdefgdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfggtggusehgtderredttddvnecu hfhrohhmpefrrghtrhhitghkucghihhllhhirghmshcuoehprghtrhhitghksehsthiftg igrdighiiiqeenucggtffrrghtthgvrhhnpeeftdffvefggeelleehteelkefgheduhfej feeggeeifedutdehvdethfehveehvdenucffohhmrghinhepohhpvghnsghmtgdqphhroh hjvggtthdrgiihiienucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhl fhhrohhmpehprghtrhhitghksehsthiftgigrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 12 Nov 2021 11:17:19 -0500 (EST) Date: Fri, 12 Nov 2021 10:17:17 -0600 From: Patrick Williams To: OpenBMC List Subject: Unix-mode newlines Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IHkZ/X5RFqsXTNmC" Content-Disposition: inline X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --IHkZ/X5RFqsXTNmC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, Generally we've had a preference for Unix-style newlines (\n) and not DOS-s= tyle newlines (\r\n), but it has never been documented. I've recently found a small number of files that are either DOS-style or mixed-styles and I've = been fixing them as I've ran into them. I recently discovered that clang-format has options that allow us to force Unix-style newlines. I've pushed up a commit to docs that makes two change= s to our C++ style guidelines: 1) Document expectation of using Unix-style newlines. 2) Update .clang-format to enforce Unix-style newlines. See https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/48770 . I'll leave this commit open until early next week and then merge it if I do= n't hear any concerns. --=20 Patrick Williams --IHkZ/X5RFqsXTNmC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmGOk4sACgkQqwNHzC0A wRk/Vg//UlSOHcvCOqn9J6nqT/lZnGKdFF+/vqnyP9J5Bg8dqmGyKUPB2xgkj9Aj K1ZIqyUCukqUXRDSRMyohJm21IalbPTnPrqTYEA/nn2rO/HSsgGkPcIz1fOHck/h kkmbTGhRtY8IUJUP1dgghfzZkAkbOddW/bF2u/NNA3R2uDjqVobkBK8gGOq6EY67 0cleTRwtJ8WbvspvXX3Bzob3NtqJvY5hHsVWzufsm5LzWH/2AkhjYSF66kLDcMnG 1W3xDI/OTBfhvSU7NAiRNYZe7M3Ve5CxB1rPv47sQOkaZ3CjB0GGKYvNJNvv57vu 3O1wItO6iIcIQldyiGQXvnytL20LpFV3dO02aSvyfqcJ2hb4W2Dg+i6hYmNl1m6B JWONQkQ4nK6PiirNhEa0aFaMHDpMZOfh/Elcx4RGP9ZJh2qVu/ydNaDN6KDVlTbQ jXFt9z3CPTmVk6XLoMTs3TQ56ZbpGlcEKNOAtVlwHmxEa7rEtaSuqrc/c5dH+Gay wFr0JC9sm2Dga8cBPAUff0adXjd1bgK8D2PhUE1TOdbDS1ZUnT2Cu+EPKgZwAM8A 0OBM0jelh9Laz08kgScdLlwekN2Ew0XOX78E5wC+/ma/1KvjyLF6pADO3722+2Rt dhPid/S7PL2H/smukwwOl6NdRnr9j9W5P50AX65gGBV3rwREc2E= =/2O1 -----END PGP SIGNATURE----- --IHkZ/X5RFqsXTNmC--