From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997B9C433EF for ; Tue, 2 Nov 2021 11:20:45 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A5B060E98 for ; Tue, 2 Nov 2021 11:20:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A5B060E98 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B124A3C7172 for ; Tue, 2 Nov 2021 12:20:43 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 9242C3C68BB for ; Tue, 2 Nov 2021 12:20:34 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 0DCA1600C43 for ; Tue, 2 Nov 2021 12:20:33 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 194D5212C0; Tue, 2 Nov 2021 11:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635852033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LHPkVOzSXJSzjxj6UeGXi5DvTi2UNJC0dTDEqDW/JtM=; b=YeKsFsq4jBF40Tbt2SDxUd4+lpR2x2++j7JLrGjZs0RyMIm/k6kPmnaY9JOY9W8OIBG1mU Zl9uPhB0MU1bvuClCBcIbI6lic5FlTnev9TLoumCj/dZsO483y6X8xAbvEhe0lRSVR6QGo zIhUlYXkev8sbXUJ426g1o/WCJk9sOw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635852033; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LHPkVOzSXJSzjxj6UeGXi5DvTi2UNJC0dTDEqDW/JtM=; b=DOwHOEQ2Q47Vaq7erdZ43OtqPtJdsFEItrrd+nIowJw0N4ok5dNElSqalZ7gMR82+03epf EfRJH3gDjXxq+eDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 018BE13C1F; Tue, 2 Nov 2021 11:20:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IMyFOgAfgWE8QwAAMHmgww (envelope-from ); Tue, 02 Nov 2021 11:20:32 +0000 Date: Tue, 2 Nov 2021 12:21:26 +0100 From: Cyril Hrubis To: Richard Palethorpe Message-ID: References: <20211101145342.7166-1-chrubis@suse.cz> <20211101145342.7166-2-chrubis@suse.cz> <871r3yq0hm.fsf@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871r3yq0hm.fsf@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 1/7] docparse: Implement #define and #include X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > +static void macro_get_string(FILE *f, char *buf, char *buf_end) > > +{ > > + int c; > > + > > + for (;;) { > > + c = fgetc(f); > > + > > + switch (c) { > > + case '"': > > Luckily there are no instances of '#define MACRO "...\"...\"..."' in LTP > AFAICT. Also there don't appear to be any '#define MACRO "..." \\n' that > we would care about. Well I can fix that and add a test to to be sure. > > + case EOF: > > + *buf = 0; > > + return; > > + default: > > + if (buf < buf_end) > > + *(buf++) = c; > > + } > > + } > > +} > > + > > +static void macro_get_val(FILE *f, char *buf, size_t buf_len) > > +{ > > + int c, prev = 0; > > + char *buf_end = buf + buf_len - 1; > > + > > + c = fgetc(f); > > + if (c == '"') { > > I guess this could be whitespace unless scanf slurps any trailing > whitespace? The scanf does not slurp any trainling whitespaces, so this should be fixed by: while (isspace(c = fgetc(f))); With that we get slightly better output, so I will add that before applying. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp