From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Štěpán Němec" <snemec@redhat.com>
Cc: netfilter-devel@vger.kernel.org, phil@nwl.cc
Subject: Re: [PATCH nft] tests: shell: $NFT needs to be invoked unquoted
Date: Tue, 2 Nov 2021 12:37:26 +0100 [thread overview]
Message-ID: <YYEi9gPdID3GTGg5@salvia> (raw)
In-Reply-To: <20211021175438.758386-1-snemec@redhat.com>
On Thu, Oct 21, 2021 at 07:54:38PM +0200, Štěpán Němec wrote:
> The variable has to undergo word splitting, otherwise the shell tries
> to find the variable value as an executable, which breaks in cases that
> 7c8a44b25c22 ("tests: shell: Allow wrappers to be passed as nft command")
> intends to support.
>
> Mention this in the shell tests README.
>
> Fixes: d8ccad2a2b73 ("tests: cover baecd1cf2685 ("segtree: Fix segfault when restoring a huge interval set")")
> Signed-off-by: Štěpán Němec <snemec@redhat.com>
> ---
> The test I added (0068) is the only problematic occurrence.
>
> This would be best applied on top of the README series (otherwise
> the README still talks about $NFT being a path to a binary).
OK, then I'll mark this one as "Changed Requested" and will wait for
you to include this one in the v2 of you README series.
Thanks.
next prev parent reply other threads:[~2021-11-02 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 17:54 [PATCH nft] tests: shell: $NFT needs to be invoked unquoted Štěpán Němec
2021-11-02 11:37 ` Pablo Neira Ayuso [this message]
2021-11-05 11:41 ` Štěpán Němec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYEi9gPdID3GTGg5@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=snemec@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.