From: Dominique Martinet <asmadeus@codewreck.org>
To: "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Eric Van Hensbergen" <ericvh@gmail.com>,
"Latchesar Ionkov" <lucho@ionkov.net>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/9p: autoload transport modules
Date: Wed, 3 Nov 2021 09:26:32 +0900 [thread overview]
Message-ID: <YYHXOOwkmJW8bhHW@codewreck.org> (raw)
In-Reply-To: <778dfd93-ace5-4cab-9a08-21d279f18c1f@t-8ch.de>
Thomas Weißschuh wrote on Tue, Nov 02, 2021 at 11:33:25PM +0000:
> > aha, these two were indeed different from where my modprobe is so it is
> > a setup problem -- I might have been a little rash with this initrd
> > setup and modprobe ended up in /bin with path here in /sbin...
> >
> > Thanks for the pointer, I saw the code setup an environment with a
> > full-blown PATH so didn't think of checking if this kind of setting
> > existed!
> > All looks in order then :)
>
> Does it also work for the split out FD transports?
> If so, I'll resend that patch in a proper form tomorrow.
Sorry haven't tested yet, I need to fiddle a bit to get a tcp server
setup right now and got a fscache bug I'd like fixed for this merge
window...
I've confirmed the module gets loaded but that's as far as I can get
right now... it calls p9_fd_create_tcp so it's probably quite ok :)
I'd also be tempted to add a new transport config option that defaults
to true/NET_9P value -- in my opinion the main advantage of splitting
this is not installing tcp/fd transport which can more easily be abused
than virtio for VMs who wouldn't need it (most of them), so having a
toggle would be handy.
Feel free to resend in a proper form though, I could make up a commit
message but it might as well be your words!
--
Dominique
next prev parent reply other threads:[~2021-11-03 0:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 13:46 [PATCH] net/9p: autoload transport modules Thomas Weißschuh
2021-11-02 10:51 ` Dominique Martinet
2021-11-02 10:59 ` Thomas Weißschuh
2021-11-02 11:51 ` Dominique Martinet
2021-11-02 14:49 ` Thomas Weißschuh
2021-11-02 14:58 ` Dominique Martinet
2021-11-02 15:32 ` Thomas Weißschuh
2021-11-02 23:17 ` Dominique Martinet
2021-11-02 23:33 ` Thomas Weißschuh
2021-11-03 0:26 ` Dominique Martinet [this message]
2021-11-03 1:00 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYHXOOwkmJW8bhHW@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=thomas@t-8ch.de \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.