From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16679C433F5 for ; Wed, 3 Nov 2021 07:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E690461183 for ; Wed, 3 Nov 2021 07:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232101AbhKCHqb (ORCPT ); Wed, 3 Nov 2021 03:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232088AbhKCHqb (ORCPT ); Wed, 3 Nov 2021 03:46:31 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0013AC061203 for ; Wed, 3 Nov 2021 00:43:54 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id z11-20020a1c7e0b000000b0030db7b70b6bso3845582wmc.1 for ; Wed, 03 Nov 2021 00:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ClKuP8tpWpUknWlqku1MtPOSrXJ/D/OoFdlpIIkXVR8=; b=dbNGWgs8fET68NobNr6n8pcDdNKfY/jPjt3XP2pCjvJGU6gK9nJhHWeKNyoMiwwEJY S8A4TDlscSKLoSXKKc0mZ86OW1tPWizq9DN21jR0u4f1C3x1kPbcDuY14PZpf4EhosD1 0gsrxvsxQkkZhiIpeyJ+E+FovlkV8bFjn0uV9XFmBQ6twZ8n60repSUho4/epZVwnXVK BQbgBwpkiK5b/KoC7Ago/H439Vj30m2HABtuH2fMbHDZdmqEiwRDa6U7/kDGMFfEJDFF kkk3ggxEzDvjr0B/oC1k4pfKkqWe3Eeq/rFbJpLJBtYO+/gLt+aY1CPbv4VGiIO75kdg U3Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ClKuP8tpWpUknWlqku1MtPOSrXJ/D/OoFdlpIIkXVR8=; b=VjvcT1n2u5ViL0ZxdFiYMpzH1+imwOLXxdlvNo3VRAQnieen7VqrBKUI4Whtxv+9kE jqfGX6zFgWlL67ZpPur2oV6uwXq3oxjGSNvBeBEkD8/5RUAkyQHSoOO9u+vZRj3Ph3Xp R8+fXvtJ6cjpVHWG9v2H9QHWZ4tM9Kek7vEyDhGIK9N803cSjabQq1FCkptd99Tl5sfx f1nI7TBRxf9F7+Z3iBRpFVkMaDhPd4kZd6CQVSQ8wOuSqT600m48PUGeCVMmBrr2P9Qy eb8Ff/mgS5gPTCTKVWehZ5rL68zes/8c6ucRlLzJ6h3xFo+Xnffs4BqNfdaEO8lYnAgg 4SRg== X-Gm-Message-State: AOAM530qrVoY1/39LEjqvrd9rQOFt0c+0ao/z6TdMijwtFwyEi0RAxkC PoCR22z0JVH9KaWGBuX4kMWG1A== X-Google-Smtp-Source: ABdhPJwpvPvRu2f3cAb5Rp9w93Klt/tdpQWD1EFjzvldLeAQIVOLSfYijN2eqqTE8kSGNPTNLyJNXA== X-Received: by 2002:a1c:2541:: with SMTP id l62mr13529661wml.11.1635925433583; Wed, 03 Nov 2021 00:43:53 -0700 (PDT) Received: from google.com ([95.148.6.174]) by smtp.gmail.com with ESMTPSA id w15sm1161593wrk.77.2021.11.03.00.43.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 00:43:53 -0700 (PDT) Date: Wed, 3 Nov 2021 07:43:51 +0000 From: Lee Jones To: Jonathan Corbet Cc: linux-kernel@vger.kernel.org, Paul Cercueil , Paul Burton , Sebastian Reichel , linux-pm@vger.kernel.org Subject: Re: [PATCH 1/9] Remove unused headers and Message-ID: References: <20211102220203.940290-1-corbet@lwn.net> <20211102220203.940290-2-corbet@lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211102220203.940290-2-corbet@lwn.net> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, 02 Nov 2021, Jonathan Corbet wrote: > Commit ff71266aa490 ("mfd: Drop obsolete JZ4740 driver") removed the last > file to include but left the header file itself > behind. Nothing uses it, remove it now. > > Similarly, aea12071d6fc ("power/supply: Drop obsolete JZ4740 driver") > deleted the last use of , so remove that one > too. > > Cc: Paul Cercueil > Cc: Lee Jones > Cc: Paul Burton > Cc: Sebastian Reichel > Cc: linux-pm@vger.kernel.org > Signed-off-by: Jonathan Corbet > --- > include/linux/jz4740-adc.h | 33 ---------------------------- > include/linux/power/jz4740-battery.h | 15 ------------- It appears as though there are still references to both of these *devices* in the kernel tree. Should those be removed also? > 2 files changed, 48 deletions(-) > delete mode 100644 include/linux/jz4740-adc.h > delete mode 100644 include/linux/power/jz4740-battery.h Patch looks fine though. Let me know if you want me to take it in via MFD. Otherwise: Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog