All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ankit Pandey <itsankitkp@gmail.com>
Cc: linux-kernel@vger.kernel.or, linux-staging@lists.linux.dev
Subject: Re: [PATCH] gdm724x: add SPDX License in gdm724x drivers (resend)
Date: Wed, 3 Nov 2021 09:25:22 +0100	[thread overview]
Message-ID: <YYJHcvuEtnGygCkk@kroah.com> (raw)
In-Reply-To: <CALbMxBz1A6V++jcBB1_oCUpYEnkVNnq2QUXBwpOhVyCXjB-Tnw@mail.gmail.com>

On Wed, Nov 03, 2021 at 01:49:27PM +0530, Ankit Pandey wrote:
> I am sorry, there was some issue with my git and I was looking at wrong
> history. I have fixed my git and checked drivers/staging/gdm724x/ for
> license issues. No such issue was present.
> Please ignore this patch.
> 
> Note: This was my first patch, I am still figuring out and learning things.
> 
> On Wed, 3 Nov, 2021, 1:20 am Greg KH, <gregkh@linuxfoundation.org> wrote:
> 
> > On Wed, Nov 03, 2021 at 12:28:44AM +0530, Ankit Kumar Pandey wrote:
> > > This work ensure SPDX-License convention is followed. License is taken
> > > from file gdm_mux.c present in drivers/staging/gdm724x.
> > >
> > > Signed-off-by: Ankit Kumar Pandey <itsankitkp@gmail.com>
> > > ---
> > >  drivers/staging/gdm724x/gdmulte.mod.c | 40 +++++++++++++++++++++++++++
> > >  1 file changed, 40 insertions(+)
> > >  create mode 100644 drivers/staging/gdm724x/gdmulte.mod.c
> >
> > Why are you adding this file to the kernel source tree?

This file should not have been in your git history at all, it is
automataically generated by the build.

So what tool was scanning it for a SPDX license?

thanks,

greg k-h

      parent reply	other threads:[~2021-11-03  8:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 18:58 [PATCH] gdm724x: add SPDX License in gdm724x drivers Ankit Kumar Pandey
2021-11-02 19:50 ` Greg KH
     [not found]   ` <CALbMxBz1A6V++jcBB1_oCUpYEnkVNnq2QUXBwpOhVyCXjB-Tnw@mail.gmail.com>
2021-11-03  8:25     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYJHcvuEtnGygCkk@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=itsankitkp@gmail.com \
    --cc=linux-kernel@vger.kernel.or \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.