From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9761C433F5 for ; Wed, 3 Nov 2021 23:10:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF762604D2 for ; Wed, 3 Nov 2021 23:10:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AF762604D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stwcx.xyz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hl2Z16ztGz2yNC for ; Thu, 4 Nov 2021 10:10:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=AuPjmGzB; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=Z7C25Y7Y; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=stwcx.xyz (client-ip=66.111.4.29; helo=out5-smtp.messagingengine.com; envelope-from=patrick@stwcx.xyz; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=AuPjmGzB; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=Z7C25Y7Y; dkim-atps=neutral Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hl2YD3Jfbz2xCy for ; Thu, 4 Nov 2021 10:10:07 +1100 (AEDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 23EF15C01F4 for ; Wed, 3 Nov 2021 19:10:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 03 Nov 2021 19:10:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=y8q1qPWog/e/mc+xOFDBHGIPjQo msyl4+PbPyMwO6SU=; b=AuPjmGzBMtHFqAIWUdN6ePXmMNEC42+NuRrSzrj8Wzk o8RFfHhrEN3CqRwEEW3yKOABDflnz5iK6vaefVmdD4RUM4auZtCOSLV7JIyjX79o tU8ew5EbPLUgteJTTQ2+niP8bOKS1vaRrwLBabCF/tIH8u+hBIPxQVxQtpgUa2b4 CRtBjhBH18w/wFXKDtJd0eZ25vpg+bS9XolcWWRt1kUHwWB0o9/2zSkdfX8BfZVx 47Ob6xpncmfvng1ow1iXUvHibbm6Y3A/lGbpamWfeSv7/fzyDrCeUqbawNrseuIt PfDQMIKdAburcyZkI8l8CppYpxT/4p6bzsXyqHDB3YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=y8q1qP Wog/e/mc+xOFDBHGIPjQomsyl4+PbPyMwO6SU=; b=Z7C25Y7Yp02QP87L+qK8E9 8/cdpjQuGm5Jn50OmvXqm8ZRv0HEKI3rZXeIHSJ4XYT+/LHky0/Z8vkw1DMxeMC9 0LQpKLCiVc2+BYJhZey+Gw6bJ12es5ePGwTOj6HRe2pSdx6CWdlpkqFlDXKvqBMo oaDoxMmdCQ0/YbKhJtte2MWu9ObCy3UcKE1PUJl54ZveKXiGyWcFL+1JgE82r/bR l4Gou2tA3aQsGzjdbpbZgkQAaCEKLKpIBEJQ/QuFICHfIol+0qSserMPH6pICx5C xj5C0GkJd8q4vpUEZw+eiz7owmCuVbYszn/pM/Burhn9ESpwfo9GK48Pz7P98o/g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdefgddthecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculddvfedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefrrghtrhhitghkucghihhllhhirghmshcuoehprghtrhhitghksehsth iftgigrdighiiiqeenucggtffrrghtthgvrhhnpeefiefgfeeigeelleeugeffgfevieeh jefhfefghfetgeffteegheefhfegteffgfenucffohhmrghinhepkhgvrhhnvghlrdhorh hgpdhgihhthhhusgdrtghomhdpohhpvghnsghmtgdqphhrohhjvggtthdrgiihiidpfhho rhhmrghtqdgtohguvgdrshhhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepphgrthhrihgtkhesshhtfigtgidrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 3 Nov 2021 19:10:04 -0400 (EDT) Date: Wed, 3 Nov 2021 18:10:02 -0500 From: Patrick Williams To: OpenBMC List Subject: Re: Additional linting in meta-layer repotest Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f3LaPvPhcB2e7PTS" Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --f3LaPvPhcB2e7PTS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 27, 2021 at 10:01:04AM -0500, Patrick Williams wrote: > Hello, >=20 > Ed recently added a test-phase called 'repotest'[1,2] in the openbmc/open= bmc > repository that allows us to perform sanity checking on commits at that l= evel > beyond a simple "does this compile". The initial checking he added was to > ensure that no new patches are added to the tree (in violation of our met= a-layer > coding guidelines). >=20 > I'm adding[3] additional capabilities to this script to enable linting in= the > repository. This will run `shellcheck` for shell scripts and `eslint` fo= r JSON > (Some might be unaware that Manoj added JSON linting with `eslint` as par= t of > our normal unit-test / formatting scripts[4] as well). Once this is in p= lace > new commits will fail CI if they add new shellscripts that violate `shell= check` > rules or JSON with invalid parsing. >=20 > Currently, there is quite an extensive list of 'exempted' scripts (~100) = which > already fail `shellcheck` rules. It is quite likely that some of these a= re > real bugs, so I would strongly urge if you are the maintainer of one of t= he > meta-layers holding an 'exempted' script that you look over the `shellche= ck` > failures. Hopefully over the next few months we will greatly reduce the = number > of scripts in this exemption list by cleaning up the issues. >=20 > 1. https://lore.kernel.org/openbmc/CAH2-KxDe6hR1V-Lz1k8cdD11jEquy4UhR4LfL= hg37E5EG42EJg@mail.gmail.com/ > 2. https://github.com/openbmc/openbmc/blob/master/meta-phosphor/scripts/r= un-repotest > 3. https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/48349 > 4. https://github.com/openbmc/openbmc-build-scripts/blob/master/scripts/f= ormat-code.sh#L31 > --=20 > Patrick Williams This is now merged. --=20 Patrick Williams --f3LaPvPhcB2e7PTS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmGDFsgACgkQqwNHzC0A wRl8Qw//XrJs85ESifvpNNfjlXrqXVKU4MwkbbzeBxhlN/JMVR2p0pKELRYACMNu gdZhv/pXdf93cugaYYUEDKqUaK1zCdLpqapBsjJEbDtRiAT2BA9t+I6IfFQJeJIn jIH2R5AKO8VM9ZKx4t7SUv0mkFW8lPxR6C69VVRMCKKeQXGt5iU1KzHGbviDDtNf mBeYp8P5+6CXs7q0MrbkhRDLfPZO7ErMPZNJjnrbxxGGqXo9j1LZJitzE71C3jdN Lf3gBO8vSpPIQGam+EmchdUsmjYAJ3TSYvpJTepXRDHFy37LPi8RtQM7HujKtt3S 8u43d03mbPICh7lVZUVy4OSzLLnupQinnBaYM3Qkwz1kKnHe1bQkaPL5FLla8l8X UCON4/neBZkw3RYRlQLtQFoqT3YbyGkTxjhtCbhDEidFQI1IOEDJWYmUe5hCTDyk fkEy5g2X6sKfhMyVJBqKWIFSDHN/NyoS6XuIx0Ewk5mvr1wD2BwqZMlGSYEYOjRz P3CUM8K69RKfEh/zvfb+NjSI8rvDVzhkb3KqJWxYomoxT+0ZQi5VUNEd8ccerxcl Cke0XlOsLwTphk0XI9lkff+8s9IN1acRfQsLn9yZuGco8UjpSoRrf0inmn3hgv/O nRc7BKiLHWyp2xsgqWefKnVGwQoeras62QfQ2EfsC0ZLv+mCYBo= =Pl85 -----END PGP SIGNATURE----- --f3LaPvPhcB2e7PTS--