All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH v4] ext4: add test for all ext4/ext3/ext2 mount options
Date: Wed, 3 Nov 2021 23:33:18 -0400	[thread overview]
Message-ID: <YYNUfvH52COSOnai@mit.edu> (raw)
In-Reply-To: <20211102105911.5790-1-lczerner@redhat.com>

> +_has_kernel_config()
> +{
> +	option=$1
> +	config="/lib/modules/$(uname -r)/build/.config"
> +	grep -qE "^${option}=[my]" $config
> +}

In my test infrastructure, /lib/modules/$Kver/build/.config doesn't
exist.  That's because I build the kernel without any modules, and
then launch kvm using its --kernel command-line option.  This really
helps with development velocity, since the developer doesn't need to
waste time installing the kernel, and/or building a kernel rpm or
dpkg.  Instead, kvm can just launch the kernel directly out of the
build tree:

/usr/bin/kvm ... --kernel /build/ext4/arch/x86/boot/bzImage ..

So it would be nice if _has_kernel_config also checks to see if
/proc/config.gz exists, and if so, tries to use it.

Thanks,

			       	   	 - Ted

  reply	other threads:[~2021-11-04  3:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 13:00 [PATCH] ext4: add test for all ext4/ext3/ext2 mount options Lukas Czerner
2021-10-18 16:36 ` Darrick J. Wong
2021-10-18 20:31   ` Lukas Czerner
2021-10-20 12:12 ` [PATCH v2] " Lukas Czerner
2021-10-24 16:31   ` Eryu Guan
2021-10-25  8:06     ` Lukas Czerner
2021-10-26  9:31   ` [PATCH v3] " Lukas Czerner
2021-10-31 14:16     ` Eryu Guan
2021-11-01 13:20       ` Lukas Czerner
2021-11-02 10:59     ` [PATCH v4] " Lukas Czerner
2021-11-04  3:33       ` Theodore Ts'o [this message]
2021-11-04  8:43         ` Lukas Czerner
2021-11-04 10:24       ` [PATCH v5] " Lukas Czerner
2021-11-04 17:16         ` Darrick J. Wong
2021-11-04 17:31           ` Lukas Czerner
2021-11-05  0:45             ` xuyang2018.jy
2021-11-05  3:45               ` Darrick J. Wong
2021-11-08  9:18               ` Lukas Czerner
2021-11-09  1:08                 ` xuyang2018.jy
2021-11-07 13:57         ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYNUfvH52COSOnai@mit.edu \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.