From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "Zhao, Yakui" <yakui.zhao@intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Nikula, Jani" <jani.nikula@intel.com>,
"Roper, Matthew D" <matthew.d.roper@intel.com>
Subject: Re: [PATCH] drm/i915: Remove memory frequency calculation
Date: Thu, 4 Nov 2021 09:14:10 +0100 [thread overview]
Message-ID: <YYOWUsUO8KZJm1b0@kroah.com> (raw)
In-Reply-To: <fb21fbc6b8b03ffa3df2f629112132664cccda4c.camel@intel.com>
On Thu, Nov 04, 2021 at 12:30:18AM +0000, Souza, Jose wrote:
> On Wed, 2021-11-03 at 10:46 +0100, Greg KH wrote:
> > On Mon, Nov 01, 2021 at 11:32:30AM -0700, José Roberto de Souza wrote:
> > > This memory frequency calculated is only used to check if it is zero,
> > > what is not useful as it will never actually be zero.
> > >
> > > Also the calculation is wrong, we should be checking other bit to
> > > select the appropriate frequency multiplier while this code is stuck
> > > with a fixed multiplier.
> > >
> > > So here dropping it as whole.
> > >
> > > v2:
> > > - Also remove memory frequency calculation for gen9 LP platforms
> > >
> > > Cc: <stable@vger.kernel.org> # 5.14-stable
> > > Cc: Yakui Zhao <yakui.zhao@intel.com>
> > > Cc: Matt Roper <matthew.d.roper@intel.com>
> > > Fixes: 5d0c938ec9cc ("drm/i915/gen11+: Only load DRAM information from pcode")
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> > > Link: https://patchwork.freedesktop.org/patch/msgid/20211013010046.91858-1-jose.souza@intel.com
> > > (cherry picked from commit 83f52364b15265aec47d07e02b0fbf4093ab8554)
> >
> > There is no such commit in Linus's tree.
> >
> > What commit is this that is being backported?
>
> It is on Linus's tree:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=83f52364b15265aec47d07e02b0fbf4093ab8554
Now it is, yes, sorry. It is not in a public release yet, which is why
my tools didn't catch this.
I guess you all want this in "now", so I'll go queue it up, but next
time, please give us a hint as to what is going on...
thanks,
greg k-h
next prev parent reply other threads:[~2021-11-04 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 13:05 FAILED: patch "[PATCH] drm/i915: Remove memory frequency calculation" failed to apply to 5.14-stable tree gregkh
2021-11-01 18:32 ` [PATCH] drm/i915: Remove memory frequency calculation José Roberto de Souza
2021-11-03 9:46 ` Greg KH
2021-11-04 0:30 ` Souza, Jose
2021-11-04 8:14 ` gregkh [this message]
2021-11-04 8:16 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYOWUsUO8KZJm1b0@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jani.nikula@intel.com \
--cc=jose.souza@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=stable@vger.kernel.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.