From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D70C3C433EF for ; Thu, 4 Nov 2021 09:36:36 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6574C60E9B for ; Thu, 4 Nov 2021 09:36:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6574C60E9B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stwcx.xyz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HlJS24BRjz2yHH for ; Thu, 4 Nov 2021 20:36:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=izQZ6K6/; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=kAR//C+M; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=stwcx.xyz (client-ip=66.111.4.28; helo=out4-smtp.messagingengine.com; envelope-from=patrick@stwcx.xyz; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=izQZ6K6/; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=kAR//C+M; dkim-atps=neutral Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HlJRF5tslz2xWt for ; Thu, 4 Nov 2021 20:35:53 +1100 (AEDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D697D5C0189; Thu, 4 Nov 2021 05:35:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 04 Nov 2021 05:35:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ZRcXIy86o/grExussoPo3dK/31N VAM3c7wAqQpNZV0A=; b=izQZ6K6/XTPOVHSj/uy3xk+bqAadeNe9BNaWu+I05BJ umkClinJRe36HUfS9Ecxl6GD4ZTQoGYQlLqCUFSWvQgrEN2rUA5/XQ4rzopQSMei 2d8Nf4RnzC+u+4aGKa+NwAZfODqsG2nXz49fwyzKd2iizFSUgvBImLksnkjfbs1O ERI1VbM1xy0OTALDcPbcCLr1IudMz1oBtwbzpDpNfAZuK8S9W2ZO5aJdu5J+3uYa LJBAAOqTOnBCAOpkGJejjpW2ONmyzks1Eh2xwtur+c16kR3XFHSx2yvEzGSINF8S YRNNoBZN85hsuWZg5fj6hpf4Kv2+oWfbCw8Cnl2VdLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ZRcXIy 86o/grExussoPo3dK/31NVAM3c7wAqQpNZV0A=; b=kAR//C+MWKvXFc9+eEESmK H7DLLNpnDwap1HKaex9djlLy04p7qepYVu3xx9pajYvmiWybJE8aqHe3lsCQ/xoL UKZytI3e8tSJQaWbsQ6By2btyeWershIVBN4LlLu03vDORseN0ciHfk6FqUPd3/l 2LhHMByMno9h8jiCG3eHvim9G3X4ENbGEB2DFojTHxv3QNVRPB4s4S6/lAvvQho9 uDrxX0E85LSaDk2XAoWH5esIb+IqQhd7N70Q2EkCf49UwW7M65kSBKzYt13fRj4Q D7ZtlL1a/3EyGiLoJkJaTr1k2oudCDmMTzUqtXKcszT+uWd0sA1GemZCI3ZkkNtQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeggddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdejtddmnecujfgurhepfffhvf fukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefrrghtrhhitghkucghihhllhhi rghmshcuoehprghtrhhitghksehsthiftgigrdighiiiqeenucggtffrrghtthgvrhhnpe ekudeutdefiefhheefheefvdejueejieektdetheelvdfhleehkeegvdeiveekhfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehprghtrhhitg hksehsthiftgigrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Nov 2021 05:35:50 -0400 (EDT) Date: Thu, 4 Nov 2021 04:35:48 -0500 From: Patrick Williams To: Kun Zhao Subject: Re: phosphor-logging Create API with Resolution Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SYeWoM1tdSWlsGiF" Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "openbmc@lists.ozlabs.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --SYeWoM1tdSWlsGiF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 03, 2021 at 11:53:17PM +0000, Kun Zhao wrote: > Hi Team, >=20 > We have a requirement to provide the value of Resolution property at the = time of log creation with phosphor-logging Create API. But current Create()= API doesn=E2=80=99t support Resolution as a parameter, we have to do two s= teps (create entry, set-property of Resolution of this entry) for it. > Any suggestions? Modify Create() API or add a new CreateWithResolution() = API? I suspect we're going to have other use-cases come up going forward where o= ther people want to fill in other properties, so having CreateWithNNN APIs sounds like it'll start having clutter. Can we enhance the handling of the AdditionalData field to take fully-quali= fied property names and place those in the appropriate property at create time, rather than placing them in AdditionalData? What I mean by this is that if= you pass a key of "xyz.openbmc_project.Logging.Entry.Resolution" it will place = the value in the ...Entry.Resolution property at creation. Any non-FQPN will s= tay in AdditionalData. --=20 Patrick Williams --SYeWoM1tdSWlsGiF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmGDqXQACgkQqwNHzC0A wRlK1w/+MeEQL2thUZU9IZt0+IVv4n74i43sIL25iyXrsCdLWC88TNz+mjXYomiu TpFhL6pKiuNDaegef9t2BM1QYo8QIzWIr9ppOhX9c2j3RI9gV//Wz8XjXkfJ5Xoc eU8oNjLh5hw2/GljMIC24XDJ9NZCyqKyuAkUp9RXA+WrpzfKzZIQBRKmTubWlMpK D6KLgRNsijgLrf16qMml2UyOqevZiLrGdSlyJ+tf62moAjhoq2elrlgjQm0tXsWV bBc60ScpX8UHQsLcohVJCiO3ELhkR5ZDSkRy27jrxZCyDrnBpw0jYCubpLQL7Aa2 vJmm8aO8aUecBPuZxLKkEcGfXHa8/pLIf7BEnqiSYcJS+rn93bfUn2stn8OY0yZk 06tPTd0f0Pb9Z+5h05keS3u7ToMVDeyj7rMMxV2yeFNVAeNCvIZCKERrbxQtgKol biEP13K2BgCMoHtA8MPy7bafjTr6lSA12kOJLYs64Xck0tOza1OiUYc9sk+9yKFP C/h57F3PE+ggAiKHnzhEmBJLcCGE78O2R5OR7dOWSavqo3g9zwmg6OrXcmTvYDTu HWcZIWyUxoqExbkwR2zOxriBV5+bHd82+RLhFtAiOzstndEM803QolnpPAYxUt4p TVmVcJRVhysavwtlz9q4iCnItm1PthVz4AfVHpRwLTBPZ29K0kk= =e1+M -----END PGP SIGNATURE----- --SYeWoM1tdSWlsGiF--