From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-arch <linux-arch@vger.kernel.org>,
Ira Weiny <ira.weiny@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: flush_dcache_page vs kunmap_local
Date: Thu, 4 Nov 2021 18:20:37 +0000 [thread overview]
Message-ID: <YYQkdUcSLFPlzGFH@shell.armlinux.org.uk> (raw)
In-Reply-To: <YYQgvTn2NQdZK2Ku@arm.com>
On Thu, Nov 04, 2021 at 06:04:45PM +0000, Catalin Marinas wrote:
> The cachetlb.rst doc states the two cases where flush_dcache_page()
> should be called:
>
> 1. After writing to a page cache page (that's what we need on arm64 for
> the I-cache).
>
> 2. Before reading from a page cache page and user mappings potentially
> exist. I think arm32 ensures the D-cache user aliases are coherent
> with the kernel one (added rmk to confirm).
Yes, where necessary, we flush the user aliases in flush_dcache_page().
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-11-04 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 15:00 flush_dcache_page vs kunmap_local Matthew Wilcox
2021-11-04 15:30 ` Linus Torvalds
2021-11-04 16:54 ` Catalin Marinas
2021-11-04 17:08 ` Linus Torvalds
2021-11-04 18:04 ` Catalin Marinas
2021-11-04 18:20 ` Russell King (Oracle) [this message]
2021-11-04 18:23 ` Linus Torvalds
2021-11-05 19:40 ` Catalin Marinas
2021-11-04 18:38 ` Matthew Wilcox
2021-11-04 21:02 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYQkdUcSLFPlzGFH@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=hch@lst.de \
--cc=ira.weiny@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.