From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Song Liu <songliubraving@fb.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jiri Olsa <jolsa@kernel.org>, bpf <bpf@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: perf build broken looking for bpf/{libbpf,bpf}.h after merge with upstream
Date: Thu, 4 Nov 2021 17:42:38 -0300 [thread overview]
Message-ID: <YYRFvpRjdKxJoydK@kernel.org> (raw)
In-Reply-To: <CAM9d7cg9rXKUdEsdGUBSemzSrwE8XsyQtjCM=zT+8P+gs10n=Q@mail.gmail.com>
Em Thu, Nov 04, 2021 at 01:33:20PM -0700, Namhyung Kim escreveu:
> On Thu, Nov 4, 2021 at 11:13 AM Song Liu <songliubraving@fb.com> wrote:
> > > On Nov 4, 2021, at 11:11 AM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > Em Thu, Nov 04, 2021 at 10:56:26AM -0700, Andrii Nakryiko escreveu:
> > >> On the side note, why BUILD_BPF_SKEL=1 is not a default, we might have
> > >> caught this sooner. Is there any reason not to flip the default?
> > > I asked Song in the past about this, and asked again on another reply to
> > > this thread, I think it should be the default.
> > > Song, Namhyung? You're the skel guys (so far) :-)
> > Yeah, let's make it default.
> Then it'd require 'clang' for the perf build. Maybe we can check
> the availability of the compiler and disable it back if not.
Right, an extra feature check.
- Arnaldo
prev parent reply other threads:[~2021-11-04 20:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 17:37 perf build broken looking for bpf/{libbpf,bpf}.h after merge with upstream Arnaldo Carvalho de Melo
2021-11-04 17:47 ` Andrii Nakryiko
2021-11-04 18:09 ` Arnaldo Carvalho de Melo
2021-11-04 18:15 ` Quentin Monnet
2021-11-04 20:15 ` Arnaldo Carvalho de Melo
2021-11-04 20:45 ` Arnaldo Carvalho de Melo
2021-11-05 2:03 ` Quentin Monnet
2021-11-04 18:10 ` Arnaldo Carvalho de Melo
2021-11-04 17:49 ` Arnaldo Carvalho de Melo
2021-11-04 17:56 ` Andrii Nakryiko
2021-11-04 18:11 ` Arnaldo Carvalho de Melo
2021-11-04 18:13 ` Song Liu
2021-11-04 20:33 ` Namhyung Kim
2021-11-04 20:42 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYRFvpRjdKxJoydK@kernel.org \
--to=acme@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.