From: Sean Christopherson <seanjc@google.com>
To: Peter Gonda <pgonda@google.com>
Cc: kvm@vger.kernel.org, Marc Orr <marcorr@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Rientjes <rientjes@google.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V11 2/5] KVM: SEV: Add support for SEV intra host migration
Date: Thu, 4 Nov 2021 23:04:55 +0000 [thread overview]
Message-ID: <YYRnF00iE15hd5UV@google.com> (raw)
In-Reply-To: <YYRZq+Zt52FSyjVW@google.com>
On Thu, Nov 04, 2021, Sean Christopherson wrote:
> On Thu, Oct 21, 2021, Peter Gonda wrote:
> > + if (!sev_guest(source_kvm) || sev_es_guest(source_kvm)) {
> > + ret = -EINVAL;
> > + goto out_source;
> > + }
> > + ret = sev_lock_vcpus_for_migration(kvm);
> > + if (ret)
> > + goto out_dst_vcpu;
> > + ret = sev_lock_vcpus_for_migration(source_kvm);
> > + if (ret)
> > + goto out_source_vcpu;
> > +
> > + sev_migrate_from(dst_sev, &to_kvm_svm(source_kvm)->sev_info);
> > + kvm_for_each_vcpu(i, vcpu, source_kvm) {
>
> Braces not needed.
>
> > + kvm_vcpu_reset(vcpu, /* init_event= */ false);
...
> That way the source vCPUs don't need to be locked
Scratch that particular idea, I keep forgetting the SEV-ES support needs to lock
the source vCPUs to transfer state.
next prev parent reply other threads:[~2021-11-04 23:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 17:42 [PATCH 0/5 V11] Add AMD SEV and SEV-ES intra host migration support Peter Gonda
2021-10-21 17:42 ` [PATCH 1/5 V11] KVM: SEV: Refactor out sev_es_state struct Peter Gonda
2021-11-04 20:06 ` Sean Christopherson
2021-10-21 17:43 ` [PATCH V11 2/5] KVM: SEV: Add support for SEV intra host migration Peter Gonda
2021-11-04 22:07 ` Sean Christopherson
2021-11-04 23:04 ` Sean Christopherson [this message]
2021-11-09 15:19 ` Peter Gonda
2021-11-11 15:17 ` Paolo Bonzini
2021-11-11 15:18 ` Paolo Bonzini
2021-10-21 17:43 ` [PATCH V11 3/5] KVM: SEV: Add support for SEV-ES " Peter Gonda
2021-11-04 23:33 ` Sean Christopherson
2021-10-21 17:43 ` [PATCH V11 4/5] selftest: KVM: Add open sev dev helper Peter Gonda
2021-11-05 22:47 ` Sean Christopherson
2021-10-21 17:43 ` [PATCH V11 5/5] selftest: KVM: Add intra host migration tests Peter Gonda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYRnF00iE15hd5UV@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dgilbert@redhat.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.