From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C86C433EF for ; Sun, 7 Nov 2021 10:13:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2654613D2 for ; Sun, 7 Nov 2021 10:13:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F2654613D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 620786E8FB; Sun, 7 Nov 2021 10:13:03 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF9456E8FB for ; Sun, 7 Nov 2021 10:13:01 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 51ee54a3-3fb3-11ec-9c3f-0050568c148b; Sun, 07 Nov 2021 10:13:14 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 6A2E8194B7F; Sun, 7 Nov 2021 11:12:58 +0100 (CET) Date: Sun, 7 Nov 2021 11:12:56 +0100 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Yauhen Kharuzhy Subject: Re: [PATCH] drm: panel-orientation-quirks: Add quirk for the Lenovo Yoga Book X91F/L Message-ID: References: <20211106130227.11927-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hans de Goede , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Yauhen, On Sun, Nov 07, 2021 at 12:59:11AM +0300, Yauhen Kharuzhy wrote: > On Sat, Nov 06, 2021 at 02:02:27PM +0100, Hans de Goede wrote: > > The Lenovo Yoga Book X91F/L uses a panel which has been mounted > > 90 degrees rotated. Add a quirk for this. > > Tested on my Yoga Book, works. Great - and then it would be prudent that you acknowledge this with: Tested-by: Yauhen Kharuzhy A "Tested-by:" is in many cases better than an Acked-by: because you actually applied the patch, build it and verified that it works. Where an Acked-by: is just to say that you have looked at the patch and agrees with the patch. So a Tested-by: gives you the credit you deserve here. Sam