From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, dsahern@kernel.org,
Eugene Crosser <crosser@average.org>,
Lahav Schlesinger <lschlesinger@drivenets.com>
Subject: Re: [PATCH nf] selftests: netfilter: add a vrf+conntrack testcase
Date: Mon, 8 Nov 2021 11:25:36 +0100 [thread overview]
Message-ID: <YYj7IJVgKAibNl3G@salvia> (raw)
In-Reply-To: <20211018123813.17248-1-fw@strlen.de>
On Mon, Oct 18, 2021 at 02:38:13PM +0200, Florian Westphal wrote:
> Rework the reproducer for the vrf+conntrack regression reported
> by Eugene into a selftest and also add a test for ip masquerading
> that Lahav fixed recently.
>
> With net or net-next tree, the first test fails and the latter
> two pass.
>
> With 09e856d54bda5f28 ("vrf: Reset skb conntrack connection on VRF rcv")
> reverted first test passes but the last two fail.
>
> A proper fix needs more work, for time being a revert seems to be
> the best choice, snat/masquerade did not work before the fix.
Applied, thanks.
> Link: https://lore.kernel.org/netdev/378ca299-4474-7e9a-3d36-2350c8c98995@gmail.com/T/#m95358a31810df7392f541f99d187227bc75c9963
> Reported-by: Eugene Crosser <crosser@average.org>
> Cc: Lahav Schlesinger <lschlesinger@drivenets.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Lahav, it would be nice if you could check if this
> is a correct test of the scenario that you fixed with
> 09e856d54bda5f28. Thanks!
No news from Lahav.
prev parent reply other threads:[~2021-11-08 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 12:38 [PATCH nf] selftests: netfilter: add a vrf+conntrack testcase Florian Westphal
2021-11-08 10:25 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYj7IJVgKAibNl3G@salvia \
--to=pablo@netfilter.org \
--cc=crosser@average.org \
--cc=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=lschlesinger@drivenets.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.