From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5FF0C433F5 for ; Mon, 8 Nov 2021 12:22:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 958D061059 for ; Mon, 8 Nov 2021 12:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235357AbhKHMYy (ORCPT ); Mon, 8 Nov 2021 07:24:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:35818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232912AbhKHMYx (ORCPT ); Mon, 8 Nov 2021 07:24:53 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2534160FDA; Mon, 8 Nov 2021 12:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636374129; bh=Yl2R0y7pxCQ0xb5hoZzKXpXsuW1sVQgECOa9MTTn6z4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LSFYRik9NDCCZIQ2CvGfpO+twDXA6MvDR2lhAd6iyB7KWbKYQNR5Nk4/QV39exvK8 i7SBR5KTJb7mxQFTFfJwrBtvREpLvx5K/KJ35aduaWq89RLLuHTkhJ6uqXnUWCFjO9 egdJHXLLrzPSqaCRpq+tmMC4GavLNIDFC7oJapm8= Date: Mon, 8 Nov 2021 13:22:07 +0100 From: Greg KH To: Ajay Garg Cc: andy@kernel.org, Kees Cook , akpm@linux-foundation.org, adobriyan@gmail.com, Nick Desaulniers , Linux Kernel Mailing List , linux-hardening@vger.kernel.org Subject: Re: RFC for a new string-copy function, using mixtures of strlcpy and strscpy Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Mon, Nov 08, 2021 at 08:46:01AM +0530, Ajay Garg wrote: > Hello everyone. > > I recently came across the functions strlcpy and strscpy, and it seems > something is missing/unclean. > > This email is a RFC for another function, by the name "strlscpy". Wait, why? We have recently added new string copy functions to resolve the type of issues you have pointed out. The kernel is not yet converted to use them, so why add yet-another-function that also is not used? I think you should work with the functions we have _first_ and help convert the kernel to use them, before adding another one please. thanks, greg k-h