From: Andrew Lunn <andrew@lunn.ch>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: "Marek Behún" <kabel@kernel.org>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>, "Pavel Machek" <pavel@ucw.cz>,
"John Crispin" <john@phrozen.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [RFC PATCH 2/6] leds: permit to declare supported offload triggers
Date: Mon, 8 Nov 2021 14:48:29 +0100 [thread overview]
Message-ID: <YYkqrbenDPpck2yO@lunn.ch> (raw)
In-Reply-To: <YYhUGNs1I0RWriln@Ansuel-xps.localdomain>
On Sun, Nov 07, 2021 at 11:32:56PM +0100, Ansuel Smith wrote:
> On Sun, Nov 07, 2021 at 11:06:24PM +0100, Marek Behún wrote:
> > On Sun, 7 Nov 2021 18:57:14 +0100
> > Ansuel Smith <ansuelsmth@gmail.com> wrote:
> >
> > > With LEDs that can be offload driven, permit to declare supported triggers
> > > in the dts and add them to the cled struct to be used by the related
> > > offload trigger. This is particurally useful for phy that have support
> > > for HW blinking on tx/rx traffic or based on the speed link.
> > >
> > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> >
> > NAK. The device-tree shouldn't define this, only the LED's function as
> > designated by the manufacturer of the device.
> >
> > Marek
>
> Sure I will add a way to ask the led driver if the trigger is supported
> and report it.
Yes, you need some way for the PHY/MAC driver to enumerate what it can
do.
I've not looked at v2 yet...
Andrew
next prev parent reply other threads:[~2021-11-08 13:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 17:57 [RFC PATCH 0/6] Adds support for PHY LEDs with offload triggers Ansuel Smith
2021-11-07 17:57 ` [RFC PATCH 1/6] leds: trigger: add API for HW offloading of triggers Ansuel Smith
2021-11-07 22:52 ` Randy Dunlap
2021-11-07 22:59 ` Ansuel Smith
2021-11-07 17:57 ` [RFC PATCH 2/6] leds: permit to declare supported offload triggers Ansuel Smith
2021-11-07 22:06 ` Marek Behún
2021-11-07 22:32 ` Ansuel Smith
2021-11-08 13:48 ` Andrew Lunn [this message]
2021-11-07 17:57 ` [RFC PATCH 3/6] leds: add function to configure offload leds Ansuel Smith
2021-11-07 22:45 ` Randy Dunlap
2021-11-07 17:57 ` [RFC PATCH 4/6] leds: trigger: add offload-phy-activity trigger Ansuel Smith
2021-11-07 22:10 ` Marek Behún
2021-11-07 22:43 ` Ansuel Smith
2021-11-08 10:00 ` Marek Behún
2021-11-07 22:42 ` Randy Dunlap
2021-11-07 22:46 ` Ansuel Smith
2021-11-07 17:57 ` [RFC PATCH 5/6] net: dsa: qca8k: add LEDs support Ansuel Smith
2021-11-07 22:39 ` Randy Dunlap
2021-11-07 17:57 ` [RFC PATCH 6/6] dt-bindings: net: dsa: qca8k: add LEDs definition example Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYkqrbenDPpck2yO@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.