From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB10C433EF for ; Mon, 8 Nov 2021 17:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C410261502 for ; Mon, 8 Nov 2021 17:06:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240449AbhKHRIu (ORCPT ); Mon, 8 Nov 2021 12:08:50 -0500 Received: from mail-ot1-f43.google.com ([209.85.210.43]:37581 "EHLO mail-ot1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240435AbhKHRIt (ORCPT ); Mon, 8 Nov 2021 12:08:49 -0500 Received: by mail-ot1-f43.google.com with SMTP id v40-20020a056830092800b0055591caa9c6so26571202ott.4; Mon, 08 Nov 2021 09:06:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+wQZvNgyyjn3+v8l34ysdaksISh5LnqUaxH3QVKQ1xw=; b=I8p2I/RHrX5ktMbVMimY3tdkhs9UkVsSUQIyDqOqzilLm9O0qfWSPiGpZ5W8AI2gcR wzoicZrt21ix8CijJUuTI0ZUZWK/Jm9CPRKYq7Hw5/3ha8ajLzT/UoA9xF1EaD5k7G9c 7KO/uvGjLDMUmwtv+vHwfae65psYwlFMxksjvk5PrA7y3eZAb9QzA3tF9gNOGdGrcDpo u19ksL6XGRsKJxOxouF8KMryEblHfISZZ4YNfKhv9ENzK0VkLfKOcyqWQ1f2nU4QYgBT SPVJACgHTzBCz0YIhlzBNkD70Ah4Eo8jKNuVYvfAoPS2McZLH/YUMdGd9cTlhPHpZ8zn LyxQ== X-Gm-Message-State: AOAM530XH9Siwd/CYc2xKrMCt/88HT5ZtOYopgMRXqiWqWuGO5K3kfEa Lnzm+8jkIE313EwZzIj3Eg== X-Google-Smtp-Source: ABdhPJyE2m9Bd0mTaoOq+L1k+wveMzvoclq85f8PRR1u9eZbzhJbadk37zweFJPvLaJOuibGv4aDZw== X-Received: by 2002:a9d:5c2:: with SMTP id 60mr457729otd.104.1636391164189; Mon, 08 Nov 2021 09:06:04 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id q29sm5703534oof.38.2021.11.08.09.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 09:06:03 -0800 (PST) Received: (nullmailer pid 3517392 invoked by uid 1000); Mon, 08 Nov 2021 17:06:01 -0000 Date: Mon, 8 Nov 2021 11:06:01 -0600 From: Rob Herring To: Jesse Taube List-Id: Cc: linux-imx@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, gregkh@linuxfoundation.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com, adrian.hunter@intel.com, jirislaby@kernel.org, giulio.benetti@benettiengineering.com, nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v2 05/13] dt-bindings: clock: imx: Add documentation for i.MXRT clock Message-ID: References: <20211102225701.98944-1-Mr.Bossman075@gmail.com> <20211102225653.W9X4uTuBfjTBCe44PlQdYj5pRnczkEUmvmbnCVeKkeM@z> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211102225653.W9X4uTuBfjTBCe44PlQdYj5pRnczkEUmvmbnCVeKkeM@z> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, Nov 02, 2021 at 06:56:53PM -0400, Jesse Taube wrote: > From: Jesse Taube > > Add DT binding documentation for i.MXRT clock driver. > > Cc: Giulio Benetti > Signed-off-by: Jesse Taube > --- > V1->V2: > * Replace macros with values > --- > .../bindings/clock/imxrt-clock.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/imxrt-clock.yaml > > diff --git a/Documentation/devicetree/bindings/clock/imxrt-clock.yaml b/Documentation/devicetree/bindings/clock/imxrt-clock.yaml > new file mode 100644 > index 000000000000..4e92f79cf707 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imxrt-clock.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/imxrt-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Clock bindings for Freescale i.MXRT > + > +maintainers: > + - Giulio Benetti > + - Jesse Taube > + > +description: | > + The clock consumer should specify the desired clock by having the clock > + ID in its "clocks" phandle cell. See include/dt-bindings/clock/imxrt*-clock.h > + for the full list of i.MXRT clock IDs. blank line > +properties: > + compatible: > + oneOf: Don't need oneOf for a single entry. > + - enum: > + - fsl,imxrt1050-ccm > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + > + clock-names: > + minItems: 1 You have to define the name. > + > + '#clock-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - '#clock-cells' > + > +additionalProperties: false > + > +examples: > + - | > + anatop: anatop@400d8000 { > + compatible = "fsl,imxrt-anatop"; > + reg = <0x400d8000 0x4000>; > + }; Not relevant to the example. > + > + ccm@400fc000 { > + compatible = "fsl,imxrt1050-ccm"; > + reg = <0x400fc000 0x4000>; > + interrupts = <95>,<96>; > + clocks = <&osc>; > + clock-names = "osc"; > + #clock-cells = <1>; > + }; > + > + gpt: timer@401ec000 { Drop unused labels. > + compatible = "fsl,imx53-gpt", "fsl,imx31-gpt"; Probably should be: "fsl,imxrt1050-gpt", "fsl,imx31-gpt" Unless there's same features/quirks as the MX53 version? > + reg = <0x401ec000 0x4000>; > + interrupts = <100>; > + clocks = <&clks 3>; > + clock-names = "per"; > + }; > -- > 2.33.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5A1C433EF for ; Mon, 8 Nov 2021 17:07:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4699060EE9 for ; Mon, 8 Nov 2021 17:07:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4699060EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aXwiwjvk2v3VLyVEAMlcgE3y/xT7tfRMWXAXm9FXdk8=; b=f3bXqz8UiGofOy nDggWR48k+ttrf31/ByuTnqZPAVbAFISRYjs0LqEgcJxwY6BU6fdQ4farr/vDyNL57Swsxr53x5dJ U2wgAF9uAnJ5rNo61JoMgAFh4suUfbiA2VQnfw9ojjzWdQt10A0FCfUzfvW5LkI6Qji2qL1Y7Tnh9 awYFI3gmUceNVQhvXB2MJpmnoVYMwbtpjVjG/QeqMSt9L/Bn3Nv25SM11XKQ8hTzi9PGcl0db/Pyh bBbecSZ3nWiKfOh0/3eWppOkbmqN+PEKPMh3Q7n7YYZVh25JASBEj1qZ6Xk2oR7g4MnhxvPyQSMEl TD0ZwlWLw4HnHFS9Bonw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk85y-00H23F-Sv; Mon, 08 Nov 2021 17:06:11 +0000 Received: from mail-ot1-f50.google.com ([209.85.210.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk85t-00H21V-Lo for linux-arm-kernel@lists.infradead.org; Mon, 08 Nov 2021 17:06:09 +0000 Received: by mail-ot1-f50.google.com with SMTP id h16-20020a9d7990000000b0055c7ae44dd2so10541676otm.10 for ; Mon, 08 Nov 2021 09:06:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+wQZvNgyyjn3+v8l34ysdaksISh5LnqUaxH3QVKQ1xw=; b=sRExyYH04X2Jgl/Qw/4wjm980awm9Gl+5LxoygKByeMBn8+7VOLGcfG1Fd11uGauHy B5nKC01xhGTwzixxhoWu++ESfD++specmYONtZ/5qdhfFodk05M/S8js0FEj51XCysCo NM7b4wY7FbylXMoABSN8cXqxjhO85NBrOgmBFDzUmJMiQ32FmuTVtbPx6vor8M5v1vG3 nTbo77j28x6hnHzm/ievdsHnDkxix7VPild/UsAZjH+4fuwbeXo8NwxfhTHd3tufRzdx XaJmdji6LtSw7UuFt1XDERwUKAp63pqJQ91yLRcbruej3GjvrcB3LQSOX5FuhkivocEu cIAg== X-Gm-Message-State: AOAM531W9U79AcFZp1hcD0B/w7jJho44n3rng9DizkSMvjuFc+69ZKWJ dRyMuOOW+21XC0O2PdgPSA== X-Google-Smtp-Source: ABdhPJyE2m9Bd0mTaoOq+L1k+wveMzvoclq85f8PRR1u9eZbzhJbadk37zweFJPvLaJOuibGv4aDZw== X-Received: by 2002:a9d:5c2:: with SMTP id 60mr457729otd.104.1636391164189; Mon, 08 Nov 2021 09:06:04 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id q29sm5703534oof.38.2021.11.08.09.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 09:06:03 -0800 (PST) Received: (nullmailer pid 3517392 invoked by uid 1000); Mon, 08 Nov 2021 17:06:01 -0000 Date: Mon, 8 Nov 2021 11:06:01 -0600 From: Rob Herring To: Jesse Taube List-Id: Cc: linux-imx@nxp.com, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, ulf.hansson@linaro.org, aisheng.dong@nxp.com, stefan@agner.ch, linus.walleij@linaro.org, gregkh@linuxfoundation.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, abel.vesa@nxp.com, adrian.hunter@intel.com, jirislaby@kernel.org, giulio.benetti@benettiengineering.com, nobuhiro1.iwamatsu@toshiba.co.jp, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v2 05/13] dt-bindings: clock: imx: Add documentation for i.MXRT clock Message-ID: References: <20211102225701.98944-1-Mr.Bossman075@gmail.com> <20211102225653.W9X4uTuBfjTBCe44PlQdYj5pRnczkEUmvmbnCVeKkeM@z> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211102225653.W9X4uTuBfjTBCe44PlQdYj5pRnczkEUmvmbnCVeKkeM@z> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_090605_741774_82A30952 X-CRM114-Status: GOOD ( 22.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20211108170601.gz8EWaL5n8GtyBar0_70NUaA0HSfaquyj_u1x2kpaUg@z> On Tue, Nov 02, 2021 at 06:56:53PM -0400, Jesse Taube wrote: > From: Jesse Taube > > Add DT binding documentation for i.MXRT clock driver. > > Cc: Giulio Benetti > Signed-off-by: Jesse Taube > --- > V1->V2: > * Replace macros with values > --- > .../bindings/clock/imxrt-clock.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/imxrt-clock.yaml > > diff --git a/Documentation/devicetree/bindings/clock/imxrt-clock.yaml b/Documentation/devicetree/bindings/clock/imxrt-clock.yaml > new file mode 100644 > index 000000000000..4e92f79cf707 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/imxrt-clock.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/imxrt-clock.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Clock bindings for Freescale i.MXRT > + > +maintainers: > + - Giulio Benetti > + - Jesse Taube > + > +description: | > + The clock consumer should specify the desired clock by having the clock > + ID in its "clocks" phandle cell. See include/dt-bindings/clock/imxrt*-clock.h > + for the full list of i.MXRT clock IDs. blank line > +properties: > + compatible: > + oneOf: Don't need oneOf for a single entry. > + - enum: > + - fsl,imxrt1050-ccm > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + > + clock-names: > + minItems: 1 You have to define the name. > + > + '#clock-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - '#clock-cells' > + > +additionalProperties: false > + > +examples: > + - | > + anatop: anatop@400d8000 { > + compatible = "fsl,imxrt-anatop"; > + reg = <0x400d8000 0x4000>; > + }; Not relevant to the example. > + > + ccm@400fc000 { > + compatible = "fsl,imxrt1050-ccm"; > + reg = <0x400fc000 0x4000>; > + interrupts = <95>,<96>; > + clocks = <&osc>; > + clock-names = "osc"; > + #clock-cells = <1>; > + }; > + > + gpt: timer@401ec000 { Drop unused labels. > + compatible = "fsl,imx53-gpt", "fsl,imx31-gpt"; Probably should be: "fsl,imxrt1050-gpt", "fsl,imx31-gpt" Unless there's same features/quirks as the MX53 version? > + reg = <0x401ec000 0x4000>; > + interrupts = <100>; > + clocks = <&clks 3>; > + clock-names = "per"; > + }; > -- > 2.33.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel