From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Wed, 10 Nov 2021 09:10:46 +0100 Subject: [PATCH] serial: 8250_aspeed_vuart: Replace snprintf in show functions with sysfs_emit In-Reply-To: <20211110024028.135887-1-yao.jing2@zte.com.cn> References: <20211110024028.135887-1-yao.jing2@zte.com.cn> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Nov 10, 2021 at 02:40:28AM +0000, cgel.zte at gmail.com wrote: > From: Jing Yao > > coccicheck complains about the use of snprintf() in sysfs show > functions: > WARNING use scnprintf or sprintf > > Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more > sense. Same subject and changelog comments as the staging driver change you sent in :( From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F10C433EF for ; Wed, 10 Nov 2021 08:10:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EA3561052 for ; Wed, 10 Nov 2021 08:10:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbhKJINg (ORCPT ); Wed, 10 Nov 2021 03:13:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:35052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbhKJINg (ORCPT ); Wed, 10 Nov 2021 03:13:36 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 79C0660FDA; Wed, 10 Nov 2021 08:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636531849; bh=u8b5cf1EBSxtufFdQN4PMhOxgUC210Wh/YSOnRXF7Ys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LUSdi1XyLhDhnWPmsceU86FDly+91QHJNd/3k4DSapQq89WuSlWwCiqsP5H4o4UGh V66NAEfPp3klHGoHxxIM7tHbiZX0VESNXIOZwNDtTgFYXUcNXvCrQyxrL6KY9vvAgY k9yX+YIXp/h34xymLRmPfTIQdP3qeg21CUqz7i2Q= Date: Wed, 10 Nov 2021 09:10:46 +0100 From: Greg KH To: cgel.zte@gmail.com Cc: johan@kernel.org, jirislaby@kernel.org, joel@jms.id.au, andrew@aj.id.au, zev@bewilderbeest.net, yao.jing2@zte.com.cn, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zeal Robot Subject: Re: [PATCH] serial: 8250_aspeed_vuart: Replace snprintf in show functions with sysfs_emit Message-ID: References: <20211110024028.135887-1-yao.jing2@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211110024028.135887-1-yao.jing2@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, Nov 10, 2021 at 02:40:28AM +0000, cgel.zte@gmail.com wrote: > From: Jing Yao > > coccicheck complains about the use of snprintf() in sysfs show > functions: > WARNING use scnprintf or sprintf > > Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more > sense. Same subject and changelog comments as the staging driver change you sent in :( From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3F3C433FE for ; Wed, 10 Nov 2021 08:12:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D36E461052 for ; Wed, 10 Nov 2021 08:12:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D36E461052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4BLBLXhccm+ToEePKzPldTHLNrE46MHB+KgyQgosOvM=; b=zrypIOEZrGdo7g 5QXhLVo7Jx6hkS/4hbRn1UFVwmgCSAfOO2iWnEzPQmE02FEFjc+5QH1t+YzOYQ0XxHq6HMW2SsRy8 wGprCMFm6EWbrmlYY+nArWIgowW75J4bd3timhMfM84oL+ofqDtx3pVZZFkAkR50QeSDQNVUxFiK1 yh1wIXt9V2yLqBP6JV+HHTBwKWo4gb+xHI73aY2IXa9lXwrOnt/Ej2Y0ksIvbK60NXx8OpIMPe+dw m1NJrEl8UuKIUCgfOK4VO0QGqZZ8xVP3eSWz9zX8GL51o+yypNJnghYbyH41KfF8WRByAny77un9h 3oMio5DzC08FKubslX0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkih2-004l9r-Ub; Wed, 10 Nov 2021 08:10:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkigz-004l91-Gt for linux-arm-kernel@lists.infradead.org; Wed, 10 Nov 2021 08:10:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 79C0660FDA; Wed, 10 Nov 2021 08:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636531849; bh=u8b5cf1EBSxtufFdQN4PMhOxgUC210Wh/YSOnRXF7Ys=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LUSdi1XyLhDhnWPmsceU86FDly+91QHJNd/3k4DSapQq89WuSlWwCiqsP5H4o4UGh V66NAEfPp3klHGoHxxIM7tHbiZX0VESNXIOZwNDtTgFYXUcNXvCrQyxrL6KY9vvAgY k9yX+YIXp/h34xymLRmPfTIQdP3qeg21CUqz7i2Q= Date: Wed, 10 Nov 2021 09:10:46 +0100 From: Greg KH To: cgel.zte@gmail.com Cc: johan@kernel.org, jirislaby@kernel.org, joel@jms.id.au, andrew@aj.id.au, zev@bewilderbeest.net, yao.jing2@zte.com.cn, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Zeal Robot Subject: Re: [PATCH] serial: 8250_aspeed_vuart: Replace snprintf in show functions with sysfs_emit Message-ID: References: <20211110024028.135887-1-yao.jing2@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211110024028.135887-1-yao.jing2@zte.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211110_001049_595932_81811D4D X-CRM114-Status: UNSURE ( 8.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 10, 2021 at 02:40:28AM +0000, cgel.zte@gmail.com wrote: > From: Jing Yao > > coccicheck complains about the use of snprintf() in sysfs show > functions: > WARNING use scnprintf or sprintf > > Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more > sense. Same subject and changelog comments as the staging driver change you sent in :( _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel