All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Hubertus Franke <frankeh@us.ibm.com>,
	Sergio Lopez <slp@redhat.com>,
	afrosi@redhat.com, James Bottomley <jejb@linux.ibm.com>,
	qemu-devel@nongnu.org, Dov Murik <dovmurik@linux.ibm.com>,
	Tyler Fanelli <tfanelli@redhat.com>,
	Tobin Feldman-Fitzthum <tobin@linux.ibm.com>,
	Jim Cadden <jcadden@ibm.com>,
	dinechin@redhat.com, John Ferlan <jferlan@redhat.com>
Subject: Re: SEV guest attestation
Date: Thu, 25 Nov 2021 16:08:48 +0000	[thread overview]
Message-ID: <YZ+1EOvL7/6Usk0z@work-vm> (raw)
In-Reply-To: <YZ+yO0vNVgh/KeJi@redhat.com>

* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Thu, Nov 25, 2021 at 03:40:36PM +0000, Dr. David Alan Gilbert wrote:
> > * Sergio Lopez (slp@redhat.com) wrote:
> > > On Thu, Nov 25, 2021 at 02:44:51PM +0200, Dov Murik wrote:
> > > > 
> > > > SEV-ES has pre-launch measurement and secret injection, just like SEV
> > > > (except that the measurement includes the initial states of all vcpus,
> > > > that is, their VMSAs.  BTW that means that in order to calculate the
> > > > measurement the Attestation Server must know exactly how many vcpus are
> > > > in the VM).
> > > 
> > > You need the number of vCPUs and an idea of what their initial state
> > > is going to be, to be able to reproduce the same VMSA struct in the
> > > Attestation Server.
> > > 
> > > This may tie the Attestation Server with a particular version of both
> > > QEMU and KVM. I haven't checked if configuration changes in QEMU may
> > > also have an impact on it.
> > 
> > That's all OK; I'm expecting the attestation server to be given a whole
> > pile of information about the apparent environment to check.
> 
> Generally though we try not to let a VM to tied to a specific
> version of software. eg use machine types to ensure that the
> guest can run on any QEMU version, and get the same environment.
> This lets host admin upgrade the host software for bug/security
> fixes without negatively impacting users. It'd be nice not to
> loose that feature with SEV if possible.
> 
> IOW, if there are aspects of the vCPU initial state that might
> vary over time with different QEMU versions, should we be looking
> to tie that variance into the machine type version.

It's not tied to a particular version; but you may need to let the
attesting server know what version it's using so that it can check
everything adds up.

Dave

> For KVM changes, this might again come back to the idea fo a
> "host type version".
> 
> Regards,
> Daniel
> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



  reply	other threads:[~2021-11-25 16:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 16:34 SEV guest attestation Tyler Fanelli
2021-11-24 17:27 ` Tyler Fanelli
2021-11-24 17:49 ` Dr. David Alan Gilbert
2021-11-24 18:29   ` Tyler Fanelli
2021-11-24 17:57 ` Daniel P. Berrangé
2021-11-24 18:29   ` Dr. David Alan Gilbert
2021-11-25  7:14     ` Sergio Lopez
2021-11-25 12:44       ` Dov Murik
2021-11-25 13:42         ` Daniel P. Berrangé
2021-11-25 13:59           ` Dov Murik
2021-11-29 14:29             ` Brijesh Singh
2021-11-29 14:49               ` Brijesh Singh
2021-11-25 15:11         ` Sergio Lopez
2021-11-25 15:40           ` Dr. David Alan Gilbert
2021-11-25 15:56             ` Daniel P. Berrangé
2021-11-25 16:08               ` Dr. David Alan Gilbert [this message]
2021-11-29 13:33                 ` Dov Murik
2021-11-25 13:20       ` Dr. David Alan Gilbert
2021-11-25 13:36       ` Daniel P. Berrangé
2021-11-25 13:52       ` Daniel P. Berrangé
2021-11-25 13:55         ` Dov Murik
2021-11-25 15:00         ` Dr. David Alan Gilbert
2021-11-25 13:27     ` Daniel P. Berrangé
2021-11-25 13:50       ` Dov Murik
2021-11-25 13:56         ` Daniel P. Berrangé
2021-11-25 15:19       ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZ+1EOvL7/6Usk0z@work-vm \
    --to=dgilbert@redhat.com \
    --cc=afrosi@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dinechin@redhat.com \
    --cc=dovmurik@linux.ibm.com \
    --cc=frankeh@us.ibm.com \
    --cc=jcadden@ibm.com \
    --cc=jejb@linux.ibm.com \
    --cc=jferlan@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=slp@redhat.com \
    --cc=tfanelli@redhat.com \
    --cc=tobin@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.