From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF36C68 for ; Wed, 24 Nov 2021 08:52:53 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 843CF6044F; Wed, 24 Nov 2021 08:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637743973; bh=KkzqBUvGNUBsPo7CDvSCmHv1J7fmjeDSkGc2AKdm2W8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dMJhYXqxj/fFw5H+6QSAO48qY5U2Xey4Adbm3u5Em8r6kvYs6p4pkHXB8NVW1dR6j i6WyAxseizXMETRVNktOpQPHm8vNT9By/aVqHykQlpMcIbqpu4b6BT6q/H5I/8hZvw u/6rZk9oXFpmWeixFcCCSuJvHIpn8l0BvjgzlEUI= Date: Wed, 24 Nov 2021 09:52:50 +0100 From: Greg Kroah-Hartman To: Cai Huoqing Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 1/3] staging: zynpu: Add driver support for ARM(China) ZHOUYI AI accelerator Message-ID: References: <20211124084620.628-1-caihuoqing@baidu.com> <20211124084620.628-2-caihuoqing@baidu.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211124084620.628-2-caihuoqing@baidu.com> On Wed, Nov 24, 2021 at 04:46:15PM +0800, Cai Huoqing wrote: > ZHOUYI NPU is an AI accelerator chip which is integrated into ARM SOC, > such as Allwinner R329 SOC. > Add driver support for this AI accelerator here. > > This driver is not tandard linux style, there are some clean up works, "standard"? > fixing code style, refactorring. > And it only works with a closed source usermode driver, so need to > reverse the libraries, and impelement it, then open source > the usermode driver. Who will be doing the "reversing" of the usermode driver? We can't take this now if there's no actual users of this code that anyone can test. Why not just change the license of the usermode code now to make this simpler? thanks, greg k-h