From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4257C433EF for ; Wed, 24 Nov 2021 15:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u7OjXvvlW/jtENggOX8xEcaHiLxagzhiAMI+jdAzMEs=; b=JYBwgYhRQ/XHbi NjR+vxYMUnonOPMjJmvjGr7oyQmtIkjKsSVTMM92Q1XjHaxPIPdZh62NjOIubuGuBxujB5byYScL2 2vP5vVGd3lR9mpJxhqkzF8AKtYscRQ6oHBUhGlwR8D+JYzCxgYKWISv1sDvBawZj1zrDbqTfoydOL FTo/YA3l2J6tRLzpxUEEXMImeNadeDrmXDq3dq1HfWknjPImSuwWANjW8PjijQ2WM/4Yf63kSWbvB eB8gmBHn7HVb+pXfLrc2DsXONxr+4EHwIdLT+fyT4CJ4MgoY59J29qCev01qPdi9kjyxv3Tj8cB0K Qhb0V/sl0f4h2xOQHkeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpuJh-0056Ez-SY; Wed, 24 Nov 2021 15:36:14 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpuJe-0056Dt-6h for linux-arm-kernel@lists.infradead.org; Wed, 24 Nov 2021 15:36:11 +0000 Received: by mail-wm1-x335.google.com with SMTP id 77-20020a1c0450000000b0033123de3425so5838447wme.0 for ; Wed, 24 Nov 2021 07:36:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9axgss5JK/d4JEsqVSzEUVHdFM9P3LASCpmPJrqXw+4=; b=WypPoA5Iumpwhit1UWOxjKhEmdev0XG8irGEOPKfdXs2/OsOrhFUOf5qNjvJ7nTJRE WhvhXkY0q52nuWxuCEEWeY0Dt6QCG3xgIQ6nDUKDwrBwBs3ZRAlTXMyvqTmf28td0uoT ERRcaAcPQxkzwCZ/MFvXF/cEQ729giTQWe5cZ6Q6O7RYhPiOJ74NEuSlgyf3hdsUPOqp mBY41YCfwEqenzPvqrCmL11BH/qUB57dqhp6nZSlna9FhvB7qIRNIRHaxvI3nHu9uQOe M/lCYXCzm9bHOOD7q5lfaA9HZnGTpypX4i8yjQuvbTOiB4B8BT/ChvgH2PdBleHG1vaU /woA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9axgss5JK/d4JEsqVSzEUVHdFM9P3LASCpmPJrqXw+4=; b=0MQ79tHpbfjarnCcaRPzchhlapi+4lVExuiJucp7uJcZs0MXQ+mLSkifadZX7MZ7f+ XOLJa/qRGADUa0l7Mnsugfjq2bfBEwns80Fig1l/tbgxMgC1sP4DEj8Hkw2BM0g3FXqx T+mEH5fMcDiU8GlKDeN7rT7u8LjtNv0RzhuwZabxpx5e4SXJ/NPw8D6uESymNZ1MUABl mQeT5gix8d3HltPQYY7LURzgBQvdbPcz3E9PStGrKTg0Nw7aDDJObrOs0iRSuE7wn00Y P/99g1zGsniRsawSEn//VcYZJ/7mko8ia1e9bYRFesVodfIHCa7r+rV0U5F3kgcEcT8X dqFQ== X-Gm-Message-State: AOAM532+/0J/xvwCJt5qtDQvOyfl/JU7MecEg/QmZb9njJu5tNqdaDFI nVPz0IV0VaO87YYt5Zc5ynP6vQ== X-Google-Smtp-Source: ABdhPJzrjAX/IQMZmWBDLKyMvMXU2IgliP1qCaR4MVKaWRuyssUDeJYnPYeNGh7Mo5dnQM8sMsvP9g== X-Received: by 2002:a05:600c:2f17:: with SMTP id r23mr16397453wmn.93.1637768168666; Wed, 24 Nov 2021 07:36:08 -0800 (PST) Received: from google.com ([2.31.167.61]) by smtp.gmail.com with ESMTPSA id h2sm160253wrz.23.2021.11.24.07.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 07:36:08 -0800 (PST) Date: Wed, 24 Nov 2021 15:36:06 +0000 From: Lee Jones To: Claudiu Beznea Subject: Re: [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Message-ID: References: <20211028135138.3481166-1-claudiu.beznea@microchip.com> <20211028135138.3481166-3-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211028135138.3481166-3-claudiu.beznea@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_073610_287594_2235072F X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, romain.izard.pro@gmail.com, Codrin Ciubotariu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAyOCBPY3QgMjAyMSwgQ2xhdWRpdSBCZXpuZWEgd3JvdGU6Cgo+IEZsZXhjb20gSVAg ZW1iZWRzIDMgb3RoZXIgSVBzOiB1c2FydCwgaTJjLCBzcGkgYW5kIHNlbGVjdHMgdGhlIG9wZXJh dGlvbgo+IG1vZGUgKHVzYXJ0LCBpMmMsIHNwaSkgdmlhIG1vZGUgcmVnaXN0ZXIgKEZMRVhfTVIp LiBPbiBpMmMgYnVzIHRoZXJlIG1pZ2h0Cj4gYmUgY29ubmVjdGVkIGNyaXRpY2FsIGRldmljZXMg KGxpa2UgUE1JQykgd2hpY2ggb24gc3VzcGVuZC9yZXN1bWUgc2hvdWxkCj4gYmUgc3VzcGVuZGVk L3Jlc3VtZWQgYXQgdGhlIGVuZC9iZWdpbm5pbmcuIGkyYyB1c2VzCj4gLnN1c3BlbmRfbm9pcnEv LnJlc3VtZV9ub2lycSBmb3IgdGhpcyBraW5kIG9mIHB1cnBvc2VzLiBBbGlnbiBmbGV4Y29tCj4g dG8gdXNlIC5yZXN1bWVfbm9pcnEgYXMgaXQgc2hvdWxkIGJlIHJlc3VtZWQgYmVmb3JlIHRoZSBl bWJlZGRlZCBJUHMuCj4gT3RoZXJ3aXNlIHRoZSBlbWJlZGRlZCBkZXZpY2VzIG1pZ2h0IGJlaGF2 ZSBiYWRseS4KPiAKPiBGaXhlczogN2ZkZWMxMTAxNWMzICgiYXRtZWxfZmxleGNvbTogU3VwcG9y dCByZXN1bWluZyBhZnRlciBhIGNoaXAgcmVzZXQiKQo+IFNpZ25lZC1vZmYtYnk6IENsYXVkaXUg QmV6bmVhIDxjbGF1ZGl1LmJlem5lYUBtaWNyb2NoaXAuY29tPgo+IFRlc3RlZC1ieTogQ29kcmlu IENpdWJvdGFyaXUgPGNvZHJpbi5jaXVib3Rhcml1QG1pY3JvY2hpcC5jb20+Cj4gQWNrZWQtYnk6 IE5pY29sYXMgRmVycmUgPG5pY29sYXMuZmVycmVAbWljcm9jaGlwLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9tZmQvYXRtZWwtZmxleGNvbS5jIHwgNyArKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0 IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpBcHBsaWVkLCB0aGFua3MuCgotLSAKTGVl IEpvbmVzIFvmnY7nkLzmlq9dClNlbmlvciBUZWNobmljYWwgTGVhZCAtIERldmVsb3BlciBTZXJ2 aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQXJtIFNvQ3MKRm9s bG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F4C0C433F5 for ; Wed, 24 Nov 2021 15:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241653AbhKXPjU (ORCPT ); Wed, 24 Nov 2021 10:39:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231860AbhKXPjT (ORCPT ); Wed, 24 Nov 2021 10:39:19 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BA46C061574 for ; Wed, 24 Nov 2021 07:36:10 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id j140-20020a1c2392000000b003399ae48f58so5782298wmj.5 for ; Wed, 24 Nov 2021 07:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9axgss5JK/d4JEsqVSzEUVHdFM9P3LASCpmPJrqXw+4=; b=WypPoA5Iumpwhit1UWOxjKhEmdev0XG8irGEOPKfdXs2/OsOrhFUOf5qNjvJ7nTJRE WhvhXkY0q52nuWxuCEEWeY0Dt6QCG3xgIQ6nDUKDwrBwBs3ZRAlTXMyvqTmf28td0uoT ERRcaAcPQxkzwCZ/MFvXF/cEQ729giTQWe5cZ6Q6O7RYhPiOJ74NEuSlgyf3hdsUPOqp mBY41YCfwEqenzPvqrCmL11BH/qUB57dqhp6nZSlna9FhvB7qIRNIRHaxvI3nHu9uQOe M/lCYXCzm9bHOOD7q5lfaA9HZnGTpypX4i8yjQuvbTOiB4B8BT/ChvgH2PdBleHG1vaU /woA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9axgss5JK/d4JEsqVSzEUVHdFM9P3LASCpmPJrqXw+4=; b=ID/HHal0qQlJ3fcPDdVVv+2IfjF1m3zLo7cBL54/YXTaxrF9ngDt43WnB8aHK+iQob yG/rp5NF+jLG4fxLdesiuYx/XD/Vh76emiRzZW64h3Rcviq5bmOBG7ltG9vyoYocdsqm /7D0IzotlQhbFCgmfeQA2Djdg44A3UEaPkl+bJoPoGEALvKVTlSTvju++R0v6W4leGUx zzTuqF9CcMVpB59N4+dYiL50qr/xrMWm6SRFHEVUYF09HJO8kqWNbm/DPdqY4zomo59s vnJgd1cJ6uI5+loY+STD5+0FLoAwfaiuU2QRLekXLOLOGTTJAv+osQPBWh6VtD0vFTID WHAg== X-Gm-Message-State: AOAM53238W9LDAPZ28Y9+1kok9NioCsZPwY7HmIMVCEm1xslNfw2g1Qg a9/RC2crlNc2ejM87G+CHWKjvQ== X-Google-Smtp-Source: ABdhPJzrjAX/IQMZmWBDLKyMvMXU2IgliP1qCaR4MVKaWRuyssUDeJYnPYeNGh7Mo5dnQM8sMsvP9g== X-Received: by 2002:a05:600c:2f17:: with SMTP id r23mr16397453wmn.93.1637768168666; Wed, 24 Nov 2021 07:36:08 -0800 (PST) Received: from google.com ([2.31.167.61]) by smtp.gmail.com with ESMTPSA id h2sm160253wrz.23.2021.11.24.07.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Nov 2021 07:36:08 -0800 (PST) Date: Wed, 24 Nov 2021 15:36:06 +0000 From: Lee Jones To: Claudiu Beznea Cc: nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, romain.izard.pro@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Codrin Ciubotariu Subject: Re: [PATCH v2 2/2] mfd: atmel-flexcom: use resume_noirq Message-ID: References: <20211028135138.3481166-1-claudiu.beznea@microchip.com> <20211028135138.3481166-3-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211028135138.3481166-3-claudiu.beznea@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Oct 2021, Claudiu Beznea wrote: > Flexcom IP embeds 3 other IPs: usart, i2c, spi and selects the operation > mode (usart, i2c, spi) via mode register (FLEX_MR). On i2c bus there might > be connected critical devices (like PMIC) which on suspend/resume should > be suspended/resumed at the end/beginning. i2c uses > .suspend_noirq/.resume_noirq for this kind of purposes. Align flexcom > to use .resume_noirq as it should be resumed before the embedded IPs. > Otherwise the embedded devices might behave badly. > > Fixes: 7fdec11015c3 ("atmel_flexcom: Support resuming after a chip reset") > Signed-off-by: Claudiu Beznea > Tested-by: Codrin Ciubotariu > Acked-by: Nicolas Ferre > --- > drivers/mfd/atmel-flexcom.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog