From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 839C8C433F5 for ; Wed, 24 Nov 2021 16:34:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0E30880BFB; Wed, 24 Nov 2021 16:34:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pGulq27lcaj5; Wed, 24 Nov 2021 16:34:50 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id D9E5F80BE8; Wed, 24 Nov 2021 16:34:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AB89FC002E; Wed, 24 Nov 2021 16:34:49 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 82AFCC0012 for ; Wed, 24 Nov 2021 16:34:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7117E40258 for ; Wed, 24 Nov 2021 16:34:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DURLB_YIvr7U for ; Wed, 24 Nov 2021 16:34:47 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9F3FA40251 for ; Wed, 24 Nov 2021 16:34:47 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 6B7A9341; Wed, 24 Nov 2021 17:34:44 +0100 (CET) Date: Wed, 24 Nov 2021 17:34:35 +0100 From: Joerg Roedel To: Alex Bee Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568 Message-ID: References: <20211124021325.858139-1-knaerzche@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com> Cc: Benjamin Gaignard , Heiko Stuebner , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote: > With the submission of iommu driver for RK3568 a subtle bug was > introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be > the other way arround - that leads to random errors, especially when > addresses beyond 32 bit are used. > > Fix it. > > Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2") > Signed-off-by: Alex Bee Applied for v5.16, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2296DC433EF for ; Wed, 24 Nov 2021 16:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kvxYC2+N+Y4Pui7SkZTCn56Ox6nQcrvJrgpd300JpKo=; b=zK2h93OK/QQBAf s61+br9Y9vj1SqErFC9Qtnivft9F1ml07G+RvvJL+jnevELSXR5hDvmgbsoEEwPXtVgI9kJDj0v9z yJ9Gpej9mAxr8S31Cw+KZCMRGkeyG96n+7jNj12AGeTNs/xn2nJuEyqIWM3auA+GicSc4770V3U4O kPichuD/DP08pTyxJQCLsMr9HIF540hbSvyhLpFjwAK80C5s4jzaeYENAZwwqP1GS6Qw2GLTHUAnM quDsLjLHziJO49eOx13XkXptRaJXY8pz2YqwO0uccowGh2sR1erydgmk9HKUQjRSnius7rTe9KDZr Bj62D/72SWuG7Gs/OqTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpvEf-005Grk-GY; Wed, 24 Nov 2021 16:35:05 +0000 Received: from 8bytes.org ([2a01:238:4383:600:38bc:a715:4b6d:a889] helo=theia.8bytes.org) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpvEP-005Gm2-Mg; Wed, 24 Nov 2021 16:34:51 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id 6B7A9341; Wed, 24 Nov 2021 17:34:44 +0100 (CET) Date: Wed, 24 Nov 2021 17:34:35 +0100 From: Joerg Roedel To: Alex Bee Cc: Will Deacon , Heiko Stuebner , Benjamin Gaignard , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568 Message-ID: References: <20211124021325.858139-1-knaerzche@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_083449_932259_332E7571 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote: > With the submission of iommu driver for RK3568 a subtle bug was > introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be > the other way arround - that leads to random errors, especially when > addresses beyond 32 bit are used. > > Fix it. > > Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2") > Signed-off-by: Alex Bee Applied for v5.16, thanks. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C6F7C433F5 for ; Wed, 24 Nov 2021 16:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=noJ8FvOCfk96ekfdeReqPk3WS5bZSnA8XK2k+6UJkwM=; b=fjQbsXUJNVtpcb dxr+EoapqPFnpXCs8Bp+L2H2YqP/vaDUgjEUb7R0RdS2go5z2rLl1LezGDQjm7BCGRIyKTSurU9QO VjDbhqGpJoDFW/NSKEElTZz9X7IQBsApZYalvMwiod2I6LSpEyxpxfOaCaiNkRpKT4zr9t+maLSYf B8XQVYWTg6JUSFhaI8P7SkkkG4/e3dec50eqGGEo+lavwSRjrnfxxnOZDjHwFuwUd8Pwo/Jk1Xu9B FPMrCHwYoJUDP7wK0jVoTw9muhE4SfhpKB8YS9p3sXJEQbIyMMq6goL1oaXmpbqVvD2rYdvAyHj6j EVujwJvyHQBarxjH2Pzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpvET-005GoR-S3; Wed, 24 Nov 2021 16:34:53 +0000 Received: from 8bytes.org ([2a01:238:4383:600:38bc:a715:4b6d:a889] helo=theia.8bytes.org) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpvEP-005Gm2-Mg; Wed, 24 Nov 2021 16:34:51 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id 6B7A9341; Wed, 24 Nov 2021 17:34:44 +0100 (CET) Date: Wed, 24 Nov 2021 17:34:35 +0100 From: Joerg Roedel To: Alex Bee Cc: Will Deacon , Heiko Stuebner , Benjamin Gaignard , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568 Message-ID: References: <20211124021325.858139-1-knaerzche@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211124_083449_932259_332E7571 X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote: > With the submission of iommu driver for RK3568 a subtle bug was > introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be > the other way arround - that leads to random errors, especially when > addresses beyond 32 bit are used. > > Fix it. > > Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2") > Signed-off-by: Alex Bee Applied for v5.16, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DD16C433F5 for ; Wed, 24 Nov 2021 16:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349070AbhKXQh5 (ORCPT ); Wed, 24 Nov 2021 11:37:57 -0500 Received: from 8bytes.org ([81.169.241.247]:59474 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349029AbhKXQh4 (ORCPT ); Wed, 24 Nov 2021 11:37:56 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 6B7A9341; Wed, 24 Nov 2021 17:34:44 +0100 (CET) Date: Wed, 24 Nov 2021 17:34:35 +0100 From: Joerg Roedel To: Alex Bee Cc: Will Deacon , Heiko Stuebner , Benjamin Gaignard , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/rockchip: Fix PAGE_DESC_HI_MASKs for RK3568 Message-ID: References: <20211124021325.858139-1-knaerzche@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211124021325.858139-1-knaerzche@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 24, 2021 at 03:13:25AM +0100, Alex Bee wrote: > With the submission of iommu driver for RK3568 a subtle bug was > introduced: PAGE_DESC_HI_MASK1 and PAGE_DESC_HI_MASK2 have to be > the other way arround - that leads to random errors, especially when > addresses beyond 32 bit are used. > > Fix it. > > Fixes: c55356c534aa ("iommu: rockchip: Add support for iommu v2") > Signed-off-by: Alex Bee Applied for v5.16, thanks.