From: Jeremy Sowden <jeremy@azazel.net>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [ulogd2 PATCH v3 14/16] build: remove unnecessary `AC_SUBST` calls
Date: Sun, 14 Nov 2021 15:31:14 +0000 [thread overview]
Message-ID: <YZErwsUUKHV5omgP@azazel.net> (raw)
In-Reply-To: <72852nsr-op91-6618-2r4-73995n6rs64@vanv.qr>
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
On 2021-11-14, at 15:58:48 +0100, Jan Engelhardt wrote:
> On Sunday 2021-11-14 15:00, Jeremy Sowden wrote:
> >We don't use the variables being passed to `AC_SUBST` in these calls
> as
> >output variables, so remove them.
>
> >-AC_SUBST(PQINCPATH)
> >-AC_SUBST(PQLIBPATH)
> >-AC_SUBST(PQLIBS)
>
> Eh, but why? These are all still used.
You're quite right. Fit of idiocy on my part.
J.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-14 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-14 14:00 [ulogd2 PATCH v3 00/16] Build Improvements Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 01/16] gitignore: add Emacs artefacts Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 02/16] gitignore: ignore .dirstamp Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 03/16] build: remove unused Makefile fragment Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 04/16] build: remove empty filter sub-directory Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 05/16] build: move CPP `-D` flag Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 06/16] build: add Make_global.am for common flags Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 07/16] build: use `dist_man_MANS` to declare man-pages Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 08/16] build: skip sub-directories containing disabled plugins Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 09/16] build: group `*_la_*` variables with their libraries Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 10/16] build: delete commented-out code Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 11/16] build: use correct automake variable for library dependencies Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 12/16] build: update obsolete autoconf macros Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 13/16] build: remove commented-out code Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 14/16] build: remove unnecessary `AC_SUBST` calls Jeremy Sowden
2021-11-14 14:58 ` Jan Engelhardt
2021-11-14 15:31 ` Jeremy Sowden [this message]
2021-11-14 14:00 ` [ulogd2 PATCH v3 15/16] build: quote autoconf macro arguments Jeremy Sowden
2021-11-14 14:00 ` [ulogd2 PATCH v3 16/16] build: use `AS_IF` consistently in configure.ac Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZErwsUUKHV5omgP@azazel.net \
--to=jeremy@azazel.net \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.