From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Dennis Zhou <dennis@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Christoph Lameter <cl@linux.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h
Date: Mon, 15 Nov 2021 12:38:03 +0200 [thread overview]
Message-ID: <YZI4i5hsgD4pDjoQ@smile.fi.intel.com> (raw)
In-Reply-To: <YZIs1FvxA0hKylNd@alley>
On Mon, Nov 15, 2021 at 10:48:04AM +0100, Petr Mladek wrote:
> On Fri 2021-11-12 13:15:51, Dennis Zhou wrote:
> > On Fri, Nov 12, 2021 at 04:07:49PM +0200, Andy Shevchenko wrote:
> > > After the commit 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> > > in NMI") the printk.h is not needed anymore in percpu.h.
> > >
> > > Moreover `make headerdep` complains (an excerpt)
> > >
> > > In file included from linux/printk.h,
> > > from linux/dynamic_debug.h:188
> > > from linux/printk.h:559 <-- here
> > > from linux/percpu.h:9
> > > from linux/idr.h:17
> > > include/net/9p/client.h:13: warning: recursive header inclusion
> > >
> > > Yeah, it's not a root cause of this, but removing will help to reduce
> > > the noise.
> > >
> > > Fixes: 42a0bb3f7138 ("printk/nmi: generic solution for safe printk
> > > in NMI")
>
> Yup, the include was there because of printk_func_t definition that
> was removed by the above commit.
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> > Hey Andrew, it doesn't seem like I have anything big coming through
> > percpu, do you mind taking this. I might have some stuff due to sh, but
> > I'm still working on that with them.
>
> I assume that either Andrew or Dennis will take this patch.
I assumed you take it, that's why I haven't Cc'ed Andrew in the first place,
but it seems you have a consensus with Dennis that Andrew is the best
maintainer to take this. So, I'll send v2 with tags and Cc to him.
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-15 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:07 [PATCH v1 1/1] printk: Remove printk.h inclusion in percpu.h Andy Shevchenko
2021-11-12 18:15 ` Dennis Zhou
2021-11-15 9:48 ` Petr Mladek
2021-11-15 10:38 ` Andy Shevchenko [this message]
2021-11-15 13:57 ` Petr Mladek
2021-11-15 14:20 ` Andy Shevchenko
2021-11-15 14:34 ` Petr Mladek
2021-11-15 15:04 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZI4i5hsgD4pDjoQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.