From: Sam Ravnborg <sam@ravnborg.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: airlied@linux.ie, ray.huang@amd.com,
linux-graphics-maintainer@vmware.com,
dri-devel@lists.freedesktop.org, christian.koenig@amd.com
Subject: Re: [PATCH 2/3] drm/vmwgfx: Copy DRM hash-table code into driver
Date: Mon, 15 Nov 2021 17:27:15 +0100 [thread overview]
Message-ID: <YZKKY2wQS7SEujPh@ravnborg.org> (raw)
In-Reply-To: <20211115125539.1730-3-tzimmermann@suse.de>
Hi Thomas,
On Mon, Nov 15, 2021 at 01:55:38PM +0100, Thomas Zimmermann wrote:
> Besides some legacy code, vmwgfx is the only user of DRM's hash-
> table implementation. Copy the code into the driver, so that the
> core code can be retired.
For the record - I have no clue what legacy code uses the DRM hash-table
for.
>
> No functional changes. However, the real solution for vmwgfx is to
> use Linux' generic hash-table functions.
Would it be possible to use the Linux hash-table now rather than this
mid-step where a lot of code is added to wmgfx only to be removed
later?
If we go for this way then a todo item to fix this in wmgfx so someone
can fix this later would be nice.
Sam
next prev parent reply other threads:[~2021-11-15 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 12:55 [PATCH 0/3] drm: Make DRM hashtable legacy Thomas Zimmermann
2021-11-15 12:55 ` [PATCH 1/3] drm/ttm: Don't include drm_hashtab.h Thomas Zimmermann
2021-11-15 13:28 ` Christian König
2021-11-15 12:55 ` [PATCH 2/3] drm/vmwgfx: Copy DRM hash-table code into driver Thomas Zimmermann
2021-11-15 14:33 ` Daniel Vetter
2021-11-15 16:27 ` Sam Ravnborg [this message]
2021-11-16 9:11 ` Thomas Zimmermann
2021-11-15 17:00 ` Zack Rusin
2021-11-16 9:20 ` Thomas Zimmermann
2021-11-15 12:55 ` [PATCH 3/3] drm: Declare hashtable as legacy Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZKKY2wQS7SEujPh@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=ray.huang@amd.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.