From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94676C433EF for ; Tue, 16 Nov 2021 09:24:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 499CA61268 for ; Tue, 16 Nov 2021 09:24:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 499CA61268 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tp8cgsxfCeNoEoCR08bF4bzO4z0VP8K/Wnbh4eNq99I=; b=AtU5I1R0vZgoUp gyHHreOSM1V+qQcwiOFmxTPveHK8s3Qi1wpbRe2rAbZZNjFvemmkhRhSTOJ/pA6gUHHC27z/qkL8f j4FH5i2fJjzI7vvdlZwo7mo/QbaSuXgafvsL6vGAF1gqH2nOHbcMf0rXwgI7z8c8a2jgPEIVzXyeh o4yIbQOq7LmRSWztJs312cGrAl34J6lkueEQOTKq7/xnvTovf57d/NBMUjz7HdHeq3dhBIljODlpP +HHgMAVoIf6RjpUG4o06J1MnrL8zr4rMl4YSDJXt2SXGab9QRXQLS6jzFVabh+jAUZY96uJNVhM16 TxifSHkYcVe0KqQSYQYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmuhN-000vxo-PJ; Tue, 16 Nov 2021 09:24:17 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmuhD-000vtj-Gc for linux-mediatek@lists.infradead.org; Tue, 16 Nov 2021 09:24:09 +0000 Received: by mail-pj1-x1034.google.com with SMTP id j5-20020a17090a318500b001a6c749e697so1746601pjb.1 for ; Tue, 16 Nov 2021 01:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=owaydA/9dfzXygkoQ9b5wC+OlGrAMOC9LEkh/lAzv5I=; b=QMKycX4ZEQaoqQ026VxDUHwe+VqargI4Q56Ls7vof5Ssrt3G/nOSh2dyyoY6Cw02WF iFzhEy4rRt7z1+q0UupwntE3f0SNtv/+2FFKLmpIe9QX6rPKknymUxkADWNvKQ7UfQoc 1I+c/UYXvuoyS+f9aI27LrnNpGTn7VKPJ8jKnYU2ns2Bw6y6Flc8J9w3nG/EkE/0nBxQ 1+dMPFwBSyZHN3e+ZgOKTxa/qv2dqzO5wdeh7W8mVlHoAVUajMA1qeQ5HmOsWq9+NqOU iYO/LWu6lF15XzeRug5Q37kFz1sFMP942j6nzvnuqZqElH7Gy8dqO6Rusxak5WLORwOX nZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=owaydA/9dfzXygkoQ9b5wC+OlGrAMOC9LEkh/lAzv5I=; b=dtIKMBVbJMB0ahCKkEFOYMCw02pyES83uwYip+3q6M/RA+AyV4u8VHLuLAWeta15Za HVfw1rJ0HFDKfmfMhSFpDsEbt7pHqlv+Zq9u3UUuiXqBYFemYDgMTC7G3TpgYBLypL7x e0xuTo7iuwVEYW+1XK2AG0pCKSHNFuV4lzRg24oo1S8k/MvfNT/H7Gjzr3UsCCofVvm9 sQ0E9xfyVbUWJfkmbX1gm94yo7iROzNMStO+ztY2KVSR74dnj3GWJexaMMHfa7uTtyjy nEpNnycaa5fXd24m0B133yqqgGzFcHQ7xktp19YSDIqdU365msR9ezsSBMC9BVMGxegh wLUg== X-Gm-Message-State: AOAM5321AV3sxyrmdSndZoMBWSaSVeZf6AboMHU2gxbfQfRWtFEeV7rh vckznmBafpixyIudFxKhJBMc9A== X-Google-Smtp-Source: ABdhPJw4Q0VPOvcNLCMaHO78tfO9Z0o0vrEmI1ogL6v9qranzZOGcmxPrHs+6HbKgj/geyrRdmBzNA== X-Received: by 2002:a17:90a:9907:: with SMTP id b7mr71543402pjp.137.1637054646807; Tue, 16 Nov 2021 01:24:06 -0800 (PST) Received: from google.com ([2401:fa00:1:10:f590:685a:7893:90be]) by smtp.gmail.com with ESMTPSA id d2sm12436413pfu.203.2021.11.16.01.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 01:24:06 -0800 (PST) Date: Tue, 16 Nov 2021 17:24:01 +0800 From: Tzung-Bi Shih To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces Message-ID: References: <20211111041500.17363-1-yunfei.dong@mediatek.com> <20211111041500.17363-12-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211111041500.17363-12-yunfei.dong@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_012407_754684_5A1389FC X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Nov 11, 2021 at 12:14:52PM +0800, Yunfei Dong wrote: > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c [...] > +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx) > { [...] > + > + if (dev->subdev_dev[hw_idx]) > + return dev->subdev_dev[hw_idx]; > + > + node = dev->subdev_node[hw_idx]; > + if (!node) { > + mtk_v4l2_err("Get lat node fail:%d", hw_idx); > + return NULL; > + } > + > + hw_pdev = of_find_device_by_node(node); > + of_node_put(node); Raised the question in [v10,06/19] media: mtk-vcodec: Manage multi hardware information[1], is the reference count borrowed from mtk_vcodec_subdev_device_check? If so, it needs comments for documentation. [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20211111041500.17363-7-yunfei.dong@mediatek.com/ _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27CDDC433EF for ; Tue, 16 Nov 2021 09:25:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E425661C14 for ; Tue, 16 Nov 2021 09:25:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E425661C14 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yrkpbzAcX+dd/xVL2HtvOSF0f8yKmY8jxIaKgt2YE5c=; b=Z4nJvl1EAg/L7+ 346nNw7BqJJPn62IzEOcQTwgneJUWy0nWV78ju4lVmKWzGLUlwSVRsZhiQ4JChzaJOeuXRoM7XSzK gkDmxFYhl6j7rpRtywWbVtA4d+jEQUEFyVTRZdUb3v2Q3qoIAURD6s1O9IEAYt6wTo2p2vApCu6dt EyQ449UJOXv6I0N71cBCXGpATSG0A7SEgSq0Y6w1A7ClGpAKjvBEtW9j5bhrjiIOfFLhwd8uTx+h1 AZNDgucqkkju/8jK/alVqzvfF2l1IfTS6jMYySFr5XhebETaFQ1sllZyXB+KAPnSu61B6uxOG7XSD qFqrpyOQOk5/O9O4Le+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmuhS-000vyN-I8; Tue, 16 Nov 2021 09:24:23 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmuhE-000vtk-50 for linux-arm-kernel@lists.infradead.org; Tue, 16 Nov 2021 09:24:11 +0000 Received: by mail-pl1-x62a.google.com with SMTP id y7so16978232plp.0 for ; Tue, 16 Nov 2021 01:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=owaydA/9dfzXygkoQ9b5wC+OlGrAMOC9LEkh/lAzv5I=; b=QMKycX4ZEQaoqQ026VxDUHwe+VqargI4Q56Ls7vof5Ssrt3G/nOSh2dyyoY6Cw02WF iFzhEy4rRt7z1+q0UupwntE3f0SNtv/+2FFKLmpIe9QX6rPKknymUxkADWNvKQ7UfQoc 1I+c/UYXvuoyS+f9aI27LrnNpGTn7VKPJ8jKnYU2ns2Bw6y6Flc8J9w3nG/EkE/0nBxQ 1+dMPFwBSyZHN3e+ZgOKTxa/qv2dqzO5wdeh7W8mVlHoAVUajMA1qeQ5HmOsWq9+NqOU iYO/LWu6lF15XzeRug5Q37kFz1sFMP942j6nzvnuqZqElH7Gy8dqO6Rusxak5WLORwOX nZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=owaydA/9dfzXygkoQ9b5wC+OlGrAMOC9LEkh/lAzv5I=; b=JLhuparGUfuoppc/KntL4ZSo1PGZQ9ZdRUJlbZo2u7jpHWLKxOpJt8Dq+ZwJ7Bo2rt ZGZjKMbPGYZd7+1A2G8py+BC1fkWR2TCde9U3ue9T0wkp7ShYcBKichPYTrR2bS6Fhe0 yAX9ipQHcYU9AQm3RF810aBOMziq24lIZGIeHmn8eHadTp+xnmWNOgqzQ/CmurOOmgJn kKlVVsmB7a80XptrxJoxWe/xZnZh5l5UxC0NgtqhiVyl97TRqWbrL3p7WMxky47PBPtv Msv/wW+MmowpzyfdOMFkfFQr3/qLoJ5iJ3lnZ0iwgKY5NE/YRBLahPNAke39ngJin8Ss BUuw== X-Gm-Message-State: AOAM531yER85p0isTF7GYMLsu5kZ8NFiXFhaTOCE725UKYM0+7sf3OO1 LyNV1vufw6nv+F0czo52nKf+Xg== X-Google-Smtp-Source: ABdhPJw4Q0VPOvcNLCMaHO78tfO9Z0o0vrEmI1ogL6v9qranzZOGcmxPrHs+6HbKgj/geyrRdmBzNA== X-Received: by 2002:a17:90a:9907:: with SMTP id b7mr71543402pjp.137.1637054646807; Tue, 16 Nov 2021 01:24:06 -0800 (PST) Received: from google.com ([2401:fa00:1:10:f590:685a:7893:90be]) by smtp.gmail.com with ESMTPSA id d2sm12436413pfu.203.2021.11.16.01.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 01:24:06 -0800 (PST) Date: Tue, 16 Nov 2021 17:24:01 +0800 From: Tzung-Bi Shih To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces Message-ID: References: <20211111041500.17363-1-yunfei.dong@mediatek.com> <20211111041500.17363-12-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211111041500.17363-12-yunfei.dong@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_012408_220887_9435AF6A X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 11, 2021 at 12:14:52PM +0800, Yunfei Dong wrote: > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c [...] > +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx) > { [...] > + > + if (dev->subdev_dev[hw_idx]) > + return dev->subdev_dev[hw_idx]; > + > + node = dev->subdev_node[hw_idx]; > + if (!node) { > + mtk_v4l2_err("Get lat node fail:%d", hw_idx); > + return NULL; > + } > + > + hw_pdev = of_find_device_by_node(node); > + of_node_put(node); Raised the question in [v10,06/19] media: mtk-vcodec: Manage multi hardware information[1], is the reference count borrowed from mtk_vcodec_subdev_device_check? If so, it needs comments for documentation. [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20211111041500.17363-7-yunfei.dong@mediatek.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99BFC4332F for ; Tue, 16 Nov 2021 09:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92C4461268 for ; Tue, 16 Nov 2021 09:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233172AbhKPJ1h (ORCPT ); Tue, 16 Nov 2021 04:27:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233181AbhKPJ1L (ORCPT ); Tue, 16 Nov 2021 04:27:11 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A2E6C061766 for ; Tue, 16 Nov 2021 01:24:07 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id w33-20020a17090a6ba400b001a722a06212so1777703pjj.0 for ; Tue, 16 Nov 2021 01:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=owaydA/9dfzXygkoQ9b5wC+OlGrAMOC9LEkh/lAzv5I=; b=QMKycX4ZEQaoqQ026VxDUHwe+VqargI4Q56Ls7vof5Ssrt3G/nOSh2dyyoY6Cw02WF iFzhEy4rRt7z1+q0UupwntE3f0SNtv/+2FFKLmpIe9QX6rPKknymUxkADWNvKQ7UfQoc 1I+c/UYXvuoyS+f9aI27LrnNpGTn7VKPJ8jKnYU2ns2Bw6y6Flc8J9w3nG/EkE/0nBxQ 1+dMPFwBSyZHN3e+ZgOKTxa/qv2dqzO5wdeh7W8mVlHoAVUajMA1qeQ5HmOsWq9+NqOU iYO/LWu6lF15XzeRug5Q37kFz1sFMP942j6nzvnuqZqElH7Gy8dqO6Rusxak5WLORwOX nZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=owaydA/9dfzXygkoQ9b5wC+OlGrAMOC9LEkh/lAzv5I=; b=kbENwxBv1AjisFE59uVXlWhM65XGHtIxi+FT9KgPfXUhd9gvjUnUjfcmjKv0pCm9MK AnUc95tuALaE9YYffbICd6N70DZgkYouB4zzS1E1nYvZRgznGFIOIF1QwWJLaazGcJSa /eeK+d2JwAhqVC+GpN2BVd3VYPmugU2d570R5UO3DM6+kbeobzwZnrqB/7yteiiGC2g8 FSsPWCCaw8fy/xnImHdIngjmJQ9sVWwbKfyRp6CNIrCa8ymuG/VEMWH9V4920ECpK28T EmQWRourNZ9St/7781+i0B5TFDWyZybo+UBmOE0KzCwYuJAMu0/z22+6qKieU4IIuGmh vI5g== X-Gm-Message-State: AOAM533KU5rMGEIWZ3MiJhF51YOpDcXL6XksOXnPpKao4YUriOmkr7gS 8Gx01HtGzDpOgcFMyGN8J8gXMw== X-Google-Smtp-Source: ABdhPJw4Q0VPOvcNLCMaHO78tfO9Z0o0vrEmI1ogL6v9qranzZOGcmxPrHs+6HbKgj/geyrRdmBzNA== X-Received: by 2002:a17:90a:9907:: with SMTP id b7mr71543402pjp.137.1637054646807; Tue, 16 Nov 2021 01:24:06 -0800 (PST) Received: from google.com ([2401:fa00:1:10:f590:685a:7893:90be]) by smtp.gmail.com with ESMTPSA id d2sm12436413pfu.203.2021.11.16.01.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 01:24:06 -0800 (PST) Date: Tue, 16 Nov 2021 17:24:01 +0800 From: Tzung-Bi Shih To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces Message-ID: References: <20211111041500.17363-1-yunfei.dong@mediatek.com> <20211111041500.17363-12-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211111041500.17363-12-yunfei.dong@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Nov 11, 2021 at 12:14:52PM +0800, Yunfei Dong wrote: > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c [...] > +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx) > { [...] > + > + if (dev->subdev_dev[hw_idx]) > + return dev->subdev_dev[hw_idx]; > + > + node = dev->subdev_node[hw_idx]; > + if (!node) { > + mtk_v4l2_err("Get lat node fail:%d", hw_idx); > + return NULL; > + } > + > + hw_pdev = of_find_device_by_node(node); > + of_node_put(node); Raised the question in [v10,06/19] media: mtk-vcodec: Manage multi hardware information[1], is the reference count borrowed from mtk_vcodec_subdev_device_check? If so, it needs comments for documentation. [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20211111041500.17363-7-yunfei.dong@mediatek.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E69B3C433EF for ; Tue, 16 Nov 2021 09:24:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B306760EE4 for ; Tue, 16 Nov 2021 09:24:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B306760EE4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FC9A6EE77; Tue, 16 Nov 2021 09:24:08 +0000 (UTC) Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F62B6EE77 for ; Tue, 16 Nov 2021 09:24:07 +0000 (UTC) Received: by mail-pj1-x1029.google.com with SMTP id w33-20020a17090a6ba400b001a722a06212so1777702pjj.0 for ; Tue, 16 Nov 2021 01:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=owaydA/9dfzXygkoQ9b5wC+OlGrAMOC9LEkh/lAzv5I=; b=QMKycX4ZEQaoqQ026VxDUHwe+VqargI4Q56Ls7vof5Ssrt3G/nOSh2dyyoY6Cw02WF iFzhEy4rRt7z1+q0UupwntE3f0SNtv/+2FFKLmpIe9QX6rPKknymUxkADWNvKQ7UfQoc 1I+c/UYXvuoyS+f9aI27LrnNpGTn7VKPJ8jKnYU2ns2Bw6y6Flc8J9w3nG/EkE/0nBxQ 1+dMPFwBSyZHN3e+ZgOKTxa/qv2dqzO5wdeh7W8mVlHoAVUajMA1qeQ5HmOsWq9+NqOU iYO/LWu6lF15XzeRug5Q37kFz1sFMP942j6nzvnuqZqElH7Gy8dqO6Rusxak5WLORwOX nZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=owaydA/9dfzXygkoQ9b5wC+OlGrAMOC9LEkh/lAzv5I=; b=RaH3l46hbp5apvt5oXqxMPJjx1YPUWdz6Xk78VNbKTdYQDP/FC+zS5bYaQd+3LGVkc w16x7WW5N5Nrxj5ZXzN+zG5ucM65Bj/ba0gLOoI6jisUK96T+Rae5LzLkyLwJRIcTxJc HnGV3Lu7ay+Ai7SEZtktKm0HZo0vzwea0XEzy0UvPWAxJSiy50F1zHTSCFnQ4uX5Fqhk sJgVieVQG18bD4HHHb4Y6w5FryjvolvRc10xc7gw4ImHyvDeE7uRY0jGnZmwS0kXV5dm 14LroIvY0fO2TUOnsSBwVJIg2DpUBxalYdagB1TKKcEZlYVZ9eTiyS7GfXyDklInvyW4 NjVg== X-Gm-Message-State: AOAM531JVYrk2Qcu4eb1mbT1SvtfsSLfGwYMlGk6wLi/pd6yX2Cz/GUZ qb1jZru1nFDApQfYluUPq744YA== X-Google-Smtp-Source: ABdhPJw4Q0VPOvcNLCMaHO78tfO9Z0o0vrEmI1ogL6v9qranzZOGcmxPrHs+6HbKgj/geyrRdmBzNA== X-Received: by 2002:a17:90a:9907:: with SMTP id b7mr71543402pjp.137.1637054646807; Tue, 16 Nov 2021 01:24:06 -0800 (PST) Received: from google.com ([2401:fa00:1:10:f590:685a:7893:90be]) by smtp.gmail.com with ESMTPSA id d2sm12436413pfu.203.2021.11.16.01.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 01:24:06 -0800 (PST) Date: Tue, 16 Nov 2021 17:24:01 +0800 From: Tzung-Bi Shih To: Yunfei Dong Subject: Re: [PATCH v10, 11/19] media: mtk-vcodec: Generalize power and clock on/off interfaces Message-ID: References: <20211111041500.17363-1-yunfei.dong@mediatek.com> <20211111041500.17363-12-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211111041500.17363-12-yunfei.dong@mediatek.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew-CT Chen , Dafna Hirschfeld , dri-devel , Irui Wang , Mauro Carvalho Chehab , Benjamin Gaignard , Project_Global_Chrome_Upstream_Group@mediatek.com, Fritz Koenig , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Tzung-Bi Shih , Tomasz Figa , Rob Herring , linux-mediatek@lists.infradead.org, Hsin-Yi Wang , Matthias Brugger , Tiffany Lin , linux-arm-kernel@lists.infradead.org, Alexandre Courbot , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Hans Verkuil Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Nov 11, 2021 at 12:14:52PM +0800, Yunfei Dong wrote: > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.c [...] > +void *mtk_vcodec_get_hw_dev(struct mtk_vcodec_dev *dev, int hw_idx) > { [...] > + > + if (dev->subdev_dev[hw_idx]) > + return dev->subdev_dev[hw_idx]; > + > + node = dev->subdev_node[hw_idx]; > + if (!node) { > + mtk_v4l2_err("Get lat node fail:%d", hw_idx); > + return NULL; > + } > + > + hw_pdev = of_find_device_by_node(node); > + of_node_put(node); Raised the question in [v10,06/19] media: mtk-vcodec: Manage multi hardware information[1], is the reference count borrowed from mtk_vcodec_subdev_device_check? If so, it needs comments for documentation. [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20211111041500.17363-7-yunfei.dong@mediatek.com/