diff for duplicates of <YZNPFGPXfCLfJMq3@kroah.com> diff --git a/a/1.txt b/N1/1.txt index 53a1ad9..9aeaba1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,24 +3,24 @@ On Mon, Nov 15, 2021 at 10:35:23PM +0000, Winiarska, Iwona wrote: > > On Mon, Nov 15, 2021 at 07:25:45PM +0100, Iwona Winiarska wrote: > > > +void peci_device_destroy(struct peci_device *device) > > > +{ -> > > +???????bool killed; +> > > + bool killed; > > > + -> > > +???????device_lock(&device->dev); -> > > +???????killed = kill_device(&device->dev); +> > > + device_lock(&device->dev); +> > > + killed = kill_device(&device->dev); > > > > Eeek, why call this? > > -> > > +???????device_unlock(&device->dev); +> > > + device_unlock(&device->dev); > > > + -> > > +???????if (!killed) -> > > +???????????????return; +> > > + if (!killed) +> > > + return; > > > > What happened if something changed after you unlocked it? > > We either killed it, or the other caller killed it. > > > -> > Why is kill_device() required at all?? That's a very rare function to +> > Why is kill_device() required at all? That's a very rare function to > > call, and one that only one "bus" calls today because it is very > > special (i.e. crazy and broken...) > diff --git a/a/content_digest b/N1/content_digest index 32f2bce..6b7f6bb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,9 +3,38 @@ "ref\0YZKr1Rqfx6Cmw+Ok@kroah.com\0" "ref\0368c990c30c5bacde15ac4bce5db8389aea3ec9c.camel@intel.com\0" "From\0gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>\0" - "Subject\0[PATCH v3 06/13] peci: Add device detection\0" + "Subject\0Re: [PATCH v3 06/13] peci: Add device detection\0" "Date\0Tue, 16 Nov 2021 07:26:28 +0100\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Winiarska" + " Iwona <iwona.winiarska@intel.com>\0" + "Cc\0corbet@lwn.net <corbet@lwn.net>" + jae.hyun.yoo@linux.intel.com <jae.hyun.yoo@linux.intel.com> + linux-hwmon@vger.kernel.org <linux-hwmon@vger.kernel.org> + andrew@aj.id.au <andrew@aj.id.au> + Luck + Tony <tony.luck@intel.com> + Hansen + Dave <dave.hansen@intel.com> + d.mueller@elsoft.ch <d.mueller@elsoft.ch> + jdelvare@suse.com <jdelvare@suse.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + olof@lixom.net <olof@lixom.net> + rdunlap@infradead.org <rdunlap@infradead.org> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + linux-aspeed@lists.ozlabs.org <linux-aspeed@lists.ozlabs.org> + linux-doc@vger.kernel.org <linux-doc@vger.kernel.org> + arnd@arndb.de <arnd@arndb.de> + linux@roeck-us.net <linux@roeck-us.net> + zweiss@equinix.com <zweiss@equinix.com> + robh+dt@kernel.org <robh+dt@kernel.org> + openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org> + bp@alien8.de <bp@alien8.de> + joel@jms.id.au <joel@jms.id.au> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + pierre-louis.bossart@linux.intel.com <pierre-louis.bossart@linux.intel.com> + andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> + Williams + " Dan J <dan.j.williams@intel.com>\0" "\00:1\0" "b\0" "On Mon, Nov 15, 2021 at 10:35:23PM +0000, Winiarska, Iwona wrote:\n" @@ -13,24 +42,24 @@ "> > On Mon, Nov 15, 2021 at 07:25:45PM +0100, Iwona Winiarska wrote:\n" "> > > +void peci_device_destroy(struct peci_device *device)\n" "> > > +{\n" - "> > > +???????bool killed;\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240bool killed;\n" "> > > +\n" - "> > > +???????device_lock(&device->dev);\n" - "> > > +???????killed = kill_device(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240device_lock(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240killed = kill_device(&device->dev);\n" "> > \n" "> > Eeek, why call this?\n" "> > \n" - "> > > +???????device_unlock(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240device_unlock(&device->dev);\n" "> > > +\n" - "> > > +???????if (!killed)\n" - "> > > +???????????????return;\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!killed)\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return;\n" "> > \n" "> > What happened if something changed after you unlocked it?\n" "> \n" "> We either killed it, or the other caller killed it.\n" "> \n" "> > \n" - "> > Why is kill_device() required at all?? That's a very rare function to\n" + "> > Why is kill_device() required at all?\302\240 That's a very rare function to\n" "> > call, and one that only one \"bus\" calls today because it is very\n" "> > special (i.e. crazy and broken...)\n" "> \n" @@ -50,4 +79,4 @@ "\n" greg k-h -0e7ff3f11dbadde17bab26182ecc812f6229bc39c198bfe40dbd054a5df2ec6c +796960eeaaa8eb489e583acee78b52f24133e7ca53b54d7aa843fed73db96456
diff --git a/a/1.txt b/N2/1.txt index 53a1ad9..9aeaba1 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,24 +3,24 @@ On Mon, Nov 15, 2021 at 10:35:23PM +0000, Winiarska, Iwona wrote: > > On Mon, Nov 15, 2021 at 07:25:45PM +0100, Iwona Winiarska wrote: > > > +void peci_device_destroy(struct peci_device *device) > > > +{ -> > > +???????bool killed; +> > > + bool killed; > > > + -> > > +???????device_lock(&device->dev); -> > > +???????killed = kill_device(&device->dev); +> > > + device_lock(&device->dev); +> > > + killed = kill_device(&device->dev); > > > > Eeek, why call this? > > -> > > +???????device_unlock(&device->dev); +> > > + device_unlock(&device->dev); > > > + -> > > +???????if (!killed) -> > > +???????????????return; +> > > + if (!killed) +> > > + return; > > > > What happened if something changed after you unlocked it? > > We either killed it, or the other caller killed it. > > > -> > Why is kill_device() required at all?? That's a very rare function to +> > Why is kill_device() required at all? That's a very rare function to > > call, and one that only one "bus" calls today because it is very > > special (i.e. crazy and broken...) > diff --git a/a/content_digest b/N2/content_digest index 32f2bce..493aba1 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,9 +3,36 @@ "ref\0YZKr1Rqfx6Cmw+Ok@kroah.com\0" "ref\0368c990c30c5bacde15ac4bce5db8389aea3ec9c.camel@intel.com\0" "From\0gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>\0" - "Subject\0[PATCH v3 06/13] peci: Add device detection\0" + "Subject\0Re: [PATCH v3 06/13] peci: Add device detection\0" "Date\0Tue, 16 Nov 2021 07:26:28 +0100\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Winiarska" + " Iwona <iwona.winiarska@intel.com>\0" + "Cc\0linux-aspeed@lists.ozlabs.org <linux-aspeed@lists.ozlabs.org>" + linux-doc@vger.kernel.org <linux-doc@vger.kernel.org> + Hansen + Dave <dave.hansen@intel.com> + zweiss@equinix.com <zweiss@equinix.com> + jae.hyun.yoo@linux.intel.com <jae.hyun.yoo@linux.intel.com> + corbet@lwn.net <corbet@lwn.net> + openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org> + pierre-louis.bossart@linux.intel.com <pierre-louis.bossart@linux.intel.com> + linux@roeck-us.net <linux@roeck-us.net> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + jdelvare@suse.com <jdelvare@suse.com> + arnd@arndb.de <arnd@arndb.de> + robh+dt@kernel.org <robh+dt@kernel.org> + bp@alien8.de <bp@alien8.de> + Williams + Dan J <dan.j.williams@intel.com> + andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-hwmon@vger.kernel.org <linux-hwmon@vger.kernel.org> + Luck + Tony <tony.luck@intel.com> + andrew@aj.id.au <andrew@aj.id.au> + rdunlap@infradead.org <rdunlap@infradead.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + " olof@lixom.net <olof@lixom.net>\0" "\00:1\0" "b\0" "On Mon, Nov 15, 2021 at 10:35:23PM +0000, Winiarska, Iwona wrote:\n" @@ -13,24 +40,24 @@ "> > On Mon, Nov 15, 2021 at 07:25:45PM +0100, Iwona Winiarska wrote:\n" "> > > +void peci_device_destroy(struct peci_device *device)\n" "> > > +{\n" - "> > > +???????bool killed;\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240bool killed;\n" "> > > +\n" - "> > > +???????device_lock(&device->dev);\n" - "> > > +???????killed = kill_device(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240device_lock(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240killed = kill_device(&device->dev);\n" "> > \n" "> > Eeek, why call this?\n" "> > \n" - "> > > +???????device_unlock(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240device_unlock(&device->dev);\n" "> > > +\n" - "> > > +???????if (!killed)\n" - "> > > +???????????????return;\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!killed)\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return;\n" "> > \n" "> > What happened if something changed after you unlocked it?\n" "> \n" "> We either killed it, or the other caller killed it.\n" "> \n" "> > \n" - "> > Why is kill_device() required at all?? That's a very rare function to\n" + "> > Why is kill_device() required at all?\302\240 That's a very rare function to\n" "> > call, and one that only one \"bus\" calls today because it is very\n" "> > special (i.e. crazy and broken...)\n" "> \n" @@ -50,4 +77,4 @@ "\n" greg k-h -0e7ff3f11dbadde17bab26182ecc812f6229bc39c198bfe40dbd054a5df2ec6c +0eb10c0d6a8c438fec25ad34edb01d187083d9c6cc801b04219d2bf5922dbacd
diff --git a/a/1.txt b/N3/1.txt index 53a1ad9..d0ff4d6 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -3,24 +3,24 @@ On Mon, Nov 15, 2021 at 10:35:23PM +0000, Winiarska, Iwona wrote: > > On Mon, Nov 15, 2021 at 07:25:45PM +0100, Iwona Winiarska wrote: > > > +void peci_device_destroy(struct peci_device *device) > > > +{ -> > > +???????bool killed; +> > > + bool killed; > > > + -> > > +???????device_lock(&device->dev); -> > > +???????killed = kill_device(&device->dev); +> > > + device_lock(&device->dev); +> > > + killed = kill_device(&device->dev); > > > > Eeek, why call this? > > -> > > +???????device_unlock(&device->dev); +> > > + device_unlock(&device->dev); > > > + -> > > +???????if (!killed) -> > > +???????????????return; +> > > + if (!killed) +> > > + return; > > > > What happened if something changed after you unlocked it? > > We either killed it, or the other caller killed it. > > > -> > Why is kill_device() required at all?? That's a very rare function to +> > Why is kill_device() required at all? That's a very rare function to > > call, and one that only one "bus" calls today because it is very > > special (i.e. crazy and broken...) > @@ -39,3 +39,8 @@ device? Who wants that? thanks, greg k-h + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N3/content_digest index 32f2bce..f7e2b5c 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,9 +3,38 @@ "ref\0YZKr1Rqfx6Cmw+Ok@kroah.com\0" "ref\0368c990c30c5bacde15ac4bce5db8389aea3ec9c.camel@intel.com\0" "From\0gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>\0" - "Subject\0[PATCH v3 06/13] peci: Add device detection\0" + "Subject\0Re: [PATCH v3 06/13] peci: Add device detection\0" "Date\0Tue, 16 Nov 2021 07:26:28 +0100\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0Winiarska" + " Iwona <iwona.winiarska@intel.com>\0" + "Cc\0corbet@lwn.net <corbet@lwn.net>" + jae.hyun.yoo@linux.intel.com <jae.hyun.yoo@linux.intel.com> + linux-hwmon@vger.kernel.org <linux-hwmon@vger.kernel.org> + andrew@aj.id.au <andrew@aj.id.au> + Luck + Tony <tony.luck@intel.com> + Hansen + Dave <dave.hansen@intel.com> + d.mueller@elsoft.ch <d.mueller@elsoft.ch> + jdelvare@suse.com <jdelvare@suse.com> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + olof@lixom.net <olof@lixom.net> + rdunlap@infradead.org <rdunlap@infradead.org> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + linux-aspeed@lists.ozlabs.org <linux-aspeed@lists.ozlabs.org> + linux-doc@vger.kernel.org <linux-doc@vger.kernel.org> + arnd@arndb.de <arnd@arndb.de> + linux@roeck-us.net <linux@roeck-us.net> + zweiss@equinix.com <zweiss@equinix.com> + robh+dt@kernel.org <robh+dt@kernel.org> + openbmc@lists.ozlabs.org <openbmc@lists.ozlabs.org> + bp@alien8.de <bp@alien8.de> + joel@jms.id.au <joel@jms.id.au> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + pierre-louis.bossart@linux.intel.com <pierre-louis.bossart@linux.intel.com> + andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> + Williams + " Dan J <dan.j.williams@intel.com>\0" "\00:1\0" "b\0" "On Mon, Nov 15, 2021 at 10:35:23PM +0000, Winiarska, Iwona wrote:\n" @@ -13,24 +42,24 @@ "> > On Mon, Nov 15, 2021 at 07:25:45PM +0100, Iwona Winiarska wrote:\n" "> > > +void peci_device_destroy(struct peci_device *device)\n" "> > > +{\n" - "> > > +???????bool killed;\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240bool killed;\n" "> > > +\n" - "> > > +???????device_lock(&device->dev);\n" - "> > > +???????killed = kill_device(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240device_lock(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240killed = kill_device(&device->dev);\n" "> > \n" "> > Eeek, why call this?\n" "> > \n" - "> > > +???????device_unlock(&device->dev);\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240device_unlock(&device->dev);\n" "> > > +\n" - "> > > +???????if (!killed)\n" - "> > > +???????????????return;\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (!killed)\n" + "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return;\n" "> > \n" "> > What happened if something changed after you unlocked it?\n" "> \n" "> We either killed it, or the other caller killed it.\n" "> \n" "> > \n" - "> > Why is kill_device() required at all?? That's a very rare function to\n" + "> > Why is kill_device() required at all?\302\240 That's a very rare function to\n" "> > call, and one that only one \"bus\" calls today because it is very\n" "> > special (i.e. crazy and broken...)\n" "> \n" @@ -48,6 +77,11 @@ "\n" "thanks,\n" "\n" - greg k-h + "greg k-h\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -0e7ff3f11dbadde17bab26182ecc812f6229bc39c198bfe40dbd054a5df2ec6c +6a17f1044c37e9fc98ef793d565fe29e51cafc6a53bd44ac527a527a715fed6b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.